[Storage] [DataMovement] NFS over REST Azure SDK Feedback (Azure#50369)

* initial commit

* Delete sdk/storage/Azure.Storage.DataMovement/api/Azure.Storage.DataMovement.net6.0.cs

* fixed changelog wording

Author: nickliu-msft

sdk/storage/Azure.Storage.DataMovement.Files.Shares/CHANGELOG.md

@@ -3,8 +3,12 @@
 ## 12.2.0-beta.1 (Unreleased)
 
 ### Features Added
+- Added support for preserving NFS properties and permissions in Share Files and Share Directories for Share-to-Share copy transfers.
+- Added support for preserving SMB properties and permissions in Share Directories for Share-to-Share copy transfers.
+- Added basic support for handling hard links and soft links in NFS Share-to-Share copy and Share-to-local download transfers.
 
 ### Breaking Changes
+- Added protocol validation for Share-to-Share copy transfers. Validation is enabled by default and will fail the transfer if there are no share-level permissions. To bypass this, please enable `SkipProtocolValidation`.
 
 ### Bugs Fixed
 

sdk/storage/Azure.Storage.DataMovement.Files.Shares/src/DataMovementSharesExtensions.cs

@@ -550,10 +550,7 @@ internal static StorageResourceContainerProperties ToStorageResourceContainerPro
             {
                 rawProperties.WriteKeyValue(DataMovementConstants.ResourceProperties.FileMode, directoryProperties.PosixProperties.FileMode);
             }
-            return new StorageResourceContainerProperties()
-            {
-                RawProperties = rawProperties
-            };
+            return new StorageResourceContainerProperties(rawProperties);
         }
 
         internal static void AddToStorageResourceContainerProperties(
@@ -702,10 +699,7 @@ internal static StorageResourceContainerProperties ToResourceContainerProperties
             {
                 properties.Add(DataMovementConstants.ResourceProperties.DestinationFilePermissionKey, destinationPermissionKey);
             }
-            return new StorageResourceContainerProperties()
-            {
-                RawProperties = properties
-            };
+            return new StorageResourceContainerProperties(properties);
         }
 
         private static string[] ConvertContentPropertyObjectToStringArray(string contentPropertyName, object contentPropertyValue)

sdk/storage/Azure.Storage.DataMovement.Files.Shares/src/ShareFileStorageResourceOptions.cs

@@ -58,7 +58,7 @@ public class ShareFileStorageResourceOptions
         /// Optional. Specifies whether the Share uses NFS or SMB protocol.
         /// By default this value is set to SMB.
         /// This is intended to be set on the source and destination Share.
-        /// Applies to copy, upload, and download transfers. Protocol validation only applies to Share-to-Share copy transfers.
+        /// For Share-to-Share copy transfers, the protocol is validated and must be correctly set to process the transfer and preserve the proper properties and permissions.
         ///
         /// Note: Only NFS -> NFS and SMB -> SMB transfers are currently supported.
         /// For NFS Share-to-Share Copy and Download transfers, Hard links will be copied as regular files and Symbolic links are skipped.

sdk/storage/Azure.Storage.DataMovement.Files.Shares/src/SharesPathScanner.cs

@@ -41,7 +41,7 @@ public virtual async IAsyncEnumerable<StorageResource> ScanAsync(
                     options: new() { Traits = traits },
                     cancellationToken: cancellationToken).ConfigureAwait(false))
                 {
-                    string destinationPermissionKey = string.Empty;
+                    string destinationPermissionKey = default;
                     if (destinationShare != default && item.PermissionKey != default)
                     {
                         // Check if the permission key is already created.

sdk/storage/Azure.Storage.DataMovement/api/Azure.Storage.DataMovement.net8.0.cs

@@ -67,9 +67,9 @@ protected StorageResourceContainer() { }
     public partial class StorageResourceContainerProperties
     {
         [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public StorageResourceContainerProperties() { }
+        public StorageResourceContainerProperties(System.Collections.Generic.IDictionary<string, object> properties = null) { }
         [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public System.Collections.Generic.IDictionary<string, object> RawProperties { get { throw null; } set { } }
+        public System.Collections.Generic.IDictionary<string, object> RawProperties { get { throw null; } }
     }
     [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
     public partial class StorageResourceCopyFromUriOptions

sdk/storage/Azure.Storage.DataMovement/api/Azure.Storage.DataMovement.netstandard2.0.cs

@@ -67,9 +67,9 @@ protected StorageResourceContainer() { }
     public partial class StorageResourceContainerProperties
     {
         [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public StorageResourceContainerProperties() { }
+        public StorageResourceContainerProperties(System.Collections.Generic.IDictionary<string, object> properties = null) { }
         [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public System.Collections.Generic.IDictionary<string, object> RawProperties { get { throw null; } set { } }
+        public System.Collections.Generic.IDictionary<string, object> RawProperties { get { throw null; } }
     }
     [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
     public partial class StorageResourceCopyFromUriOptions

sdk/storage/Azure.Storage.DataMovement/src/Shared/DataMovementExtensions.cs

@@ -22,15 +22,6 @@ internal static StorageResourceItemProperties ToStorageResourceProperties(this F
             };
         }
 
-        internal static StorageResourceContainerProperties ToStorageResourceContainerProperties(
-            this StorageResourceItemProperties properties)
-        {
-            return new StorageResourceContainerProperties()
-            {
-                RawProperties = properties.RawProperties
-            };
-        }
-
         public static StreamToUriJobPart ToStreamToUriJobPartAsync(
             this TransferJobInternal baseJob,
             JobPartPlanHeader header,

sdk/storage/Azure.Storage.DataMovement/src/StorageResourceContainerProperties.cs

@@ -17,15 +17,15 @@ public class StorageResourceContainerProperties
         /// Dictionary of the properties associated with this resource container.
         /// </summary>
         [EditorBrowsable(EditorBrowsableState.Never)]
-        public IDictionary<string, object> RawProperties { get; set; }
+        public IDictionary<string, object> RawProperties { get; }
 
         /// <summary>
-        /// Base constructor for mocking.
+        /// Base constructor.
         /// </summary>
         [EditorBrowsable(EditorBrowsableState.Never)]
-        public StorageResourceContainerProperties()
+        public StorageResourceContainerProperties(IDictionary<string, object> properties = default)
         {
-            RawProperties = new Dictionary<string, object>();
+            RawProperties = properties ?? new Dictionary<string, object>();
         }
     }
 }