Changed default cloudmachine.json location (Azure#38096)

* small fixes to CloudMachine

* updated api files

* PR feedback

* fix

Author: KrzysztofCwalina

sdk/core/Azure.Core.Experimental/api/Azure.Core.Experimental.net461.cs

@@ -3,7 +3,7 @@ namespace Azure
     public partial class CloudMachine
     {
         public CloudMachine(System.IO.Stream configurationContent) { }
-        public CloudMachine(string configurationFile = "cloudmachine.json") { }
+        public CloudMachine(string? configurationFile = null) { }
         public string DisplayName { get { throw null; } set { } }
         public string Id { get { throw null; } }
         public string Region { get { throw null; } }

sdk/core/Azure.Core.Experimental/api/Azure.Core.Experimental.net6.0.cs

@@ -3,7 +3,7 @@ namespace Azure
     public partial class CloudMachine
     {
         public CloudMachine(System.IO.Stream configurationContent) { }
-        public CloudMachine(string configurationFile = "cloudmachine.json") { }
+        public CloudMachine(string? configurationFile = null) { }
         public string DisplayName { get { throw null; } set { } }
         public string Id { get { throw null; } }
         public string Region { get { throw null; } }

sdk/core/Azure.Core.Experimental/api/Azure.Core.Experimental.netstandard2.0.cs

@@ -3,7 +3,7 @@ namespace Azure
     public partial class CloudMachine
     {
         public CloudMachine(System.IO.Stream configurationContent) { }
-        public CloudMachine(string configurationFile = "cloudmachine.json") { }
+        public CloudMachine(string? configurationFile = null) { }
         public string DisplayName { get { throw null; } set { } }
         public string Id { get { throw null; } }
         public string Region { get { throw null; } }

sdk/core/Azure.Core.Experimental/src/CloudMachine.cs

@@ -56,10 +56,12 @@ public static CloudMachine Create(string subscriptionId, string region)
         /// <summary>
         /// Loads CloudMachine settings from configurationFile
         /// </summary>
-        /// <param name="configurationFile"></param>
+        /// <param name="configurationFile">Default value is .azure\cloudmachine.json</param>
         /// <exception cref="InvalidCloudMachineConfigurationException"></exception>
-        public CloudMachine(string configurationFile = "cloudmachine.json")
+        public CloudMachine(string? configurationFile = default)
         {
+            configurationFile ??= Path.Combine(".azure", "cloudmachine.json");
+
             try
             {
                 byte[] configurationContent = File.ReadAllBytes(configurationFile);
@@ -145,7 +147,9 @@ public void Save(Stream stream)
         [EditorBrowsable(EditorBrowsableState.Never)]
         public void Save(string filepath)
         {
-            using var stream = File.OpenWrite(filepath);
+            string? directory = Path.GetDirectoryName(filepath);
+            if (directory != null && !Directory.Exists(directory)) Directory.CreateDirectory(directory);
+            using FileStream stream = File.OpenWrite(filepath);
             Save(stream);
         }
 

sdk/core/Azure.Core.Experimental/tests/CloudMachineTests.cs

@@ -27,10 +27,11 @@ public void SerializationRoundTrip()
         [Test]
         public void DefaultCtor()
         {
+            var path = Path.Combine(".azure", "cloudmachine.json");
             try
             {
                 var cm = CloudMachine.Create(Guid.NewGuid().ToString(), "westus2");
-                cm.Save("cloudmachine.json");
+                cm.Save(path);
                 var deserialized = new CloudMachine();
                 Assert.AreEqual(cm.Id, deserialized.Id);
                 Assert.AreEqual(cm.DisplayName, deserialized.DisplayName);
@@ -39,7 +40,7 @@ public void DefaultCtor()
             }
             finally
             {
-                File.Delete("cloudmachine.json");
+                File.Delete(path);
             }
         }
     }