API feedback (Azure#50734)

Author: christothes

sdk/core/Azure.Core/tests/samples/PipelineSamples.cs

@@ -68,33 +68,6 @@ public override void OnSendingRequest(HttpMessage message)
         }
         #endregion
 
-        #region Snippet:RemoveUserAgentPolicy
-        public class RemoveUserAgentPolicy : HttpPipelineSynchronousPolicy
-        {
-            public override void OnSendingRequest(HttpMessage message)
-            {
-                message.Request.Headers.Remove(HttpHeader.Names.UserAgent);
-            }
-        }
-        #endregion
-
-        public void RemoveUserAgentUse()
-        {
-            #region Snippet:RemoveUserAgentPolicyUse
-            Uri serviceEndpoint = new Uri("https://example.contoso.com");
-#if SNIPPET
-            TokenCredential credential = new DefaultAzureCredential();
-#else
-            TokenCredential credential = Mock.Of<TokenCredential>();
-#endif
-
-            SampleClientOptions clientOptions = new SampleClientOptions();
-            clientOptions.AddPolicy(new RemoveUserAgentPolicy(), HttpPipelinePosition.PerRetry);
-
-            SampleClient client = new SampleClient(serviceEndpoint, credential, clientOptions);
-            #endregion
-        }
-
         private class RequestFailedDetailsParserSample
         {
             public SampleClientOptions options;

sdk/core/System.ClientModel/api/System.ClientModel.net8.0.cs

@@ -96,7 +96,7 @@ protected AuthenticationPolicy() { }
     public partial class AuthenticationToken
     {
         public AuthenticationToken(string tokenValue, string tokenType, System.DateTimeOffset expiresOn, System.DateTimeOffset? refreshOn = default(System.DateTimeOffset?)) { }
-        public System.DateTimeOffset ExpiresOn { get { throw null; } }
+        public System.DateTimeOffset? ExpiresOn { get { throw null; } }
         public System.DateTimeOffset? RefreshOn { get { throw null; } }
         public string TokenType { get { throw null; } }
         public string TokenValue { get { throw null; } }

sdk/core/System.ClientModel/api/System.ClientModel.netstandard2.0.cs

@@ -96,7 +96,7 @@ protected AuthenticationPolicy() { }
     public partial class AuthenticationToken
     {
         public AuthenticationToken(string tokenValue, string tokenType, System.DateTimeOffset expiresOn, System.DateTimeOffset? refreshOn = default(System.DateTimeOffset?)) { }
-        public System.DateTimeOffset ExpiresOn { get { throw null; } }
+        public System.DateTimeOffset? ExpiresOn { get { throw null; } }
         public System.DateTimeOffset? RefreshOn { get { throw null; } }
         public string TokenType { get { throw null; } }
         public string TokenValue { get { throw null; } }

sdk/core/System.ClientModel/src/Auth/AuthenticationToken.cs

@@ -41,7 +41,7 @@ public AuthenticationToken(string tokenValue, string tokenType, DateTimeOffset e
     /// <summary>
     /// Gets the time when the provided token expires.
     /// </summary>
-    public DateTimeOffset ExpiresOn { get; }
+    public DateTimeOffset? ExpiresOn { get; }
 
     /// <summary>
     /// Gets the time when the token should be refreshed.