Skip to content

Commit 4007a2e

Browse files
authored
Replace Uri with UriString in AppPlatformAppProperties (Azure#36879)
* Replace Uri with UriString in AppPlatformAppProperties * Update changelog
1 parent 2f3508b commit 4007a2e

File tree

7 files changed

+38
-20
lines changed

7 files changed

+38
-20
lines changed

sdk/appplatform/Azure.ResourceManager.AppPlatform/CHANGELOG.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,10 @@
11
# Release History
22

3-
## 1.1.0-beta.2 (Unreleased)
4-
5-
### Features Added
6-
7-
### Breaking Changes
3+
## 1.1.0-beta.2 (2023-06-07)
84

95
### Bugs Fixed
106

11-
### Other Changes
7+
- Fixed failure to parse Uri for `AppPlatformAppProperties.Uri`, it does not always represent a valid Uri.
128

139
## 1.1.0-beta.1 (2023-05-25)
1410

sdk/appplatform/Azure.ResourceManager.AppPlatform/api/Azure.ResourceManager.AppPlatform.netstandard2.0.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1115,7 +1115,10 @@ public AppPlatformAppProperties() { }
11151115
public Azure.ResourceManager.AppPlatform.Models.AppPersistentDisk PersistentDisk { get { throw null; } set { } }
11161116
public Azure.ResourceManager.AppPlatform.Models.AppPlatformAppProvisioningState? ProvisioningState { get { throw null; } }
11171117
public Azure.ResourceManager.AppPlatform.Models.AppTemporaryDisk TemporaryDisk { get { throw null; } set { } }
1118+
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
1119+
[System.ObsoleteAttribute("'Uri' is deprecated. Use 'UriString' instead.")]
11181120
public System.Uri Uri { get { throw null; } }
1121+
public string UriString { get { throw null; } }
11191122
public Azure.ResourceManager.AppPlatform.Models.AppVnetAddons VnetAddons { get { throw null; } set { } }
11201123
}
11211124
[System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
@@ -2193,7 +2196,7 @@ public static partial class ArmAppPlatformModelFactory
21932196
public static Azure.ResourceManager.AppPlatform.Models.AppPlatformApiPortalProperties AppPlatformApiPortalProperties(Azure.ResourceManager.AppPlatform.Models.AppPlatformApiPortalProvisioningState? provisioningState = default(Azure.ResourceManager.AppPlatform.Models.AppPlatformApiPortalProvisioningState?), bool? isPublic = default(bool?), System.Uri uri = null, bool? isHttpsOnly = default(bool?), System.Collections.Generic.IEnumerable<Azure.Core.ResourceIdentifier> gatewayIds = null, System.Collections.Generic.IEnumerable<System.Uri> sourceUris = null, Azure.ResourceManager.AppPlatform.Models.AppPlatformSsoProperties ssoProperties = null, Azure.ResourceManager.AppPlatform.Models.AppPlatformApiPortalResourceRequirements resourceRequests = null, System.Collections.Generic.IEnumerable<Azure.ResourceManager.AppPlatform.Models.AppPlatformApiPortalInstance> instances = null) { throw null; }
21942197
public static Azure.ResourceManager.AppPlatform.Models.AppPlatformApiPortalResourceRequirements AppPlatformApiPortalResourceRequirements(string cpu = null, string memory = null) { throw null; }
21952198
public static Azure.ResourceManager.AppPlatform.AppPlatformAppData AppPlatformAppData(Azure.Core.ResourceIdentifier id = null, string name = null, Azure.Core.ResourceType resourceType = default(Azure.Core.ResourceType), Azure.ResourceManager.Models.SystemData systemData = null, Azure.ResourceManager.AppPlatform.Models.AppPlatformAppProperties properties = null, Azure.ResourceManager.Models.ManagedServiceIdentity identity = null, Azure.Core.AzureLocation? location = default(Azure.Core.AzureLocation?)) { throw null; }
2196-
public static Azure.ResourceManager.AppPlatform.Models.AppPlatformAppProperties AppPlatformAppProperties(bool? isPublic = default(bool?), System.Uri uri = null, System.Collections.Generic.IDictionary<string, System.Collections.Generic.IDictionary<string, System.BinaryData>> addonConfigs = null, Azure.ResourceManager.AppPlatform.Models.AppPlatformAppProvisioningState? provisioningState = default(Azure.ResourceManager.AppPlatform.Models.AppPlatformAppProvisioningState?), string fqdn = null, bool? isHttpsOnly = default(bool?), Azure.ResourceManager.AppPlatform.Models.AppTemporaryDisk temporaryDisk = null, Azure.ResourceManager.AppPlatform.Models.AppPersistentDisk persistentDisk = null, System.Collections.Generic.IEnumerable<Azure.ResourceManager.AppPlatform.Models.AppCustomPersistentDisk> customPersistentDisks = null, bool? isEndToEndTlsEnabled = default(bool?), System.Collections.Generic.IEnumerable<Azure.ResourceManager.AppPlatform.Models.AppLoadedCertificate> loadedCertificates = null, Azure.ResourceManager.AppPlatform.Models.AppVnetAddons vnetAddons = null, Azure.ResourceManager.AppPlatform.Models.AppIngressSettings ingressSettings = null) { throw null; }
2199+
public static Azure.ResourceManager.AppPlatform.Models.AppPlatformAppProperties AppPlatformAppProperties(bool? isPublic = default(bool?), string uriString = null, System.Collections.Generic.IDictionary<string, System.Collections.Generic.IDictionary<string, System.BinaryData>> addonConfigs = null, Azure.ResourceManager.AppPlatform.Models.AppPlatformAppProvisioningState? provisioningState = default(Azure.ResourceManager.AppPlatform.Models.AppPlatformAppProvisioningState?), string fqdn = null, bool? isHttpsOnly = default(bool?), Azure.ResourceManager.AppPlatform.Models.AppTemporaryDisk temporaryDisk = null, Azure.ResourceManager.AppPlatform.Models.AppPersistentDisk persistentDisk = null, System.Collections.Generic.IEnumerable<Azure.ResourceManager.AppPlatform.Models.AppCustomPersistentDisk> customPersistentDisks = null, bool? isEndToEndTlsEnabled = default(bool?), System.Collections.Generic.IEnumerable<Azure.ResourceManager.AppPlatform.Models.AppLoadedCertificate> loadedCertificates = null, Azure.ResourceManager.AppPlatform.Models.AppVnetAddons vnetAddons = null, Azure.ResourceManager.AppPlatform.Models.AppIngressSettings ingressSettings = null) { throw null; }
21972200
public static Azure.ResourceManager.AppPlatform.AppPlatformBindingData AppPlatformBindingData(Azure.Core.ResourceIdentifier id = null, string name = null, Azure.Core.ResourceType resourceType = default(Azure.Core.ResourceType), Azure.ResourceManager.Models.SystemData systemData = null, Azure.ResourceManager.AppPlatform.Models.AppPlatformBindingProperties properties = null) { throw null; }
21982201
public static Azure.ResourceManager.AppPlatform.Models.AppPlatformBindingProperties AppPlatformBindingProperties(string resourceName = null, string resourceType = null, Azure.Core.ResourceIdentifier resourceId = null, string key = null, System.Collections.Generic.IDictionary<string, System.BinaryData> bindingParameters = null, string generatedProperties = null, System.DateTimeOffset? createdOn = default(System.DateTimeOffset?), System.DateTimeOffset? updatedOn = default(System.DateTimeOffset?)) { throw null; }
21992202
public static Azure.ResourceManager.AppPlatform.AppPlatformBuildData AppPlatformBuildData(Azure.Core.ResourceIdentifier id = null, string name = null, Azure.Core.ResourceType resourceType = default(Azure.Core.ResourceType), Azure.ResourceManager.Models.SystemData systemData = null, Azure.ResourceManager.AppPlatform.Models.AppPlatformBuildProperties properties = null) { throw null; }
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
// Copyright (c) Microsoft Corporation. All rights reserved.
2+
// Licensed under the MIT License.
3+
4+
#nullable disable
5+
6+
using System;
7+
using System.ComponentModel;
8+
9+
namespace Azure.ResourceManager.AppPlatform.Models
10+
{
11+
/// <summary> App resource properties payload. </summary>
12+
public partial class AppPlatformAppProperties
13+
{
14+
/// <summary> URL of the App. </summary>
15+
[Obsolete("'Uri' is deprecated. Use 'UriString' instead.")]
16+
[EditorBrowsable(EditorBrowsableState.Never)]
17+
public Uri Uri { get; }
18+
}
19+
}

sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Generated/ArmAppPlatformModelFactory.cs

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Generated/Models/AppPlatformAppProperties.Serialization.cs

Lines changed: 2 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/appplatform/Azure.ResourceManager.AppPlatform/src/Generated/Models/AppPlatformAppProperties.cs

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/appplatform/Azure.ResourceManager.AppPlatform/src/autorest.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ skip-csproj: true
1515
modelerfour:
1616
flatten-payloads: false
1717

18+
# mgmt-debug:
19+
# show-serialized-names: true
20+
1821
format-by-name-rules:
1922
'etag': 'etag'
2023
'location': 'azure-location'
@@ -281,6 +284,7 @@ rename-mapping:
281284
NetworkProfile.appSubnetId: -|arm-id
282285
ResourceSku.locations: -|azure-location
283286
ResourceSkuRestrictionInfo.locations: -|azure-location
287+
AppResourceProperties.url: UriString|string
284288

285289
parameter-rename-mapping:
286290
ConfigServers_Validate:

0 commit comments

Comments
 (0)