Skip to content

Commit 4173e17

Browse files
authored
Fix mocks to use new 4 param overload for getting a secret (Azure#53035)
1 parent 84498dd commit 4173e17

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

sdk/extensions/Azure.Extensions.AspNetCore.Configuration.Secrets/src/Azure.Extensions.AspNetCore.Configuration.Secrets.csproj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@
1313

1414
<ItemGroup>
1515
<PackageReference Include="Azure.Core" />
16-
<PackageReference Include="Azure.Security.KeyVault.Secrets" />
16+
<!-- Use package reference after Package.Data.props has a version higher than 4.7.0 -->
17+
<!--<PackageReference Include="Azure.Security.KeyVault.Secrets" />-->
18+
<ProjectReference Include="..\..\..\keyvault\Azure.Security.KeyVault.Secrets\src\Azure.Security.KeyVault.Secrets.csproj" />
1719
<PackageReference Include="Microsoft.Extensions.Configuration" />
1820
</ItemGroup>
1921

sdk/extensions/Azure.Extensions.AspNetCore.Configuration.Secrets/tests/AzureKeyVaultConfigurationTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ private void SetPages(Mock<SecretClient> mock, Func<string, Task> getSecretCallb
3939
{
4040
foreach (var secret in page)
4141
{
42-
mock.Setup(client => client.GetSecretAsync(secret.Name, null, default))
43-
.Returns(async (string name, string label, CancellationToken token) =>
42+
mock.Setup(client => client.GetSecretAsync(secret.Name, null, null, default))
43+
.Returns(async (string name, string label, SecretContentType? contentType, CancellationToken token) =>
4444
{
4545
await getSecretCallback(name);
4646
return Response.FromValue(secret, Mock.Of<Response>());

0 commit comments

Comments
 (0)