Skip to content

Commit 453a5a3

Browse files
CopilotJoshLove-msftweshaggard
authored
Migrate Azure.Security.KeyVault.Administration to new TypeSpec generator (Azure#50564)
* Initial plan for issue * Initial plan: Migrate Azure.Security.KeyVault.Administration to new generator Co-authored-by: JoshLove-msft <[email protected]> * Update tsp-location.yaml and csproj for new generator migration Co-authored-by: JoshLove-msft <[email protected]> * Complete migration to new generator with TypeSpec code generation Co-authored-by: JoshLove-msft <[email protected]> * Replace CodeGenClient with CodeGenType in KeyVaultRestClient Co-authored-by: JoshLove-msft <[email protected]> * Document firewall configuration attempt for Export-API script Co-authored-by: JoshLove-msft <[email protected]> * Create copilot-setup-steps.yml for firewall allowlist configuration Co-authored-by: JoshLove-msft <[email protected]> * Fix compilation issues for TypeSpec migration - resolved firewall connectivity Co-authored-by: weshaggard <[email protected]> * WIP: Fix TypeSpec migration compilation issues - partial progress on constructor signatures and type mappings Co-authored-by: weshaggard <[email protected]> * Fix major TypeSpec migration issues - constructor calls, type structs, and client initialization Co-authored-by: weshaggard <[email protected]> * Add CodeGenType attribute to FullBackupDetailsInternal Co-authored-by: JoshLove-msft <[email protected]> * Define partial internal KeyVaultAccessControlRestClient and fix generator syntax issues Co-authored-by: JoshLove-msft <[email protected]> * Replace KeyVaultRoleType manual implementation with CodeGenType attribute Co-authored-by: JoshLove-msft <[email protected]> * Fix KeyVaultRoleAssignment and RoleAssignmentProperties type mapping issues Co-authored-by: JoshLove-msft <[email protected]> * Fix RestoreDetailsInternal and SelectiveKeyRestoreDetailsInternal with CodeGenType attributes Co-authored-by: JoshLove-msft <[email protected]> * Replace all CodeGenModel instances with CodeGenType attributes Co-authored-by: JoshLove-msft <[email protected]> * Delete copilot-setup-steps.yml file as requested Co-authored-by: JoshLove-msft <[email protected]> * Fix TypeSpec generator conflicts and successfully regenerate code Co-authored-by: JoshLove-msft <[email protected]> * Delete unnecessary dotnet-install.sh file Co-authored-by: JoshLove-msft <[email protected]> * Rename KeyVaultAccessControlClientOptions to KeyVaultAdministrationClientOptions using CodeGenType Co-authored-by: JoshLove-msft <[email protected]> * Pull from main and regenerate with field naming fixes Co-authored-by: JoshLove-msft <[email protected]> * Update TypeSpec commit to 00cfd98 and regenerate with latest generator Co-authored-by: JoshLove-msft <[email protected]> * Create KeyVaultAdministrationModelFactory stub to address missing generated model factory Co-authored-by: JoshLove-msft <[email protected]> * Fix KeyVaultDataAction implementation and remove unnecessary KeyVaultAccessControlRestClient file Co-authored-by: JoshLove-msft <[email protected]> * WIP * wip * wip * wip * wire * wip * wip * Regen * Fix ambiguous KeyVaultSetting method calls by removing duplicate Co-authored-by: JoshLove-msft <[email protected]> * regen * regen * regen * upgrade * add back model factory method * fix ctor call * more instances * update path * PR fb * Add STJ decorator to base Azure emitter * fix merge * format --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JoshLove-msft <[email protected]> Co-authored-by: weshaggard <[email protected]> Co-authored-by: jolov <[email protected]>
1 parent 0914917 commit 453a5a3

File tree

118 files changed

+6226
-2748
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

118 files changed

+6226
-2748
lines changed

eng/packages/http-client-csharp/emitter/test/Unit/options.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,8 @@ describe("Configuration tests", async () => {
177177

178178
strictEqual(program.diagnostics.length, 0);
179179
strictEqual(
180-
context.options["sdk-context-options"]?.versioning?.previewStringRegex?.source,
180+
context.options["sdk-context-options"]?.versioning?.previewStringRegex
181+
?.source,
181182
"-preview$"
182183
);
183184
deepStrictEqual(

sdk/keyvault/Azure.Security.KeyVault.Administration/api/Azure.Security.KeyVault.Administration.net8.0.cs

Lines changed: 75 additions & 6 deletions
Large diffs are not rendered by default.

sdk/keyvault/Azure.Security.KeyVault.Administration/api/Azure.Security.KeyVault.Administration.netstandard2.0.cs

Lines changed: 74 additions & 6 deletions
Large diffs are not rendered by default.

sdk/keyvault/Azure.Security.KeyVault.Administration/src/Azure.Security.KeyVault.Administration.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
1212
<NoWarn>$(NoWarn);3021;CA1812</NoWarn>
1313
<IncludeOperationsSharedSource>true</IncludeOperationsSharedSource>
14+
<IncludeAutorestDependency>false</IncludeAutorestDependency>
1415
</PropertyGroup>
1516

1617
<ItemGroup>

sdk/keyvault/Azure.Security.KeyVault.Administration/src/FullBackupDetailsInternal.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ namespace Azure.Security.KeyVault.Administration.Models
88
/// <summary>
99
/// The full backup details containing information about a specific full backup operation.
1010
/// </summary>
11-
[CodeGenModel("FullBackupOperation")]
11+
[CodeGenType("FullBackupOperation")]
1212
internal partial class FullBackupDetailsInternal
1313
{ }
1414
}

sdk/keyvault/Azure.Security.KeyVault.Administration/src/Generated/Internal/Argument.cs

Lines changed: 10 additions & 65 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/keyvault/Azure.Security.KeyVault.Administration/src/Generated/Internal/ChangeTrackingDictionary.cs

Lines changed: 23 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/keyvault/Azure.Security.KeyVault.Administration/src/Generated/Internal/ChangeTrackingList.cs

Lines changed: 16 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)