[Storage] Test Refactoring for OpenReadAsyncOverload_AllowModifications & OpenReadAsyncOverload_NotAllowModifications (Azure#45823)

* Refactored tests + recordings

* Minor refactor

Author: nickliu-msft

sdk/storage/Azure.Storage.Blobs/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "net",
   "TagPrefix": "net/storage/Azure.Storage.Blobs",
-  "Tag": "net/storage/Azure.Storage.Blobs_66e593a51d"
+  "Tag": "net/storage/Azure.Storage.Blobs_a4e8ca8040"
 }

sdk/storage/Azure.Storage.Common/tests/Shared/OpenReadTestBase.cs

@@ -662,25 +662,30 @@ public async Task OpenReadAsyncOverload_AllowModifications()
             // Arrange
             byte[] data0 = GetRandomBuffer(size);
             byte[] data1 = GetRandomBuffer(size);
-            byte[] expectedData = new byte[2 * size];
-            Array.Copy(data0, 0, expectedData, 0, size);
-            Array.Copy(data1, 0, expectedData, size, size);
+            byte[] expectedDataBeforeModify = new byte[size];
+            byte[] expectedDataAfterModify = new byte[size];
+            Array.Copy(data0, 0, expectedDataBeforeModify, 0, size);
+            Array.Copy(data1, 0, expectedDataAfterModify, 0, size);
 
             TResourceClient client = GetResourceClient(disposingContainer.Container);
             await StageDataAsync(client, new MemoryStream(data0));
 
             // Act
             Stream outputStream = await OpenReadAsyncOverload(client, allowModifications: true);
-            byte[] outputBytes = new byte[2 * size];
-            await outputStream.ReadAsync(outputBytes, 0, size);
+            byte[] outputBytesBeforeModify = new byte[size];
+            await outputStream.ReadAsync(outputBytesBeforeModify, 0, size);
 
             // Modify the blob.
             await ModifyDataAsync(client, new MemoryStream(data1), ModifyDataMode.Append);
 
-            await outputStream.ReadAsync(outputBytes, size, size);
+            byte[] outputBytesAfterModify = new byte[size];
+            byte[] emptyBytes = new byte[size];
+            await outputStream.ReadAsync(outputBytesAfterModify, 0, size);
 
             // Assert
-            TestHelper.AssertSequenceEqual(expectedData, outputBytes);
+            TestHelper.AssertSequenceEqual(expectedDataBeforeModify, outputBytesBeforeModify);
+            TestHelper.AssertSequenceEqual(expectedDataAfterModify, outputBytesAfterModify);
+            Assert.AreNotEqual(emptyBytes, outputBytesAfterModify);
         }
 
         [RecordedTest]
@@ -692,25 +697,30 @@ public async Task OpenReadAsyncOverload_NotAllowModifications()
             // Arrange
             byte[] data0 = GetRandomBuffer(size);
             byte[] data1 = GetRandomBuffer(size);
-            byte[] expectedData = new byte[2 * size];
-            Array.Copy(data0, 0, expectedData, 0, size);
-            Array.Copy(data1, 0, expectedData, size, size);
+            byte[] expectedDataBeforeModify = new byte[size];
+            byte[] expectedDataAfterModify = new byte[size];
+            Array.Copy(data0, 0, expectedDataBeforeModify, 0, size);
+            Array.Copy(data1, 0, expectedDataAfterModify, 0, size);
 
             TResourceClient client = GetResourceClient(disposingContainer.Container);
             await StageDataAsync(client, new MemoryStream(data0));
 
             // Act
             Stream outputStream = await OpenReadAsyncOverload(client, allowModifications: false);
-            byte[] outputBytes = new byte[2 * size];
-            await outputStream.ReadAsync(outputBytes, 0, size);
+            byte[] outputBytesBeforeModify = new byte[size];
+            await outputStream.ReadAsync(outputBytesBeforeModify, 0, size);
 
             // Modify the blob.
             await ModifyDataAsync(client, new MemoryStream(data1), ModifyDataMode.Append);
 
-            await outputStream.ReadAsync(outputBytes, size, size);
+            byte[] outputBytesAfterModify = new byte[size];
+            byte[] emptyBytes = new byte[size];
+            await outputStream.ReadAsync(outputBytesAfterModify, 0, size);
 
             // Assert
-            Assert.AreNotEqual(expectedData, outputBytes);
+            TestHelper.AssertSequenceEqual(expectedDataBeforeModify, outputBytesBeforeModify);
+            Assert.AreNotEqual(expectedDataAfterModify, outputBytesAfterModify);
+            TestHelper.AssertSequenceEqual(emptyBytes, outputBytesAfterModify);
         }
     }
 }

sdk/storage/Azure.Storage.Files.DataLake/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "net",
   "TagPrefix": "net/storage/Azure.Storage.Files.DataLake",
-  "Tag": "net/storage/Azure.Storage.Files.DataLake_275c4dcbac"
+  "Tag": "net/storage/Azure.Storage.Files.DataLake_c97d1635f5"
 }

sdk/storage/Azure.Storage.Files.Shares/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "net",
   "TagPrefix": "net/storage/Azure.Storage.Files.Shares",
-  "Tag": "net/storage/Azure.Storage.Files.Shares_e7f070af73"
+  "Tag": "net/storage/Azure.Storage.Files.Shares_772bdf674f"
 }