Skip to content

Commit 4e11733

Browse files
authored
Add Docs variables to globals.yml instead of needlessly passing them around (Azure#47188)
1 parent 161a9d1 commit 4e11733

File tree

4 files changed

+8
-16
lines changed

4 files changed

+8
-16
lines changed

eng/pipelines/docindex.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ jobs:
1616
name: $(LINUXPOOL)
1717
variables:
1818
DocRepoLocation: $(Pipeline.Workspace)/docs
19-
DocRepoOwner: Azure
20-
DocRepoName: azure-docs-sdk-dotnet
2119
steps:
2220
# Checkout the eng folder from the SDK repo
2321
- template: /eng/common/pipelines/templates/steps/sparse-checkout.yml

eng/pipelines/templates/stages/archetype-net-release.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ parameters:
44
ArtifactName: 'not-specified'
55
# Publish to https://dev.azure.com/azure-sdk/public/_packaging?_a=feed&feed=azure-sdk-for-net
66
DevOpsFeedId: '29ec6040-b234-4e31-b139-33dc4287b756/fa8c16a3-dbe0-4de2-a297-03065ec1ba3f'
7-
TargetDocRepoOwner: 'not-specified'
8-
TargetDocRepoName: 'not-specified'
97

108

119
stages:
@@ -208,8 +206,8 @@ stages:
208206
PackageInfoLocations:
209207
- $(Pipeline.Workspace)/${{parameters.ArtifactName}}/PackageInfo/${{artifact.name}}.json
210208
WorkingDirectory: $(System.DefaultWorkingDirectory)
211-
TargetDocRepoOwner: ${{parameters.TargetDocRepoOwner}}
212-
TargetDocRepoName: ${{parameters.TargetDocRepoName}}
209+
TargetDocRepoOwner: $(DocRepoOwner)
210+
TargetDocRepoName: $(DocRepoName)
213211
Language: 'dotnet'
214212
SparseCheckoutPaths:
215213
- /api/overview/azure/
@@ -342,8 +340,8 @@ stages:
342340
- ${{if ne(artifact.skipPublishDocMs, 'true')}}:
343341
- $(Pipeline.Workspace)/${{parameters.ArtifactName}}/PackageInfo/${{artifact.name}}.json
344342
WorkingDirectory: $(System.DefaultWorkingDirectory)
345-
TargetDocRepoOwner: ${{parameters.TargetDocRepoOwner}}
346-
TargetDocRepoName: ${{parameters.TargetDocRepoName}}
343+
TargetDocRepoOwner: $(DocRepoOwner)
344+
TargetDocRepoName: $(DocRepoName)
347345
Language: 'dotnet'
348346
DailyDocsBuild: true
349347
SparseCheckoutPaths:

eng/pipelines/templates/stages/archetype-sdk-client.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,6 @@ parameters:
1414
- name: ServiceDirectory
1515
type: string
1616
default: not-specified
17-
- name: TargetDocRepoOwner
18-
type: string
19-
default: Azure
20-
- name: TargetDocRepoName
21-
type: string
22-
default: azure-docs-sdk-dotnet
2317
- name: BuildSnippets
2418
type: boolean
2519
default: true
@@ -111,6 +105,4 @@ extends:
111105
${{ if eq(parameters.ServiceDirectory, 'template') }}:
112106
TestPipeline: true
113107
ArtifactName: packages
114-
TargetDocRepoOwner: ${{ parameters.TargetDocRepoOwner }}
115-
TargetDocRepoName: ${{ parameters.TargetDocRepoName }}
116108

eng/pipelines/templates/variables/globals.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,7 @@ variables:
1818
# Define optional AdditionalTestFilters via pipeline runtime variables or matrix config variables
1919
# See https://docs.microsoft.com/dotnet/core/testing/selective-unit-tests?pivots=nunit
2020
AdditionalTestFilters: "Placeholder!=DefaultIgnoreMe"
21+
22+
# Docs publishing variables for repo/owner
23+
DocRepoOwner: 'Azure'
24+
DocRepoName: 'azure-docs-sdk-dotnet'

0 commit comments

Comments
 (0)