Update API based on review feedback (Azure#47435)

Author: dubiety

sdk/maps/Azure.Maps.TimeZones/api/Azure.Maps.TimeZones.net8.0.cs

@@ -77,9 +77,6 @@ public enum ServiceVersion
             V1_0 = 1,
         }
     }
-    public static partial class MapsTimeZoneModelFactory
-    {
-    }
     public static partial class MapsTimeZonesModelFactory
     {
         public static Azure.Maps.TimeZones.CountryRecord CountryRecord(string name = null, string code = null) { throw null; }
@@ -91,7 +88,7 @@ public static partial class MapsTimeZonesModelFactory
     public partial class ReferenceTime
     {
         internal ReferenceTime() { }
-        public System.TimeSpan DaylightSavingsTimeSpan { get { throw null; } }
+        public System.TimeSpan DaylightSavingsOffset { get { throw null; } }
         public string PosixTimeZone { get { throw null; } }
         public int? PosixTimeZoneValidYear { get { throw null; } }
         public System.TimeSpan StandardOffsetTimeSpan { get { throw null; } }
@@ -103,7 +100,7 @@ internal ReferenceTime() { }
     public partial class TimeTransition
     {
         internal TimeTransition() { }
-        public System.TimeSpan DaylightSavingsTimeSpan { get { throw null; } }
+        public System.TimeSpan DaylightSavingsOffset { get { throw null; } }
         public System.TimeSpan StandardOffsetTimeSpan { get { throw null; } }
         public string Tag { get { throw null; } }
         public System.DateTimeOffset? UtcEnd { get { throw null; } }

sdk/maps/Azure.Maps.TimeZones/api/Azure.Maps.TimeZones.netstandard2.0.cs

@@ -77,9 +77,6 @@ public enum ServiceVersion
             V1_0 = 1,
         }
     }
-    public static partial class MapsTimeZoneModelFactory
-    {
-    }
     public static partial class MapsTimeZonesModelFactory
     {
         public static Azure.Maps.TimeZones.CountryRecord CountryRecord(string name = null, string code = null) { throw null; }
@@ -91,7 +88,7 @@ public static partial class MapsTimeZonesModelFactory
     public partial class ReferenceTime
     {
         internal ReferenceTime() { }
-        public System.TimeSpan DaylightSavingsTimeSpan { get { throw null; } }
+        public System.TimeSpan DaylightSavingsOffset { get { throw null; } }
         public string PosixTimeZone { get { throw null; } }
         public int? PosixTimeZoneValidYear { get { throw null; } }
         public System.TimeSpan StandardOffsetTimeSpan { get { throw null; } }
@@ -103,7 +100,7 @@ internal ReferenceTime() { }
     public partial class TimeTransition
     {
         internal TimeTransition() { }
-        public System.TimeSpan DaylightSavingsTimeSpan { get { throw null; } }
+        public System.TimeSpan DaylightSavingsOffset { get { throw null; } }
         public System.TimeSpan StandardOffsetTimeSpan { get { throw null; } }
         public string Tag { get { throw null; } }
         public System.DateTimeOffset? UtcEnd { get { throw null; } }

sdk/maps/Azure.Maps.TimeZones/src/MapsTimeZoneModelFactory.cs

@@ -6,8 +6,7 @@
 namespace Azure.Maps.TimeZones
 {
     /// <summary> Model factory for models. </summary>
-    [CodeGenModel("MapsTimeZoneModelFactory")]
-    public static partial class MapsTimeZoneModelFactory
+    internal static partial class MapsTimeZoneModelFactory
     {
     }
 }

sdk/maps/Azure.Maps.TimeZones/src/Models/ReferenceTime.cs

@@ -32,7 +32,7 @@ internal ReferenceTime(string tag, string standardOffset, string daylightSavings
             _daylightSavings = daylightSavings;
             if (TimeSpan.TryParse(daylightSavings, out TimeSpan DaylightSavingsValue))
             {
-                DaylightSavingsTimeSpan = DaylightSavingsValue;
+                DaylightSavingsOffset = DaylightSavingsValue;
             }
 
             _wallTime = wallTime;
@@ -55,7 +55,7 @@ internal ReferenceTime(string tag, string standardOffset, string daylightSavings
         [CodeGenMember("DaylightSavings")]
         internal string _daylightSavings { get; }
         /// <summary> Time saving in <see cref="TimeSpan"/> format in effect at the <c>ReferenceUTCTimestamp</c>. </summary>
-        public TimeSpan DaylightSavingsTimeSpan { get; }
+        public TimeSpan DaylightSavingsOffset { get; }
 
         /// <summary> Current wall time at the given time zone as shown in the <c>Tag</c> property. </summary>
         [CodeGenMember("WallTime")]

sdk/maps/Azure.Maps.TimeZones/src/Models/TimeTransition.cs

@@ -30,7 +30,7 @@ internal TimeTransition(string tag, string standardOffset, string daylightSaving
             _daylightSavings = daylightSavings;
             if (TimeSpan.TryParse(daylightSavings, out TimeSpan DaylightSavingsValue))
             {
-                DaylightSavingsTimeSpan = DaylightSavingsValue;
+                DaylightSavingsOffset = DaylightSavingsValue;
             }
 
             UtcStart = utcStart;
@@ -45,6 +45,6 @@ internal TimeTransition(string tag, string standardOffset, string daylightSaving
         [CodeGenMember("DaylightSavings")]
         internal string _daylightSavings { get; }
         /// <summary> Time saving in <see cref="TimeSpan"/> format in effect at the <c>ReferenceUTCTimestamp</c>. </summary>
-        public TimeSpan DaylightSavingsTimeSpan { get; }
+        public TimeSpan DaylightSavingsOffset { get; }
     }
 }