Skip to content

Commit 5935272

Browse files
authored
Update mocking in azure core for secrets (Azure#53037)
* Update mocking in azure core for secrets * update snippets
1 parent 9accecd commit 5935272

File tree

4 files changed

+6
-3
lines changed

4 files changed

+6
-3
lines changed

sdk/core/Azure.Core/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ var mockValue = SecretModelFactory.KeyVaultSecret(
224224
var mock = new Mock<SecretClient>();
225225

226226
// Setup client method
227-
mock.Setup(c => c.GetSecret("Name", null, default))
227+
mock.Setup(c => c.GetSecret("Name", null, null, default))
228228
.Returns(Response.FromValue(mockValue, mockResponse.Object));
229229

230230
// Use the client mock

sdk/core/Azure.Core/tests/Azure.Core.Tests.csproj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@
88

99
<ItemGroup>
1010
<PackageReference Include="Azure.Identity" />
11-
<PackageReference Include="Azure.Security.KeyVault.Secrets" />
11+
<!-- Change this back to a package reference once Package.Data.props for Secrets bumps above 4.7.0-->
12+
<!--<PackageReference Include="Azure.Security.KeyVault.Secrets" />-->
13+
<ProjectReference Include="..\..\..\keyvault\Azure.Security.KeyVault.Secrets\src\Azure.Security.KeyVault.Secrets.csproj" />
1214
<PackageReference Include="Microsoft.AspNetCore.Server.Kestrel" />
1315
<PackageReference Include="Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets" />
1416
<PackageReference Include="Moq" />

sdk/core/Azure.Core/tests/samples/MockingSamples.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public void ClientMock()
2727
var mock = new Mock<SecretClient>();
2828

2929
// Setup client method
30-
mock.Setup(c => c.GetSecret("Name", null, default))
30+
mock.Setup(c => c.GetSecret("Name", null, null, default))
3131
.Returns(Response.FromValue(mockValue, mockResponse.Object));
3232

3333
// Use the client mock

sdk/core/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ extends:
5151
- /eng/Directory.Build.Common.props
5252
- /eng/Directory.Build.Common.targets
5353
- /eng/service.proj
54+
- /sdk/keyvault/Azure.Security.KeyVault.Secrets/
5455

5556
- name: Azure.Core.Experimental
5657
safeName: AzureCoreExperimental

0 commit comments

Comments
 (0)