fix out of index (Azure#53088)

live1206 · web-flow · commit 6b9ad7c090c5 · 2025-10-09T11:16:28.000+08:00
diff --git a/eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Visitors/FlattenPropertyVisitor.cs b/eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Visitors/FlattenPropertyVisitor.cs
@@ -181,6 +181,12 @@ private ValueExpression[] BuildConstructorParameters(CSharpType propertyType, Li
                 {
                     // If the additionalProperties parameter exists, we need to pass a new instance for it.
                     parameters.Add(New.Instance(new CSharpType(typeof(Dictionary<string, BinaryData>))));
+
+                    // If the additionalProperties parameter is the last parameter, we can break the loop.
+                    if (additionalPropertyIndex == fullConstructorParameters.Count - 1)
+                    {
+                        break;
+                    }
                     fullConstructorParameterIndex++;
                 }
                 var (isOverriddenValueType, flattenedProperty) = flattenedProperties[i];

Original file line number	Diff line number	Diff line change
`@@ -181,6 +181,12 @@ private ValueExpression[] BuildConstructorParameters(CSharpType propertyType, Li`
`181`	`181`	`{`
`182`	`182`	`// If the additionalProperties parameter exists, we need to pass a new instance for it.`
`183`	`183`	`parameters.Add(New.Instance(new CSharpType(typeof(Dictionary<string, BinaryData>))));`
	`184`	`+`
	`185`	`+ // If the additionalProperties parameter is the last parameter, we can break the loop.`
	`186`	`+ if (additionalPropertyIndex == fullConstructorParameters.Count - 1)`
	`187`	`+ {`
	`188`	`+ break;`
	`189`	`+ }`
`184`	`190`	`fullConstructorParameterIndex++;`
`185`	`191`	`}`
`186`	`192`	`var (isOverriddenValueType, flattenedProperty) = flattenedProperties[i];`