Skip to content

Commit 791d447

Browse files
authored
Fix SignalR trigger completion message serialization for dotnet-isolated worker (Azure#48744)
1 parent 3fc1bab commit 791d447

File tree

3 files changed

+5
-18
lines changed

3 files changed

+5
-18
lines changed

sdk/signalr/Microsoft.Azure.WebJobs.Extensions.SignalRService/CHANGELOG.md

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,11 @@
11
# Release History
22

3-
## 2.1.0-beta.1 (Unreleased)
4-
5-
### Features Added
6-
7-
### Breaking Changes
3+
## 2.0.1 (2025-03-12)
84

95
### Bugs Fixed
6+
* Fix SignalR trigger completion message serialization for dotnet-isolated worker.
107

11-
### Other Changes
12-
13-
## 2.0.0 (2025-03-11)
8+
## 2.0.0 (2025-03-04)
149

1510
### Breaking Changes
1611
* Modify `AddDefaultAuth` method in `SignalRFunctionsHostBuilderExtensions.cs` to use `IServiceCollection` instead of `IFunctionsHostBuilder` to remove the dependency for legacy package `Microsoft.Azure.Functions.Extensions`.

sdk/signalr/Microsoft.Azure.WebJobs.Extensions.SignalRService/src/Microsoft.Azure.WebJobs.Extensions.SignalRService.csproj

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<PropertyGroup>
44
<TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
55
<PackageId>Microsoft.Azure.WebJobs.Extensions.SignalRService</PackageId>
6-
<Version>2.1.0-beta.1</Version>
6+
<Version>2.0.1</Version>
77
<ApiCompatVersion>2.0.0</ApiCompatVersion>
88
<!--The ApiCompatVersion is managed automatically and should not generally be modified manually.-->
99
<SignAssembly>true</SignAssembly>
@@ -18,8 +18,7 @@
1818
<PackageReference Include="Microsoft.Azure.SignalR" />
1919
<PackageReference Include="Microsoft.Azure.SignalR.Protocols" />
2020
<PackageReference Include="Microsoft.Azure.SignalR.Serverless.Protocols" />
21-
<!--According to https://github.com/Azure/azure-sdk-for-net/pull/48280#discussion_r1972339492, 1.8.0 is the latest safe version.-->
22-
<PackageReference Include="Microsoft.Extensions.Azure" VersionOverride="1.8.0" />
21+
<PackageReference Include="Microsoft.Extensions.Azure" />
2322
<PackageReference Include="System.IdentityModel.Tokens.Jwt" />
2423
</ItemGroup>
2524

sdk/signalr/Microsoft.Azure.WebJobs.Extensions.SignalRService/src/TriggerBindings/Utils/JTokenWrapper.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,8 @@ public override JTokenWrapper Read(ref Utf8JsonReader reader, Type typeToConvert
3535

3636
public override void Write(Utf8JsonWriter writer, JTokenWrapper value, JsonSerializerOptions options)
3737
{
38-
#if NET6_0_OR_GREATER
3938
var jsonString = JsonConvert.SerializeObject(value.Value);
4039
writer.WriteRawValue(jsonString);
41-
#elif NETSTANDARD2_0
42-
// No need to implement.
43-
// First of all, the SignalR extensions for host process always run on .NET 6 or greater runtime when this class is first written.
44-
// Even if somehow the extensions run on .NET Framework, the JsonHubProtocol would use Newtonsoft.Json for serialization and this class would not be used.
45-
throw new NotImplementedException("Serializing Newtonsoft.Json.JsonToken with System.Text.Json is not implemented. ");
46-
#endif
4740
}
4841
}
4942

0 commit comments

Comments
 (0)