Refactor dotnet steps to add DevOps logging (Azure#52879)

Author: weshaggard

eng/pipelines/templates/jobs/ci.tests.yml

@@ -157,11 +157,12 @@ jobs:
         parameters:
           LogFilePath: $(Build.ArtifactStagingDirectory)/test.binlog
 
-      - script: >-
+      - pwsh: >
+          ./eng/scripts/runwithdevopslogging.ps1
           dotnet test eng/service.proj
-          --filter "(TestCategory!=Manually) & (TestCategory!=Live) & ($(AdditionalTestFilters))"
+          --filter '"(TestCategory!=Manually) & (TestCategory!=Live) & ($(AdditionalTestFilters))"'
           --framework $(TestTargetFramework)
-          --logger "trx;LogFileName=$(TestTargetFramework).trx" --logger:"console;verbosity=normal"
+          --logger '"trx;LogFileName=$(TestTargetFramework).trx"' --logger:'"console;verbosity=normal"'
           --blame-crash-dump-type full --blame-hang-dump-type full --blame-hang-timeout ${{parameters.TestTimeoutInMinutes}}minutes
           /p:SDKType=${{ parameters.SDKType }}
           /p:ServiceDirectory=$(ServiceDirectory)

eng/pipelines/templates/jobs/live.tests.yml

@@ -161,7 +161,7 @@ jobs:
             azurePowerShellVersion: LatestVersion
             pwsh: true
             ScriptType: InlineScript
-            Inline: >-
+            Inline: >
               . ./eng/common/TestResources/SubConfig-Helpers.ps1
               $serviceDirectoryPrefix = BuildServiceDirectoryPrefix ${{ parameters.ServiceDirectory }};
               $account = (Get-AzContext).Account;
@@ -170,11 +170,12 @@ jobs:
               [Environment]::SetEnvironmentVariable("${serviceDirectoryPrefix}CLIENT_ID", $account.Id);
               [Environment]::SetEnvironmentVariable("${serviceDirectoryPrefix}TENANT_ID", $account.Tenants);
 
+              ./eng/scripts/runwithdevopslogging.ps1
               dotnet test eng/service.proj
               --framework $(TestTargetFramework)
-              --filter "TestCategory!=Manually & ($(AdditionalTestFilters))"
-              --logger "trx"
-              --logger:"console;verbosity=normal"
+              --filter '"TestCategory!=Manually & ($(AdditionalTestFilters))"'
+              --logger trx
+              --logger:'"console;verbosity=normal"'
               --blame-crash-dump-type full --blame-hang-dump-type full --blame-hang-timeout ${{parameters.TimeoutInMinutes}}minutes
               /p:SDKType=${{ parameters.SDKType }}
               /p:ServiceDirectory=${{ parameters.ServiceDirectory }}
@@ -187,6 +188,7 @@ jobs:
               /p:CollectCoverage=$(CollectCoverage) /p:CodeCoverageDirectory=$(Build.SourcesDirectory)\sdk\${{parameters.ServiceDirectory}}
               /p:EnableSourceLink=false
               $(AdditionalTestArguments);
+
               Write-Host "Last exit code: $LASTEXITCODE";
               exit $LASTEXITCODE;
           env:
@@ -198,12 +200,13 @@ jobs:
               ${{ var.key }}: ${{ var.value }}
 
       - ${{ else }}:
-        - script: >-
+        - pwsh: >
+            ./eng/scripts/runwithdevopslogging.ps1
             dotnet test eng/service.proj
             --framework $(TestTargetFramework)
-            --filter "TestCategory!=Manually & ($(AdditionalTestFilters))"
-            --logger "trx"
-            --logger:"console;verbosity=normal"
+            --filter '"TestCategory!=Manually & ($(AdditionalTestFilters))"'
+            --logger trx
+            --logger:'"console;verbosity=normal"'
             --blame-crash-dump-type full --blame-hang-dump-type full --blame-hang-timeout ${{parameters.TimeoutInMinutes}}minutes
             /p:SDKType=${{ parameters.SDKType }}
             /p:ServiceDirectory=${{ parameters.ServiceDirectory }}

eng/pipelines/templates/steps/build.yml

@@ -94,25 +94,27 @@ steps:
   # surprised by new errors that pop up only in internal when public CI was clean.
   - ${{ if eq(parameters.ServiceDirectory, 'auto') }}:
     # only use the project list override file if the service directory is not auto
-    - pwsh: |
-        dotnet pack eng/service.proj -warnaserror `
-          /p:ValidateRunApiCompat=true `
-          /p:SDKType=${{ parameters.SDKType }} `
-          /p:IncludeTests=false `
-          /p:PublicSign=false $(VersioningProperties) `
-          /p:Configuration=Release `
-          /p:CommitSHA=$(Build.SourceVersion) `
-          /p:ArtifactsPackagesDir=$(Build.ArtifactStagingDirectory) `
-          /p:ServiceDirectory=* `
-          /p:ProjectListOverrideFile=$(ProjectListOverrideFile) `
-          /p:IncludePerf=false `
-          /p:IncludeStress=false `
-          /p:IncludeIntegrationTests=false `
-          /p:EnableOverrideExclusions=true `
-          $(DiagnosticArguments)
+    - pwsh: >
+        ./eng/scripts/runwithdevopslogging.ps1
+        dotnet pack eng/service.proj -warnaserror
+        /p:ValidateRunApiCompat=true
+        /p:SDKType=${{ parameters.SDKType }}
+        /p:IncludeTests=false
+        /p:PublicSign=false $(VersioningProperties)
+        /p:Configuration=Release
+        /p:CommitSHA=$(Build.SourceVersion)
+        /p:ArtifactsPackagesDir=$(Build.ArtifactStagingDirectory)
+        /p:ServiceDirectory=*
+        /p:ProjectListOverrideFile=$(ProjectListOverrideFile)
+        /p:IncludePerf=false
+        /p:IncludeStress=false
+        /p:IncludeIntegrationTests=false
+        /p:EnableOverrideExclusions=true
+        $(DiagnosticArguments)
       displayName: "Build and Package for PR"
   - ${{ else }}:
-    - script: >-
+    - pwsh: >
+        ./eng/scripts/runwithdevopslogging.ps1
         dotnet pack eng/service.proj -warnaserror
         /p:ValidateRunApiCompat=true
         /p:SDKType=${{ parameters.SDKType }}

eng/scripts/runwithdevopslogging.ps1

@@ -0,0 +1,3 @@
+. $PSScriptRoot/../common/scripts/Helpers/CommandInvocation-Helpers.ps1
+
+Invoke-LoggedMsbuildCommand "$args"