Skip to content

Commit 8981012

Browse files
authored
fix(playwrighttesting): logger name and flaky tests (Azure#46746)
* fix(): logger name and flaky tests * fix(): run name fetching logic name from git --------- Co-authored-by: Siddharth Singha Roy <[email protected]>
1 parent fe44601 commit 8981012

File tree

4 files changed

+2
-6
lines changed

4 files changed

+2
-6
lines changed

sdk/playwrighttesting/Azure.Developer.MicrosoftPlaywrightTesting.NUnit/samples/Sample1_CustomisingServiceParameters.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,15 @@ This guide explains the different options available to you in the Azure.Develope
1515
<!-- The below parameters are optional -->
1616
<Parameter name="Os" value="linux" />
1717
<Parameter name="RunId" value="sample-run-id" />
18-
<Parameter name="ExposeNetwork" value="<loopback>" />
1918
<Parameter name="ServiceAuthType" value="EntraId" />
2019
<Parameter name="UseCloudHostedBrowsers" value="true" />
2120
<Parameter name="AzureTokenCredentialType" value="DefaultAzureCredential" />
22-
<Parameter name="ManagedIdentityClientId" value="77bfc267-86cb-4eeb-9e4a-747a217a318c" />
2321
<Parameter name="EnableGitHubSummary" value="false" />
2422
</TestRunParameters>
2523
<!-- Enable Reporting feature -->
2624
<LoggerRunSettings>
2725
<Loggers>
28-
<Logger friendlyName="ms-playwright-service" enabled="true" />
26+
<Logger friendlyName="microsoft-playwright-testing" enabled="true" />
2927
</Loggers>
3028
</LoggerRunSettings>
3129
</RunSettings>

sdk/playwrighttesting/Azure.Developer.MicrosoftPlaywrightTesting.TestLogger/src/Utility/ReporterUtils.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ internal static string GetRunName(CIInfo ciInfo)
4444
{
4545
string GIT_VERSION_COMMAND = "git --version";
4646
string GIT_REV_PARSE = "git rev-parse --is-inside-work-tree";
47-
string GIT_COMMIT_MESSAGE_COMMAND = "git log -1 --pretty=%B";
47+
string GIT_COMMIT_MESSAGE_COMMAND = "git log -1 --pretty=format:\"%s\"";
4848

4949
if (ciInfo.Provider == CIConstants.s_gITHUB_ACTIONS &&
5050
Environment.GetEnvironmentVariable("GITHUB_EVENT_NAME") == "pull_request")

sdk/playwrighttesting/Azure.Developer.MicrosoftPlaywrightTesting.TestLogger/tests/Utility/CiInfoProviderTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
namespace Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.Tests.Utility
1212
{
1313
[TestFixture]
14-
[Parallelizable(ParallelScope.Self)]
1514
public class CiInfoProviderTests
1615
{
1716
private Dictionary<string, string> _originalEnvironmentVariables = new();

sdk/playwrighttesting/Azure.Developer.MicrosoftPlaywrightTesting.TestLogger/tests/Utility/ReporterUtilsTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
namespace Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.Tests.Utility;
1212

1313
[TestFixture]
14-
[Parallelizable(ParallelScope.Self)]
1514
public class ReporterUtilsTests
1615
{
1716
private static string GetToken(Dictionary<string, object> claims, DateTime? expires = null)

0 commit comments

Comments
 (0)