Update Remove to TryRemove for ConcurrentDictionary in Transfermanager (Azure#47038)

amnguye · web-flow · commit 8a63175dbbeb · 2024-11-08T20:39:27.000Z
diff --git a/sdk/storage/Azure.Storage.DataMovement/src/TransferManager.cs b/sdk/storage/Azure.Storage.DataMovement/src/TransferManager.cs
@@ -392,7 +392,9 @@ await _checkpointer.AddNewJobAsync(
                 // cleanup any state for a job that didn't even start
                 try
                 {
-                    _dataTransfers.Remove(transferId);
+                    // No need to check if we were able to remove the transfer or not.
+                    // If there's no stale DataTransfer to remove, move on, because this is a cleanup
+                    _dataTransfers.TryRemove(transferId, out DataTransfer transfer);
                     await _checkpointer.TryRemoveStoredTransferAsync(transferId, cancellationToken).ConfigureAwait(false);
                 }
                 catch (Exception cleanupEx)

Original file line number	Diff line number	Diff line change
`@@ -392,7 +392,9 @@ await _checkpointer.AddNewJobAsync(`
`392`	`392`	`// cleanup any state for a job that didn't even start`
`393`	`393`	`try`
`394`	`394`	`{`
`395`		`- _dataTransfers.Remove(transferId);`
	`395`	`+ // No need to check if we were able to remove the transfer or not.`
	`396`	`+ // If there's no stale DataTransfer to remove, move on, because this is a cleanup`
	`397`	`+ _dataTransfers.TryRemove(transferId, out DataTransfer transfer);`
`396`	`398`	`await _checkpointer.TryRemoveStoredTransferAsync(transferId, cancellationToken).ConfigureAwait(false);`
`397`	`399`	`}`
`398`	`400`	`catch (Exception cleanupEx)`