removing creation time check from LRO (Azure#50769)

Author: wiboris

sdk/batch/Azure.Compute.Batch/src/Custom/LongRunningOperations/DeleteJobOperation.cs

@@ -28,10 +28,8 @@ public class DeleteJobOperation : Operation<bool>
         /// Gets the success of the operation.
         /// </summary>
         private bool? _value;
-        private DateTimeOffset _creationTime;
         private Response _rawResponse;
         private string _jobId;
-        private bool firstGet = true;
 
         /// <summary>
         /// Initializes a new <see cref="DeleteJobOperation"/> instance
@@ -172,19 +170,7 @@ private async Task<Response> UpdateStatusAsync(bool async, CancellationToken can
             {
                 _rawResponse = deleteResponse.GetRawResponse();
 
-                // we are going to save the first get responses creation time assuming
-                // this first get returns the current object
-                if (firstGet)
-                {
-                    _creationTime = (DateTimeOffset)deleteResponse.Value.CreationTime;
-                    firstGet = false;
-                } // need to handle the case where we get back the response from a new object.
-                else if (deleteResponse.Value.CreationTime != _creationTime)
-                {
-                    _value = true;
-                    _hasCompleted = true;
-                }
-                else if (deleteResponse.Value.State != BatchJobState.Deleting)
+                if (deleteResponse.Value.State != BatchJobState.Deleting)
                 {
                     _value = true;
                     _hasCompleted = true;

sdk/batch/Azure.Compute.Batch/src/Custom/LongRunningOperations/DeleteJobScheduleOperation.cs

@@ -28,10 +28,8 @@ public class DeleteJobScheduleOperation : Operation<bool>
         /// Gets the success of the operation.
         /// </summary>
         private bool? _value;
-        private DateTimeOffset _creationTime;
         private Response _rawResponse;
         private string _jobScheduleId;
-        private bool firstGet = true;
 
         /// <summary>
         /// Initializes a new <see cref="DeleteJobScheduleOperation"/> instance
@@ -173,19 +171,7 @@ private async Task<Response> UpdateStatusAsync(bool async, CancellationToken can
             {
                 _rawResponse = deleteResponse.GetRawResponse();
 
-                // we are going to save the first get responses creation time assuming
-                // this first get returns the current object
-                if (firstGet)
-                {
-                    _creationTime = (DateTimeOffset)deleteResponse.Value.CreationTime;
-                    firstGet = false;
-                } // need to handle the case where we get back the response from a new object.
-                else if (deleteResponse.Value.CreationTime != _creationTime)
-                {
-                    _value = true;
-                    _hasCompleted = true;
-                }
-                else if (deleteResponse.Value.State != BatchJobScheduleState.Deleting)
+                if (deleteResponse.Value.State != BatchJobScheduleState.Deleting)
                 {
                     _value = true;
                     _hasCompleted = true;

sdk/batch/Azure.Compute.Batch/src/Custom/LongRunningOperations/DeletePoolOperation.cs

@@ -28,10 +28,8 @@ public class DeletePoolOperation : Operation<bool>
         /// Gets the success of the operation.
         /// </summary>
         private bool? _value;
-        private DateTimeOffset _creationTime;
         private Response _rawResponse;
         private string _poolId;
-        private bool firstGet = true;
 
         /// <summary>
         /// Initializes a new <see cref="DeletePoolOperation"/> instance
@@ -173,19 +171,7 @@ private async Task<Response> UpdateStatusAsync(bool async, CancellationToken can
             {
                 _rawResponse = deleteResponse.GetRawResponse();
 
-                // we are going to save the first get responses creation time assuming
-                // this first get returns the current object
-                if (firstGet)
-                {
-                    _creationTime = (DateTimeOffset)deleteResponse.Value.CreationTime;
-                    firstGet = false;
-                } // need to handle the case where we get back the response from a new object.
-                else if (deleteResponse.Value.CreationTime != _creationTime)
-                {
-                    _value = true;
-                    _hasCompleted = true;
-                }
-                else if (deleteResponse.Value.State != BatchPoolState.Deleting)
+                if (deleteResponse.Value.State != BatchPoolState.Deleting)
                 {
                     _value = true;
                     _hasCompleted = true;

sdk/batch/Azure.Compute.Batch/src/Custom/LongRunningOperations/TerminateJobOperation.cs

@@ -30,8 +30,6 @@ public class TerminateJobOperation : Operation<bool>
         private bool? _value;
         private Response _rawResponse;
         private string _jobId;
-        private DateTimeOffset _creationTime;
-        private bool firstGet = true;
 
         /// <summary>
         /// Initializes a new <see cref="TerminateJobOperation"/> instance
@@ -174,19 +172,6 @@ private async Task<Response> UpdateStatusAsync(bool async, CancellationToken can
             {
                 _rawResponse = response.GetRawResponse();
 
-                // we are going to save the first get responses creation time assuming
-                // this first get returns the current object
-                if (firstGet)
-                {
-                    _creationTime = (DateTimeOffset)response.Value.CreationTime;
-                    firstGet = false;
-                } // need to handle the case where we get back the response from a new object.
-                else if (response.Value.CreationTime != _creationTime)
-                {
-                    _value = true;
-                    _hasCompleted = true;
-                }
-
                 if ( response.Value.State != BatchJobState.Terminating)
                 {
                    _value = true;

sdk/batch/Azure.Compute.Batch/src/Custom/LongRunningOperations/TerminateJobScheduleOperation.cs

@@ -29,9 +29,7 @@ public class TerminateJobScheduleOperation : Operation<bool>
         /// </summary>
         private bool? _value;
         private Response _rawResponse;
-        private DateTimeOffset _creationTime;
         private string _jobScheduleId;
-        private bool firstGet = true;
 
         /// <summary>
         /// Initializes a new <see cref="TerminateJobScheduleOperation"/> instance
@@ -174,19 +172,6 @@ private async Task<Response> UpdateStatusAsync(bool async, CancellationToken can
             {
                 _rawResponse = response.GetRawResponse();
 
-                // we are going to save the first get responses creation time assuming
-                // this first get returns the current object
-                if (firstGet)
-                {
-                    _creationTime = (DateTimeOffset)response.Value.CreationTime;
-                    firstGet = false;
-                } // need to handle the case where we get back the response from a new object.
-                else if (response.Value.CreationTime != _creationTime)
-                {
-                    _value = true;
-                    _hasCompleted = true;
-                }
-
                 if (response.Value.State != BatchJobScheduleState.Terminating)
                 {
                     _value = true;

sdk/batch/Azure.Compute.Batch/tests/UnitTests/LongRunningOperationsUnitTests.cs

@@ -527,7 +527,7 @@ public async Task TerminateJobScheduleOperation_NewJobSchedule()
             int CallsToGet = 0;
 
             BatchJobSchedule batchJobScheduleTerminating = new BatchJobSchedule(JobId, null, null, null, null, DateTimeOffset.UtcNow, BatchJobScheduleState.Terminating, null, null, null, null, null, null, null, null, null);
-            BatchJobSchedule batchJobScheduleActive = new BatchJobSchedule(JobId, null, null, null, null, DateTimeOffset.UtcNow.AddHours(1), BatchJobScheduleState.Terminating, null, null, null, null, null, null, null, null, null);
+            BatchJobSchedule batchJobScheduleActive = new BatchJobSchedule(JobId, null, null, null, null, DateTimeOffset.UtcNow.AddHours(1), BatchJobScheduleState.Active, null, null, null, null, null, null, null, null, null);
 
             Mock<BatchClient> clientMock = new Mock<BatchClient>();
             clientMock.Setup(c => c.GetJobScheduleAsync(