fix: consume collectionresultdefinition caching fix (Azure#52004)

* fix: consume collectionresultdefinition caching fix

* bump mtg version

* fix version

Author: jorgerangel-msft

eng/Packages.Data.props

@@ -457,7 +457,7 @@
 
   <PropertyGroup>
     <TestProxyVersion>1.0.0-dev.20250805.1</TestProxyVersion>
-    <UnbrandedGeneratorVersion>1.0.0-alpha.20250813.2</UnbrandedGeneratorVersion>
+    <UnbrandedGeneratorVersion>1.0.0-alpha.20250815.3</UnbrandedGeneratorVersion>
     <AzureGeneratorVersion>1.0.0-alpha.20250812.2</AzureGeneratorVersion>
   </PropertyGroup>
 </Project>

eng/http-client-csharp-emitter-package-lock.json

@@ -2,7 +2,7 @@
   "main": "dist/src/index.js",
   "dependencies": {
     "client-plugin": "file:../../../../eng/packages/plugins/client",
-    "@typespec/http-client-csharp": "1.0.0-alpha.20250813.2"
+    "@typespec/http-client-csharp": "1.0.0-alpha.20250815.3"
   },
   "devDependencies": {
     "@azure-tools/typespec-azure-core": "0.59.0",

eng/http-client-csharp-emitter-package.json

@@ -240,7 +240,7 @@ private ScopedApi<HttpMessage> InvokeCreateRequestForNextLink(ValueExpression ne
 
         private ScopedApi<HttpMessage> InvokeCreateRequestForContinuationToken(ValueExpression continuationToken)
         {
-            var arguments = RequestFields.Select(f => f == NextTokenField ? continuationToken : f.AsValueExpression);
+            var arguments = RequestFields.Select(f => f.Name.Equals(NextTokenField?.Name) ? continuationToken : f.AsValueExpression);
 
             return ClientField.Invoke(CreateRequestMethodName, arguments).As<HttpMessage>();
         }

eng/packages/http-client-csharp/generator/Azure.Generator/src/Providers/AzureCollectionResultDefinition.cs

@@ -22,10 +22,10 @@ internal class ClientProviderTests
         private const string KeyAuthCategory = "WithKeyAuth";
         private const string OAuth2Category = "WithOAuth2";
         private const string TestClientName = "TestClient";
-        private static readonly InputClient _testClient = new(TestClientName, "Samples", "", "TestClient description", null, [], [], _testClient, []);
-        private static readonly InputClient _animalClient = new("animal", "Samples", "", "AnimalClient description", null, [], [], _testClient, []);
-        private static readonly InputClient _dogClient = new("dog", "Samples", "", "DogClient description", null, [], [], _animalClient, []);
-        private static readonly InputClient _huskyClient = new("husky", "Samples", "", "HuskyClient description", null, [], [], _dogClient, []);
+        private static readonly InputClient _testClient = new(TestClientName, "Samples", "", "TestClient description", null, [], [], _testClient, [], []);
+        private static readonly InputClient _animalClient = new("animal", "Samples", "", "AnimalClient description", null, [], [], _testClient, [], []);
+        private static readonly InputClient _dogClient = new("dog", "Samples", "", "DogClient description", null, [], [], _animalClient, [], []);
+        private static readonly InputClient _huskyClient = new("husky", "Samples", "", "HuskyClient description", null, [], [], _dogClient, [], []);
 
         private bool _containsSubClients;
         private bool _hasKeyAuth;

eng/packages/http-client-csharp/generator/Azure.Generator/test/Providers/ClientProviders/ClientProviderTests.cs

@@ -667,7 +667,8 @@ public static InputClient Client(string name, string clientNamespace = "Samples"
                 methods is null ? [] : [.. methods],
                 parameters is null ? [] : [.. parameters],
                 parent,
-                clientChildren
+                clientChildren,
+                []
                 );
             _childClientsCache[client] = clientChildren;
             // when we have a parent, we need to find the children list of this parent client and update accordingly.

eng/packages/http-client-csharp/generator/Azure.Generator/test/common/InputFactory.cs

@@ -38,7 +38,7 @@
     "dist/generator/**"
   ],
   "dependencies": {
-    "@typespec/http-client-csharp": "1.0.0-alpha.20250813.2"
+    "@typespec/http-client-csharp": "1.0.0-alpha.20250815.3"
   },
   "devDependencies": {
     "@azure-tools/azure-http-specs": "0.1.0-alpha.25",