Build snippets during Analyze job by default (Azure#33878)

heaths · web-flow · commit bf02a2a5b20e · 2023-02-06T15:26:06.000-08:00
* Build snippets during Analyze job by default Resolves Azure#33877 * Resolve PR feedback * Don't build snippets for Core Core has a few issues actually compiling with SNIPPET symbol because it tries to elide some code for brevity. Fixing that changes the extracted snippets and may make the samples more confusing so leaving as-is.
diff --git a/eng/pipelines/templates/jobs/ci.yml b/eng/pipelines/templates/jobs/ci.yml
@@ -16,7 +16,7 @@ parameters:
   default: not-specified
 - name: BuildSnippets
   type: boolean
-  default: false
+  default: true
 - name: TestSetupSteps
   type: stepList
   default: []
diff --git a/eng/pipelines/templates/stages/archetype-sdk-client.yml b/eng/pipelines/templates/stages/archetype-sdk-client.yml
@@ -29,7 +29,7 @@ parameters:
   default: azure-docs-sdk-dotnet
 - name: BuildSnippets
   type: boolean
-  default: false
+  default: true
 - name: TestSetupSteps
   type: stepList
   default: []
diff --git a/sdk/authorization/ci.mgmt.yml b/sdk/authorization/ci.mgmt.yml
@@ -17,7 +17,6 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
     ServiceDirectory: authorization
-    BuildSnippets: true
     LimitForPullRequest: true
     Artifacts:
     - name: Azure.ResourceManager.Authorization
diff --git a/sdk/billingbenefits/ci.mgmt.yml b/sdk/billingbenefits/ci.mgmt.yml
@@ -18,7 +18,6 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
     ServiceDirectory: billingbenefits
-    BuildSnippets: true
     LimitForPullRequest: true
     Artifacts:
     - name: Azure.ResourceManager.BillingBenefits
diff --git a/sdk/communication/ci.mgmt.yml b/sdk/communication/ci.mgmt.yml
@@ -16,7 +16,6 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
     ServiceDirectory: communication
-    BuildSnippets: true
     LimitForPullRequest: true
     Artifacts:
     - name: Azure.ResourceManager.Communication
diff --git a/sdk/communication/ci.yml b/sdk/communication/ci.yml
@@ -28,7 +28,7 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
     ServiceDirectory: communication
-    BuildSnippets: true
+    BuildSnippets: false
     ArtifactName: packages
     Artifacts:
     - name: Azure.Communication.JobRouter
diff --git a/sdk/containerregistry/ci.mgmt.yml b/sdk/containerregistry/ci.mgmt.yml
@@ -18,7 +18,6 @@ extends:
   parameters:
     SDKType: mgmtclient
     ServiceDirectory: containerregistry
-    BuildSnippets: true
     LimitForPullRequest: true
     Artifacts:
     - name: Azure.ResourceManager.ContainerRegistry
diff --git a/sdk/containerregistry/ci.yml b/sdk/containerregistry/ci.yml
@@ -30,7 +30,6 @@ extends:
   parameters:
     SDKType: client
     ServiceDirectory: containerregistry
-    BuildSnippets: true
     ArtifactName: packages
     Artifacts:
     - name: Azure.Containers.ContainerRegistry
diff --git a/sdk/core/ci.yml b/sdk/core/ci.yml
@@ -35,6 +35,7 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
     ServiceDirectory: core
+    BuildSnippets: false
     ArtifactName: packages
     Artifacts:
     - name: Azure.Core
@@ -57,4 +58,4 @@ extends:
     TestSetupSteps:
     - template: /sdk/storage/tests-install-azurite.yml
     TestTimeoutInMinutes: 100
-    TestDependsOnDependency: Azure.Core
+    TestDependsOnDependency: Azure.Core
diff --git a/sdk/dns/ci.mgmt.yml b/sdk/dns/ci.mgmt.yml
@@ -18,6 +18,7 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
     ServiceDirectory: dns
+    BuildSnippets: false
     LimitForPullRequest: true
     Artifacts:
     - name: Azure.ResourceManager.Dns
diff --git a/sdk/eventhub/ci.yml b/sdk/eventhub/ci.yml
@@ -38,7 +38,6 @@ extends:
   parameters:
     SDKType: client
     ServiceDirectory: eventhub
-    BuildSnippets: true
     ArtifactName: packages
     Artifacts:
     - name: Azure.Messaging.EventHubs
diff --git a/sdk/formrecognizer/ci.yml b/sdk/formrecognizer/ci.yml
@@ -25,7 +25,7 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
     ServiceDirectory: formrecognizer
-    BuildSnippets: true
+    BuildSnippets: false
     ArtifactName: packages
     Artifacts:
     - name: Azure.AI.FormRecognizer
diff --git a/sdk/iot/ci.yml b/sdk/iot/ci.yml
@@ -20,8 +20,9 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
     ServiceDirectory: iot
+    BuildSnippets: false
     ArtifactName: packages
     Artifacts:
     - name: Azure.IoT.Hub.Service
       safeName: AzureIoTHubService
-      
+
diff --git a/sdk/keyvault/ci.mgmt.yml b/sdk/keyvault/ci.mgmt.yml
@@ -17,7 +17,6 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
     ServiceDirectory: keyvault
-    BuildSnippets: true
     LimitForPullRequest: true
     Artifacts:
     - name: Azure.ResourceManager.KeyVault
diff --git a/sdk/keyvault/ci.yml b/sdk/keyvault/ci.yml
@@ -29,7 +29,6 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
     ServiceDirectory: keyvault
-    BuildSnippets: true
     ArtifactName: packages
     Artifacts:
     - name: Azure.Security.KeyVault.Administration
diff --git a/sdk/metricsadvisor/ci.yml b/sdk/metricsadvisor/ci.yml
@@ -25,7 +25,6 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
     ServiceDirectory: metricsadvisor
-    BuildSnippets: true
     ArtifactName: packages
     Artifacts:
     - name: Azure.AI.MetricsAdvisor
diff --git a/sdk/purview/ci.mgmt.yml b/sdk/purview/ci.mgmt.yml
@@ -16,7 +16,6 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
     ServiceDirectory: purview
-    BuildSnippets: true
     LimitForPullRequest: true
     Artifacts:
     - name: Azure.ResourceManager.Purview
diff --git a/sdk/purview/ci.yml b/sdk/purview/ci.yml
@@ -28,7 +28,6 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
     ServiceDirectory: purview
-    BuildSnippets: true
     ArtifactName: packages
     Artifacts:
     - name: Azure.Analytics.Purview.Share
diff --git a/sdk/reservations/ci.mgmt.yml b/sdk/reservations/ci.mgmt.yml
@@ -17,7 +17,6 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
     ServiceDirectory: reservations
-    BuildSnippets: true
     LimitForPullRequest: true
     Artifacts:
     - name: Azure.ResourceManager.Reservations
diff --git a/sdk/search/ci.yml b/sdk/search/ci.yml
@@ -30,7 +30,6 @@ extends:
   parameters:
     SDKType: client
     ServiceDirectory: search
-    BuildSnippets: true
     ArtifactName: packages
     Artifacts:
     - name: Azure.Search.Documents
diff --git a/sdk/servicebus/ci.yml b/sdk/servicebus/ci.yml
@@ -32,7 +32,7 @@ extends:
   parameters:
     SDKType: client
     ServiceDirectory: servicebus
-    BuildSnippets: true
+    BuildSnippets: false
     ArtifactName: packages
     Artifacts:
     - name: Azure.Messaging.ServiceBus
diff --git a/sdk/textanalytics/ci.yml b/sdk/textanalytics/ci.yml
@@ -25,7 +25,6 @@ extends:
   template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
   parameters:
     ServiceDirectory: textanalytics
-    BuildSnippets: true
     ArtifactName: packages
     Artifacts:
     - name: Azure.AI.TextAnalytics
