[AzureMonitorExporter] fix more nullables (Azure#35047)

* fix nullables

* cleanup

Author: Timothy Mothra

sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Customizations/Models/RemoteDependencyData.cs

@@ -1,27 +1,23 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-#nullable disable // TODO: remove and fix errors
-
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Globalization;
 
 using Azure.Core;
 using Azure.Monitor.OpenTelemetry.Exporter.Internals;
 
-using OpenTelemetry.Trace;
-
 namespace Azure.Monitor.OpenTelemetry.Exporter.Models
 {
     internal partial class RemoteDependencyData
     {
         // https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/database.md#connection-level-attributes
-        internal static readonly HashSet<string> s_sqlDbs = new HashSet<string>() { "mssql" };
+        internal static readonly HashSet<string?> s_sqlDbs = new HashSet<string?>() { "mssql" };
 
         public RemoteDependencyData(int version, Activity activity, ref TagEnumerationState monitorTags) : base(version)
         {
-            string httpUrl = null;
+            string? httpUrl = null;
             string dependencyName;
 
             if (monitorTags.activityType == OperationType.Http)

sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Customizations/Models/RequestData.cs

@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-#nullable disable // TODO: remove and fix errors
-
 using System.Diagnostics;
 using System.Globalization;
 using Azure.Core;
@@ -14,7 +12,7 @@ internal partial class RequestData
     {
         public RequestData(int version, Activity activity, ref TagEnumerationState monitorTags) : base(version)
         {
-            string url = null;
+            string? url = null;
 
             switch (monitorTags.activityType)
             {
@@ -35,7 +33,7 @@ public RequestData(int version, Activity activity, ref TagEnumerationState monit
                 ?.ToString().Truncate(SchemaConstants.RequestData_ResponseCode_MaxLength)
                 ?? "0";
 
-            Success = isSuccess(activity, ResponseCode, monitorTags.activityType);
+            Success = IsSuccess(activity, ResponseCode, monitorTags.activityType);
 
             Url = url.Truncate(SchemaConstants.RequestData_Url_MaxLength);
             Properties = new ChangeTrackingDictionary<string, string>();
@@ -45,9 +43,11 @@ public RequestData(int version, Activity activity, ref TagEnumerationState monit
             TraceHelper.AddPropertiesToTelemetry(Properties, ref monitorTags.UnMappedTags);
         }
 
-        internal static bool isSuccess(Activity activity, string responseCode, OperationType operationType)
+        internal static bool IsSuccess(Activity activity, string? responseCode, OperationType operationType)
         {
-            if (operationType == OperationType.Http && int.TryParse(responseCode, out int statusCode))
+            if (operationType == OperationType.Http
+                && responseCode != null
+                && int.TryParse(responseCode, out int statusCode))
             {
                 bool isSuccessStatusCode = statusCode != 0 && statusCode < 400;
                 return activity.Status != ActivityStatusCode.Error && isSuccessStatusCode;

sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Customizations/Models/TelemetryExceptionData.cs

@@ -1,8 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-#nullable disable // TODO: remove and fix errors
-
 using System;
 using System.Collections.Generic;
 using System.Globalization;
@@ -20,6 +18,11 @@ internal partial class TelemetryExceptionData
 
         public TelemetryExceptionData(int version, LogRecord logRecord) : base(version)
         {
+            if (logRecord.Exception == null)
+            {
+                throw new ArgumentNullException(nameof(logRecord), "logRecord.Exception cannot be null.");
+            }
+
             Properties = new ChangeTrackingDictionary<string, string>();
             Measurements = new ChangeTrackingDictionary<string, double>();
 
@@ -55,16 +58,15 @@ public TelemetryExceptionData(int version, LogRecord logRecord) : base(version)
             Exceptions = exceptions;
         }
 
-        private void ConvertExceptionTree(Exception exception, string message, TelemetryExceptionDetails parentExceptionDetails, List<TelemetryExceptionDetails> exceptions)
+        private void ConvertExceptionTree(Exception exception, string? message, TelemetryExceptionDetails? parentExceptionDetails, List<TelemetryExceptionDetails> exceptions)
         {
             // For upper level exception see if message was provided and do not use exception.message in that case
             if (parentExceptionDetails != null && string.IsNullOrWhiteSpace(message))
             {
-                message = exception?.Message;
+                message = exception.Message;
             }
 
-            TelemetryExceptionDetails exceptionDetails = new TelemetryExceptionDetails(exception, message,
-                                                                                       parentExceptionDetails);
+            TelemetryExceptionDetails exceptionDetails = new TelemetryExceptionDetails(exception, message, parentExceptionDetails);
 
             exceptions.Add(exceptionDetails);
 

sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Customizations/Models/TelemetryExceptionDetails.cs

@@ -14,7 +14,7 @@ internal partial class TelemetryExceptionDetails
         /// <summary>
         /// Creates a new instance of ExceptionDetails from a System.Exception and a parent ExceptionDetails.
         /// </summary>
-        internal TelemetryExceptionDetails(Exception exception, string message, TelemetryExceptionDetails? parentExceptionDetails)
+        internal TelemetryExceptionDetails(Exception exception, string? message, TelemetryExceptionDetails? parentExceptionDetails)
         {
             if (exception == null)
             {

sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/StandardMetricsExtractionProcessor.cs

@@ -73,7 +73,7 @@ private void ReportRequestDurationMetric(Activity activity, string statusCodeAtt
             tags.Add(new KeyValuePair<string, object?>(StandardMetricConstants.IsAutoCollectedKey, "True"));
             tags.Add(new KeyValuePair<string, object?>(StandardMetricConstants.CloudRoleInstanceKey, StandardMetricResource?.RoleInstance));
             tags.Add(new KeyValuePair<string, object?>(StandardMetricConstants.CloudRoleNameKey, StandardMetricResource?.RoleName));
-            tags.Add(new KeyValuePair<string, object?>(StandardMetricConstants.RequestSuccessKey, RequestData.isSuccess(activity, statusCodeAttributeValue, OperationType.Http)));
+            tags.Add(new KeyValuePair<string, object?>(StandardMetricConstants.RequestSuccessKey, RequestData.IsSuccess(activity, statusCodeAttributeValue, OperationType.Http)));
 
             // Report metric
             _requestDuration.Record(activity.Duration.TotalMilliseconds, tags);