Skip to content

Commit d5743a9

Browse files
authored
Rename runId to run_id (Azure#49552)
* Generate new code * Re recrd and fix tests
1 parent 9a530bb commit d5743a9

File tree

5 files changed

+11
-8
lines changed

5 files changed

+11
-8
lines changed

sdk/ai/Azure.AI.Projects/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
### Breaking Changes
99

1010
### Bugs Fixed
11+
* Fix for filtering of messages by run ID [see GitHub issue issue 49513](https://github.com/Azure/azure-sdk-for-net/issues/49513).
1112

1213
### Other Changes
1314

sdk/ai/Azure.AI.Projects/assets.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"AssetsRepo": "Azure/azure-sdk-assets",
33
"AssetsRepoPrefixPath": "net",
44
"TagPrefix": "net/ai/Azure.AI.Projects",
5-
"Tag": "net/ai/Azure.AI.Projects_a26d6dce6c"
5+
"Tag": "net/ai/Azure.AI.Projects_0612f24f84"
66
}

sdk/ai/Azure.AI.Projects/src/Generated/AgentsClient.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/ai/Azure.AI.Projects/tests/AgentClientTests.cs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,7 @@ public async Task TestSubmitToolOutputs(ArgumentType argType, bool parallelToolC
636636
Assert.True(functionCalled);
637637
Assert.AreEqual(RunStatus.Completed, toolRun.Status, message: toolRun.LastError?.Message);
638638
PageableList<ThreadMessage> messages = await client.GetMessagesAsync(toolRun.ThreadId, toolRun.Id);
639-
Assert.Greater(messages.Data.Count, 1);
639+
Assert.GreaterOrEqual(messages.Data.Count, 1);
640640
Assert.AreEqual(parallelToolCalls, toolRun.ParallelToolCalls);
641641
}
642642

@@ -749,7 +749,7 @@ await client.CreateVectorStoreFileAsync(
749749
}
750750
Assert.IsNotNull(fileSearchRun);
751751
PageableList<ThreadMessage> messages = await client.GetMessagesAsync(fileSearchRun.ThreadId, fileSearchRun.Id);
752-
Assert.Greater(messages.Data.Count, 1);
752+
Assert.GreaterOrEqual(messages.Data.Count, 1);
753753
// Check list, get and delete operations.
754754
VectorStore getVct = await client.GetVectorStoreAsync(vectorStore.Id);
755755
Assert.AreEqual(vectorStore.Id, getVct.Id);
@@ -840,9 +840,11 @@ await client.CreateMessageAsync(
840840
ThreadRun fileSearchRun = await client.CreateRunAsync(thread, agent);
841841
fileSearchRun = await WaitForRun(client, fileSearchRun);
842842
PageableList<ThreadMessage> messages = await client.GetMessagesAsync(fileSearchRun.ThreadId, fileSearchRun.Id);
843-
Assert.Greater(messages.Data.Count, 1);
843+
Assert.GreaterOrEqual(messages.Data.Count, 1);
844844
}
845845

846+
// TODO: Check the service and enable this test.
847+
[Ignore("There is a regression on the service side and test will fail. 2025-04-03")]
846848
[RecordedTest]
847849
[TestCase(true, true)]
848850
[TestCase(true, false)]
@@ -930,7 +932,7 @@ public async Task TestCreateVectorStoreOnline()
930932

931933
fileSearchRun = await WaitForRun(client, fileSearchRun);
932934
PageableList<ThreadMessage> messages = await client.GetMessagesAsync(fileSearchRun.ThreadId, fileSearchRun.Id);
933-
Assert.Greater(messages.Data.Count, 1);
935+
Assert.GreaterOrEqual(messages.Data.Count, 1);
934936
}
935937

936938
[RecordedTest]
@@ -994,7 +996,7 @@ public async Task TestIncludeFileSearchContent(bool useStream, bool includeConte
994996
fileSearchRun = await WaitForRun(client, fileSearchRun);
995997
PageableList<ThreadMessage> messages = await client.GetMessagesAsync(fileSearchRun.ThreadId, fileSearchRun.Id);
996998
Assert.AreEqual(RunStatus.Completed, fileSearchRun.Status);
997-
Assert.Greater(messages.Data.Count, 1);
999+
Assert.GreaterOrEqual(messages.Data.Count, 1);
9981000
}
9991001
// TODO: Implement include in streaming scenario, see task 3801146.
10001002
PageableList<RunStep> steps = await client.GetRunStepsAsync(
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
directory: specification/ai/Azure.AI.Projects
2-
commit: 700384de9c700a7b1f4b254c0f09b768a1f14987
2+
commit: 0c16eaab2ab3fb6379871f77353251bd6f5c643a
33
repo: Azure/azure-rest-api-specs
44
additionalDirectories:

0 commit comments

Comments
 (0)