Skip to content

Commit d5825f5

Browse files
HotFix: PostProcessingOptions (Azure#50358)
* init commit * run generation commands * run generation commands * run generation commands * fix line * set Summarization and Transcription Settings * fix typo * rename variables * ran scripts * remove optional params * update tests * removed transcription setter * small fix
1 parent c77095f commit d5825f5

File tree

6 files changed

+9
-58
lines changed

6 files changed

+9
-58
lines changed

sdk/communication/Azure.Communication.CallAutomation/api/Azure.Communication.CallAutomation.net8.0.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1413,14 +1413,9 @@ public PlayToAllOptions(System.Collections.Generic.IEnumerable<Azure.Communicati
14131413
public partial class PostProcessingOptions
14141414
{
14151415
public PostProcessingOptions(Azure.Communication.CallAutomation.TranscriptionSettings transcription) { }
1416-
public PostProcessingOptions(Azure.Communication.CallAutomation.TranscriptionSettings transcriptionSettings, Azure.Communication.CallAutomation.SummarizationSettings summarizationSettings = null, string cognitiveServicesEndpoint = null) { }
14171416
public string CognitiveServicesEndpoint { get { throw null; } set { } }
14181417
public Azure.Communication.CallAutomation.SummarizationSettings Summarization { get { throw null; } set { } }
1419-
public Azure.Communication.CallAutomation.SummarizationSettings SummarizationSettings { get { throw null; } set { } }
14201418
public Azure.Communication.CallAutomation.TranscriptionSettings Transcription { get { throw null; } }
1421-
public Azure.Communication.CallAutomation.TranscriptionSettings TranscriptionSettings { get { throw null; } set { } }
1422-
public void setSummarizationSettings(bool enableSummarization) { }
1423-
public void setTranscriptionSettings(bool enableTranscription) { }
14241419
}
14251420
public partial class PowerVirtualAgentsDialog : Azure.Communication.CallAutomation.BaseDialog
14261421
{

sdk/communication/Azure.Communication.CallAutomation/api/Azure.Communication.CallAutomation.netstandard2.0.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1412,14 +1412,9 @@ public PlayToAllOptions(System.Collections.Generic.IEnumerable<Azure.Communicati
14121412
public partial class PostProcessingOptions
14131413
{
14141414
public PostProcessingOptions(Azure.Communication.CallAutomation.TranscriptionSettings transcription) { }
1415-
public PostProcessingOptions(Azure.Communication.CallAutomation.TranscriptionSettings transcriptionSettings, Azure.Communication.CallAutomation.SummarizationSettings summarizationSettings = null, string cognitiveServicesEndpoint = null) { }
14161415
public string CognitiveServicesEndpoint { get { throw null; } set { } }
14171416
public Azure.Communication.CallAutomation.SummarizationSettings Summarization { get { throw null; } set { } }
1418-
public Azure.Communication.CallAutomation.SummarizationSettings SummarizationSettings { get { throw null; } set { } }
14191417
public Azure.Communication.CallAutomation.TranscriptionSettings Transcription { get { throw null; } }
1420-
public Azure.Communication.CallAutomation.TranscriptionSettings TranscriptionSettings { get { throw null; } set { } }
1421-
public void setSummarizationSettings(bool enableSummarization) { }
1422-
public void setTranscriptionSettings(bool enableTranscription) { }
14231418
}
14241419
public partial class PowerVirtualAgentsDialog : Azure.Communication.CallAutomation.BaseDialog
14251420
{

sdk/communication/Azure.Communication.CallAutomation/src/Generated/Models/PostProcessingOptions.Serialization.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/communication/Azure.Communication.CallAutomation/src/Generated/Models/PostProcessingOptions.cs

Lines changed: 0 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/communication/Azure.Communication.CallAutomation/src/Models/PostProcessingOptions.cs

Lines changed: 5 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,10 @@ public partial class PostProcessingOptions
1616
/// Initializes a new instance of the <see cref="PostProcessingOptions"/> class.
1717
/// </summary>
1818
public PostProcessingOptions(
19-
TranscriptionSettings transcriptionSettings,
20-
SummarizationSettings summarizationSettings = null,
21-
string cognitiveServicesEndpoint = null)
19+
TranscriptionSettings transcription
20+
)
2221
{
23-
this.CognitiveServicesEndpoint = cognitiveServicesEndpoint;
24-
this.SummarizationSettings = summarizationSettings;
25-
this.TranscriptionSettings = transcriptionSettings;
22+
this.Transcription = transcription;
2623
}
2724

2825
/// <summary>
@@ -31,26 +28,8 @@ public PostProcessingOptions(
3128
/// </summary>
3229
public string CognitiveServicesEndpoint { get; set; }
3330
/// <summary> Define options of the transcription for the post recording processing. </summary>
34-
public TranscriptionSettings TranscriptionSettings { get; set;}
31+
public TranscriptionSettings Transcription { get; }
3532
/// <summary> Define options of the summarization for the post recording processing. </summary>
36-
public SummarizationSettings SummarizationSettings { get; set; }
37-
38-
/// <summary>
39-
/// Set the transcription settings for the post recording processing.
40-
/// </summary>
41-
/// <param name="enableTranscription"></param>
42-
public void setTranscriptionSettings(bool enableTranscription)
43-
{
44-
this.TranscriptionSettings = new TranscriptionSettings(enableTranscription);
45-
}
46-
47-
/// <summary>
48-
/// Set the summarization settings for the post recording processing.
49-
/// </summary>
50-
/// <param name="enableSummarization"></param>
51-
public void setSummarizationSettings(bool enableSummarization)
52-
{
53-
this.Summarization = new SummarizationSettings(enableSummarization);
54-
}
33+
public SummarizationSettings Summarization { get; set; }
5534
}
5635
}

sdk/communication/Azure.Communication.CallAutomation/tests/CallRecordings/CallRecordingTests.cs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -263,9 +263,7 @@ private CallRecording getMockCallRecording(int statusCode, string? responseConte
263263
ChannelAffinity = testChannelAffinities,
264264
PauseOnStart = false,
265265
PostProcessingOptions = new PostProcessingOptions(
266-
new TranscriptionSettings(true),
267-
new SummarizationSettings(true),
268-
"https://somecognitiveurl"
266+
new TranscriptionSettings(true)
269267
)
270268
})
271269
},
@@ -310,9 +308,7 @@ private CallRecording getMockCallRecording(int statusCode, string? responseConte
310308
ChannelAffinity = testChannelAffinities,
311309
PauseOnStart = false,
312310
PostProcessingOptions = new PostProcessingOptions(
313-
new TranscriptionSettings(true),
314-
new SummarizationSettings(true),
315-
"https://somecognitiveurl"
311+
new TranscriptionSettings(true)
316312
),
317313
AudioChannelParticipantOrdering = { new CommunicationUserIdentifier("test"),}
318314
}).ConfigureAwait(false),

0 commit comments

Comments
 (0)