[Governance] Fixing outdated references (Azure#48586)

* [Governance] Fixing outdated references

The focus of these changes is to update the package
references in the TimeSeriesInsights client sample to
remove deprecated/vulnerable packages. Also included
is a bump to the Event Hubs sample target frameworks
to modernize.

* Adding <IsTestProject> to stop pullrequest from looking for a changelog

* Removing auto-generated solution

* Updating README content to bypass weird changelog logic

* Explicitly overriding <IsShippingLibrary>

* Moving non-shipping declaration to props

Author: jsquire

sdk/eventhub/Azure.Messaging.EventHubs.Processor/samples/aspnet-hosted-service/Directory.Build.props

@@ -13,6 +13,6 @@
 
   <PropertyGroup>
     <IsShippingLibrary>false</IsShippingLibrary>
-    <RequiredTargetFrameworks Condition="$(IsTestProject) != 'true'">net6.0;net7.0</RequiredTargetFrameworks>
+    <RequiredTargetFrameworks Condition="$(IsTestProject) != 'true'">net8.0;net9.0</RequiredTargetFrameworks>
   </PropertyGroup>
 </Project>

sdk/timeseriesinsights/Azure.IoT.TimeSeriesInsights/Azure.IoT.TimeSeriesInsights.sln

@@ -1,7 +1,7 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio Version 16
-VisualStudioVersion = 16.0.29709.97
+# Visual Studio Version 17
+VisualStudioVersion = 17.13.35825.156
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Azure.IoT.TimeSeriesInsights", "src\Azure.IoT.TimeSeriesInsights.csproj", "{E33D09D9-D809-472C-82E6-6A26BDB86FC2}"
 EndProject
@@ -20,7 +20,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
 		..\Update-TsiSnippets.ps1 = ..\Update-TsiSnippets.ps1
 	EndProjectSection
 EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TimeSeriesInsightsClientSample", "samples\TimeSeriesInsightsClientSample\TimeSeriesInsightsClientSample.csproj", "{D243481B-0944-4F60-9B1F-35EDFC7769BA}"
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Azure.IoT.TimeSeriesInsights.Tests.ClientSample", "samples\TimeSeriesInsightsClientSample\Azure.IoT.TimeSeriesInsights.Tests.ClientSample.csproj", "{D243481B-0944-4F60-9B1F-35EDFC7769BA}"
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
@@ -44,10 +44,6 @@ Global
 		{D243481B-0944-4F60-9B1F-35EDFC7769BA}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{D243481B-0944-4F60-9B1F-35EDFC7769BA}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{D243481B-0944-4F60-9B1F-35EDFC7769BA}.Release|Any CPU.Build.0 = Release|Any CPU
-		{7FE9FA2F-7793-4EB9-B8D0-26696536508B}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
-		{7FE9FA2F-7793-4EB9-B8D0-26696536508B}.Debug|Any CPU.Build.0 = Debug|Any CPU
-		{7FE9FA2F-7793-4EB9-B8D0-26696536508B}.Release|Any CPU.ActiveCfg = Release|Any CPU
-		{7FE9FA2F-7793-4EB9-B8D0-26696536508B}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE

sdk/timeseriesinsights/Azure.IoT.TimeSeriesInsights/samples/Directory.Build.props

@@ -0,0 +1,17 @@
+<Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <PropertyGroup>
+    <ExcludeFromCodeCoverage>true</ExcludeFromCodeCoverage>
+    <IsPackable>false</IsPackable>
+    <WarnOnPackingNonPackableProject>false</WarnOnPackingNonPackableProject>
+  </PropertyGroup>
+
+  <!-- Import the common SDK build properties. -->
+  <Import
+    Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory).., Directory.Build.props))\Directory.Build.props"
+		Condition="'$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory).., Directory.Build.props))' != ''"
+  />
+
+  <PropertyGroup>
+    <IsShippingLibrary>false</IsShippingLibrary>
+  </PropertyGroup>
+</Project>

sdk/timeseriesinsights/Azure.IoT.TimeSeriesInsights/samples/Readme.md

@@ -5,14 +5,7 @@ A `TimeSeriesInsightsClient` is the primary interface for developers using the T
 ## Creating TimeSeriesInsightsClient
 
 To create a new Time Series Insights client, you need the endpoint to an Azure Time Series Insights environment and supply credentials.
-To use the [DefaultAzureCredential][DefaultAzureCredential] provider shown below,
-or other credential providers provided with the Azure SDK, please install the Azure.Identity package:
-
-```dotnetcli
-dotnet add package Azure.Identity
-```
-
-Set the values of the client ID, tenant ID, and client secret of the AAD application as environment variables: AZURE_CLIENT_ID, AZURE_TENANT_ID, AZURE_CLIENT_SECRET.
+To use the [DefaultAzureCredential][DefaultAzureCredential] provider shown below, or other credential providers provided with the Azure SDK, please install the [Azure.Identity][AzureIdentity].
 
 ```C# Snippet:TimeSeriesInsightsSampleCreateServiceClientWithClientSecret
 // DefaultAzureCredential supports different authentication mechanisms and determines the appropriate credential type based on the environment it is executing in.
@@ -24,7 +17,7 @@ var client = new TimeSeriesInsightsClient(
     tokenCredential);
 ```
 
-# Time Series Insights Samples
+## Time Series Insights Samples
 
 The following section provides several code snippets using the `client` created above, and covers the main functions of Time Series Insights. You can explore and learn more about the Time Series Insights client library APIs through using the samples project.
 
@@ -69,9 +62,9 @@ Here's what a retrieved model settings object looks like.
     {
       "Name": "Building",
       "Type": {
-        "HasValue": true, 
+        "HasValue": true,
         "Value": {
-          
+
         }
       }
     },
@@ -80,7 +73,7 @@ Here's what a retrieved model settings object looks like.
       "Type": {
         "HasValue": true,
         "Value": {
-          
+
         }
       }
     },
@@ -89,7 +82,7 @@ Here's what a retrieved model settings object looks like.
       "Type": {
         "HasValue": true,
         "Value": {
-          
+
         }
       }
     }
@@ -686,7 +679,8 @@ await foreach (TimeSeriesPoint point in query.GetResultsAsync())
 ```
 
 <!-- LINKS -->
-[DefaultAzureCredential]: https://github.com/Azure/azure-sdk-for-net/tree/main/sdk/identity/Azure.Identity/README.md
+[AzureIdentity]: https://learn.microsoft.com/dotnet/api/overview/azure/identity-readme?view=azure-dotnet
+[DefaultAzureCredential]: https://learn.microsoft.com/dotnet/api/azure.identity.defaultazurecredential?view=azure-dotnet
 [tsi_instances_learn_more]: https://learn.microsoft.com/azure/time-series-insights/concepts-model-overview#time-series-model-instances
 [tsi_id_learn_more]: https://learn.microsoft.com/azure/time-series-insights/how-to-select-tsid
 [tsi_hierarchies_learn_more]: https://learn.microsoft.com/azure/time-series-insights/concepts-model-overview#time-series-model-hierarchies

sdk/timeseriesinsights/Azure.IoT.TimeSeriesInsights/samples/TimeSeriesInsightsClientSample/Azure.IoT.TimeSeriesInsights.Tests.ClientSample.csproj

@@ -0,0 +1,29 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net8.0</TargetFramework>
+    <IsSamplesProject>true</IsSamplesProject>
+  </PropertyGroup>
+
+  <!-- NU5104: Using a project reference to the client causes build warning/errors on build agents. -->
+  <PropertyGroup>
+    <NoWarn>$(NoWarn);AZC0100;AZC0012;CS1591</NoWarn>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Azure.Identity" />
+    <PackageReference Include="CommandLineParser" />
+    <PackageReference Include="Microsoft.Azure.Devices" />
+    <PackageReference Include="Microsoft.Azure.Devices.Client" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <ProjectReference Include="..\..\src\Azure.IoT.TimeSeriesInsights.csproj" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <AdditionalFiles Include="..\readme.md" />
+  </ItemGroup>
+
+</Project>

sdk/timeseriesinsights/Azure.IoT.TimeSeriesInsights/samples/TimeSeriesInsightsClientSample/Options.cs

@@ -16,24 +16,6 @@ public class Options
         [Option('a', "tsiEnvironmentFqdn", Required = true, HelpText = "Time Series Insights environment FQDN")]
         public string TsiEnvironmentFqdn { get; set; }
 
-        /// <summary>
-        /// The application Id used to log the user in.
-        /// </summary>
-        [Option('i', "clientId", Required = true, HelpText = "Client Id of the application Id to login, or the application Id used to log the user in.")]
-        public string ClientId { get; set; }
-
-        /// <summary>
-        /// The tenant Id used when logging the user in.
-        /// </summary>
-        [Option('t', "tenantId", Required = true, HelpText = "Application tenant Id")]
-        public string TenantId { get; set; }
-
-        /// <summary>
-        /// The application client secret.
-        /// </summary>
-        [Option('s', "clientSecret", Required = false, HelpText = "Application client secret. Only applicable when using LoginMethod of AppId.")]
-        public string ClientSecret { get; set; }
-
         /// <summary>
         /// The IoT hub connection string.
         /// </summary>

sdk/timeseriesinsights/Azure.IoT.TimeSeriesInsights/samples/TimeSeriesInsightsClientSample/Program.cs

@@ -34,11 +34,7 @@ public static async Task Main(string[] args)
                     });
 
             // Instantiate the Time Series Insights client
-            TimeSeriesInsightsClient tsiClient = GetTimeSeriesInsightsClient(
-                options.TenantId,
-                options.ClientId,
-                options.ClientSecret,
-                options.TsiEnvironmentFqdn);
+            TimeSeriesInsightsClient tsiClient = GetTimeSeriesInsightsClient(options.TsiEnvironmentFqdn);
 
             // Instantiate an IoT Hub device client client in order to send telemetry to the hub
             DeviceClient deviceClient = await GetDeviceClientAsync(options.IoTHubConnectionString).ConfigureAwait(false);
@@ -62,7 +58,7 @@ public static async Task Main(string[] args)
 
             var tsiHierarchiesSamples = new HierarchiesSamples();
             await tsiHierarchiesSamples.RunSamplesAsync(tsiClient);
-            
+
             var tsiModelSettingsSamples = new ModelSettingsSamples();
             await tsiModelSettingsSamples.RunSamplesAsync(tsiClient);
 
@@ -75,13 +71,8 @@ public static async Task Main(string[] args)
         /// implementation of <see cref="Azure.Core.TokenCredential"/>.
         /// </summary>
         /// <param name="tsiEndpoint">The endpoint of the Time Series Insights instance.</param>
-        private static TimeSeriesInsightsClient GetTimeSeriesInsightsClient(string tenantId, string clientId, string clientSecret, string tsiEndpoint)
+        private static TimeSeriesInsightsClient GetTimeSeriesInsightsClient(string tsiEndpoint)
         {
-            // These environment variables are necessary for DefaultAzureCredential to use application Id and client secret to login.
-            Environment.SetEnvironmentVariable("AZURE_CLIENT_SECRET", clientSecret);
-            Environment.SetEnvironmentVariable("AZURE_CLIENT_ID", clientId);
-            Environment.SetEnvironmentVariable("AZURE_TENANT_ID", tenantId);
-
             #region Snippet:TimeSeriesInsightsSampleCreateServiceClientWithClientSecret
 
             // DefaultAzureCredential supports different authentication mechanisms and determines the appropriate credential type based on the environment it is executing in.