Rename Etag to ETag in management plane generator (Azure#53393)

* Initial plan

* Add Etag to ETag renaming in NameVisitor

Co-authored-by: live1206 <[email protected]>

* Refactor Etag renaming to use dictionary for extensibility

Co-authored-by: live1206 <[email protected]>

* Move _propertyNameRenamingMap closer to its usage

Co-authored-by: live1206 <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: live1206 <[email protected]>

Author: Copilot

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Visitors/NameVisitor.cs

@@ -116,6 +116,7 @@ private void UpdateSerialization(ModelProvider type, string newName, string orig
         DoPreVisitPropertyForResourceTypeName(property, propertyProvider);
         DoPreVisitPropertyForUrlPropertyName(property, propertyProvider);
         DoPreVisitPropertyForTimePropertyName(property, propertyProvider);
+        DoPreVisitPropertyNameRenaming(property, propertyProvider);
         return base.PreVisitProperty(property, propertyProvider);
     }
 
@@ -196,6 +197,20 @@ private void DoPreVisitPropertyForTimePropertyName(InputProperty property, Prope
         }
     }
 
+    // Dictionary to hold property name renaming mappings
+    private static readonly Dictionary<string, string> _propertyNameRenamingMap = new()
+        {
+            {"Etag", "ETag"}
+        };
+
+    private void DoPreVisitPropertyNameRenaming(InputProperty property, PropertyProvider? propertyProvider)
+    {
+        if (propertyProvider != null && _propertyNameRenamingMap.TryGetValue(propertyProvider.Name, out var newPropertyName))
+        {
+            propertyProvider.Update(name: newPropertyName);
+        }
+    }
+
     protected override MethodProvider? VisitMethod(MethodProvider method)
     {
         var parameterUpdated = false;

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/test/NameVisitorTests.cs

@@ -116,5 +116,29 @@ public void TestPrependResourceProviderNameForEnum()
             var updatedSkuModelName = $"{resourceProviderName}{enumName}";
             Assert.AreEqual(type?.Name, updatedSkuModelName);
         }
+
+        [Test]
+        public void TestTransformEtagToETag()
+        {
+            const string testModelName = "TestModel";
+            const string testPropertyName = "Etag";
+            var modelProperty = InputFactory.Property(testPropertyName, InputPrimitiveType.String, serializedName: "etag", isRequired: true);
+            var model = InputFactory.Model(testModelName, properties: [modelProperty]);
+            var responseType = InputFactory.OperationResponse(statusCodes: [200], bodytype: model);
+            var testNameParameter = InputFactory.MethodParameter("testName", InputPrimitiveType.String, location: InputRequestLocation.Path);
+            var operation = InputFactory.Operation(name: "get", responses: [responseType], parameters: [testNameParameter], path: "/providers/a/test/{testName}", decorators: []);
+
+            var client = InputFactory.Client(
+                TestClientName,
+                methods: [InputFactory.BasicServiceMethod("Get", operation, parameters: [testNameParameter])],
+                crossLanguageDefinitionId: $"Test.{TestClientName}",
+                decorators: []);
+
+            var plugin = ManagementMockHelpers.LoadMockPlugin(inputModels: () => [model], clients: () => [client]);
+
+            // PreVisitModel is called during the model creation
+            var type = plugin.Object.TypeFactory.CreateModel(model);
+            Assert.That(type?.Properties[0].Name, Is.EqualTo("ETag"));
+        }
     }
 }