Prepend PR name to known models (Azure#51600)

Author: live1206

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Visitors/NameVisitor.cs

@@ -4,6 +4,7 @@
 using Azure.Core;
 using Azure.Generator.Management.Primitives;
 using Azure.Generator.Management.Providers;
+using Azure.Generator.Management.Utilities;
 using Microsoft.TypeSpec.Generator.ClientModel;
 using Microsoft.TypeSpec.Generator.Input;
 using Microsoft.TypeSpec.Generator.Primitives;
@@ -17,37 +18,78 @@ namespace Azure.Generator.Management.Visitors;
 internal class NameVisitor : ScmLibraryVisitor
 {
     private const string ResourceTypeName = "ResourceType";
+    private static readonly HashSet<string> _knownModels = new HashSet<string>()
+        {
+            "Sku",
+            "SkuName",
+            "SkuTier",
+            "SkuFamily",
+            "SkuInformation",
+            "Plan",
+            "Usage",
+            "Kind",
+            // Private endpoint definitions which are defined in swagger common-types/privatelinks.json and are used by RPs
+            "PrivateEndpointConnection",
+            "PrivateLinkResource",
+            "PrivateLinkServiceConnectionState",
+            "PrivateEndpointServiceConnectionStatus",
+            "PrivateEndpointConnectionProvisioningState",
+            // not defined in common-types, but common in various RP
+            "PrivateLinkResourceProperties",
+            "PrivateLinkServiceConnectionStateProperty",
+            // internal, but could be public in the future, also make the names more consistent
+            "PrivateEndpointConnectionListResult",
+            "PrivateLinkResourceListResult"
+        };
 
     private readonly HashSet<CSharpType> _resourceUpdateModelTypes = new();
 
     protected override ModelProvider? PreVisitModel(InputModelType model, ModelProvider? type)
     {
         var inputLibrary = ManagementClientGenerator.Instance.InputLibrary;
-        if (type is not null && TryTransformUrlToUri(model.Name, out var newName))
+        if (type is null)
+        {
+            return null;
+        }
+
+        if (TryTransformUrlToUri(model.Name, out var newName))
         {
             type.Update(name: newName);
+            UpdateSerialization(type, newName);
         }
 
-        if (type is not null)
+        if (_knownModels.Contains(model.Name))
         {
-            if (inputLibrary.TryFindEnclosingResourceNameForResourceUpdateModel(model, out var enclosingResourceName))
-            {
-                var newModelName = $"{enclosingResourceName}Patch";
+            var UpdatedName = $"{ManagementClientGenerator.Instance.TypeFactory.ResourceProviderName}{model.Name}";
+            type.Update(name: UpdatedName);
+            UpdateSerialization(type, UpdatedName);
+        }
+
+        if (inputLibrary.TryFindEnclosingResourceNameForResourceUpdateModel(model, out var enclosingResourceName))
+        {
+            var newModelName = $"{enclosingResourceName}Patch";
 
-                _resourceUpdateModelTypes.Add(type.Type);
+            _resourceUpdateModelTypes.Add(type.Type);
 
-                type.Update(name: newModelName);
+            type.Update(name: newModelName);
 
-                foreach (var serializationProvider in type.SerializationProviders)
-                {
-                    serializationProvider.Update(name: newModelName);
-                    _resourceUpdateModelTypes.Add(serializationProvider.Type);
-                }
+            foreach (var serializationProvider in type.SerializationProviders)
+            {
+                serializationProvider.Update(name: newModelName);
+                _resourceUpdateModelTypes.Add(serializationProvider.Type);
             }
         }
         return base.PreVisitModel(model, type);
     }
 
+    private static void UpdateSerialization(ModelProvider type, string newName)
+    {
+        foreach (var serializationProvider in type.SerializationProviders)
+        {
+            serializationProvider.Update(name: newName);
+        }
+    }
+
     protected override PropertyProvider? PreVisitProperty(InputProperty property, PropertyProvider? propertyProvider)
     {
         DoPreVisitPropertyForResourceTypeName(property, propertyProvider);

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/test/NameVisitorTests.cs

@@ -1,9 +1,11 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+using Azure.Generator.Management;
 using Azure.Generator.Management.Tests.TestHelpers;
 using Azure.Generator.Management.Visitors;
 using Azure.Generator.Tests.Common;
+using Microsoft.TypeSpec.Generator;
 using Microsoft.TypeSpec.Generator.Input;
 using Microsoft.TypeSpec.Generator.Providers;
 using NUnit.Framework;
@@ -39,6 +41,33 @@ public void TestTransformUrlToUri()
             Assert.That(transformedModel?.Properties[0].Name, Is.EqualTo(TestProtyName.Replace("Url", "Uri")));
         }
 
+        [Test]
+        public void TestPrependResourceProviderName()
+        {
+            var skuModelName = "Sku";
+            var modelProperty = InputFactory.Property("TestName", InputPrimitiveType.String, serializedName: "testName", isRequired: true);
+            var model = InputFactory.Model(skuModelName, properties: [modelProperty]);
+            var responseType = InputFactory.OperationResponse(statusCodes: [200], bodytype: model);
+            var testNameParameter = InputFactory.Parameter("testName", InputPrimitiveType.String, location: InputRequestLocation.Path);
+            var operation = InputFactory.Operation(name: "get", responses: [responseType], parameters: [testNameParameter], path: "/providers/a/test/{testName}", decorators: []);
+
+            var client = InputFactory.Client(
+                TestClientName,
+                methods: [InputFactory.BasicServiceMethod("Get", operation, parameters: [testNameParameter])],
+                crossLanguageDefinitionId: $"Test.{TestClientName}",
+                decorators: []);
+
+            var plugin = ManagementMockHelpers.LoadMockPlugin(inputModels: () => [model], clients: () => [client]);
+            var visitor = new TestVisitor();
+            var type = plugin.Object.TypeFactory.CreateModel(model);
+            var transformedModel = visitor.InvokeVisit(model, type);
+            var resourceProviderName = ManagementClientGenerator.Instance.TypeFactory.ResourceProviderName;
+            Assert.AreEqual(transformedModel?.Name, $"{resourceProviderName}{skuModelName}");
+            var serializationProvider = transformedModel?.SerializationProviders.SingleOrDefault();
+            Assert.NotNull(serializationProvider);
+            Assert.AreEqual(serializationProvider!.Name, $"{resourceProviderName}{skuModelName}");
+        }
+
         private class TestVisitor : NameVisitor
         {
             public ModelProvider? InvokeVisit(InputModelType model, ModelProvider? type)