Updates suggested from Azure Board SDK review (Azure#29953)

* Updates suggested from Azure Board SDK review:

- CallConnectionClient and CallRecordingClient suffix 'Client' removed
- Azure.Communication.CallingServer.Models namespace removed
- CallConnectionClient and CallContentClient combined
- Hangup and Terminate combined. Hangup now expects boolean to either hangup, or terminate the call
- GetCallConnectionProperties now under CallConnectionClient
- GetCallConnectionProperties renamed to GetProperties
- ...Response suffix updated to be ...Result suffix (i.e. TransferCallToParticipantResponse -> TransferCallToParticipantResult)
- AlternateCallerId renamed
- All Options constructor doesn't take optional value as input
- GetParticipants now accepts participantMri string
- OperationResponse removed
- PlayMedia updated to accept PlaySource's derived class (FileSource)
- Added many Internal models to hide generated models that contoso do not need
- AnswerCall and CreateCall now returns Result. This object now contains both CallProperties & CallConnectionClient
- CreateCall now accepts subject instead of option that contains only 1 value
- ...Type suffix now dropped. (i.e. RecordingContentType -> RecordingContent)
- ServerCallingModelFactory to include all read-only models
- Autorest regenerated with latest swagger
- Tests updated to accomodate latest changes
- Summaries of each methods updated to accomodate latest changes
- README.md updated to accomodate latest changes

* regenerated clients (rebase from main)

Co-authored-by: Min Woo Lee 🧊 <[email protected]>

Author: minwoolee-msft

sdk/communication/Azure.Communication.CallingServer/README.md

@@ -18,7 +18,7 @@ You need an [Azure subscription][azure_sub] and a [Communication Service Resourc
 To create a new Communication Service, you can use the [Azure Portal][communication_resource_create_portal], the [Azure PowerShell][communication_resource_create_power_shell], or the [.NET management client library][communication_resource_create_net].
 
 ### Key concepts
-`CallingServerClient` provides the functionality to make call connection, join call connection, answer incoming call or initialize a server call.
+`CallingServerClient` provides the functionality to answer incoming call or initialize an outbound call.
 
 ### Using statements
 ```C#
@@ -44,20 +44,20 @@ var client = new CallingServerClient(endpoint, tokenCredential);
 
 ## Examples
 ### Make a call to a phone number recipient
-To make an outbound call, call the `CreateCallConnection` or `CreateCallConnectionAsync` function from the `CallingServerClient`.
+To make an outbound call, call the `CreateCall` or `CreateCallAsync` function from the `CallingServerClient`.
 ```C#
-var createCallOption = new CreateCallOptions(
-       AlternateCallerId: new PhoneNumberIdentifier("<caller-id-phonenumber>") // E.164 formatted recipient phone number
+CallSource callSource = new CallSource(
+       new CommunicationUserIdentifier("<source-identifier>"), // Your Azure Communication Resource Guid Id used to make a Call
        );
+callSource.CallerId = new PhoneNumberIdentifier("<caller-id-phonenumber>") // E.164 formatted recipient phone number
 ```
 ```C#
-var callConnection = await callingServerClient.CreateCallAsync(
-    source: new CommunicationUserIdentifier("<source-identifier>"), // Your Azure Communication Resource Guid Id used to make a Call
+CreateCallResult createCallResult = await callingServerClient.CreateCallAsync(
+    source: callSource,
     targets: new List<CommunicationIdentifier>() { new PhoneNumberIdentifier("<targets-phone-number>") }, // E.164 formatted recipient phone number
-    callbackUri: new Uri(TestEnvironment.AppCallbackUrl),
-    options: createCallOption // The options for creating a call.
+    callbackUri: new Uri(TestEnvironment.AppCallbackUrl)
     );
-Console.WriteLine($"Call connection id: {callConnection.Value.CallConnectionId}");
+Console.WriteLine($"Call connection id: {createCallResult.CallProperties.CallConnectionId}");
 ```
 
 ## Troubleshooting

sdk/communication/Azure.Communication.CallingServer/api/Azure.Communication.CallingServer.netstandard2.0.cs

@@ -8,7 +8,7 @@ namespace Azure.Communication.CallingServer
 {
     internal static class AmsDirectRequestHelpers
     {
-        internal static HttpMessage GetHttpMessage(CallRecordingClient client, Uri requestEndpoint, RequestMethod requestMethod, HttpRange? rangeHeader = null)
+        internal static HttpMessage GetHttpMessage(CallRecording client, Uri requestEndpoint, RequestMethod requestMethod, HttpRange? rangeHeader = null)
         {
             Argument.CheckNotNull(client, nameof(client));
             Argument.CheckNotNull(requestEndpoint, nameof(requestEndpoint));

sdk/communication/Azure.Communication.CallingServer/src/AmsDirectRequestHelpers.cs

@@ -7,7 +7,6 @@
 using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
-using Azure.Communication.CallingServer.Models;
 using Azure.Core;
 using Azure.Core.Pipeline;
 
@@ -16,7 +15,7 @@ namespace Azure.Communication.CallingServer
     /// <summary>
     /// The Azure Communication Services Call Recording client.
     /// </summary>
-    public class CallRecordingClient
+    public class CallRecording
     {
         internal readonly string _resourceEndpoint;
         internal readonly ContentDownloader _contentDownloader;
@@ -26,7 +25,7 @@ public class CallRecordingClient
         internal ServerCallsRestClient serverCallsRestClient { get; }
         internal ContentRestClient contentRestClient { get; }
 
-        internal CallRecordingClient(string ResourceEndpoint, ServerCallsRestClient ServerCallsRestClient, ContentRestClient ContentRestClient, ClientDiagnostics ClientDiagnostics, HttpPipeline HttpPipeline)
+        internal CallRecording(string ResourceEndpoint, ServerCallsRestClient ServerCallsRestClient, ContentRestClient ContentRestClient, ClientDiagnostics ClientDiagnostics, HttpPipeline HttpPipeline)
         {
             _resourceEndpoint = ResourceEndpoint;
             serverCallsRestClient = ServerCallsRestClient;
@@ -36,8 +35,8 @@ internal CallRecordingClient(string ResourceEndpoint, ServerCallsRestClient Serv
             _pipeline = HttpPipeline;
         }
 
-        /// <summary>Initializes a new instance of <see cref="CallRecordingClient"/> for mocking.</summary>
-        protected CallRecordingClient()
+        /// <summary>Initializes a new instance of <see cref="CallRecording"/> for mocking.</summary>
+        protected CallRecording()
         {
             _resourceEndpoint = null;
             serverCallsRestClient = null;
@@ -56,9 +55,9 @@ protected CallRecordingClient()
         /// <param name="content">content for recording.</param>
         /// <param name="channel">channel for recording.</param>
         /// <param name="format">format for recording.</param>
-        public virtual Response<StartCallRecordingResponse> StartRecording(CallLocator callLocator, Uri recordingStateCallbackUri, RecordingContentType? content = null, RecordingChannelType? channel = null, RecordingFormatType? format = null, CancellationToken cancellationToken = default)
+        public virtual Response<RecordingStatusResult> StartRecording(CallLocator callLocator, Uri recordingStateCallbackUri, RecordingContent? content = null, RecordingChannel? channel = null, RecordingFormat? format = null, CancellationToken cancellationToken = default)
         {
-            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecordingClient)}.{nameof(StartRecording)}");
+            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecording)}.{nameof(StartRecording)}");
             scope.Start();
             try
             {
@@ -88,9 +87,9 @@ public virtual Response<StartCallRecordingResponse> StartRecording(CallLocator c
         /// <param name="content">content for recording.</param>
         /// <param name="channel">channel for recording.</param>
         /// <param name="format">format for recording.</param>
-        public virtual async Task<Response<StartCallRecordingResponse>> StartRecordingAsync(CallLocator callLocator, Uri recordingStateCallbackUri, RecordingContentType? content = null, RecordingChannelType? channel = null, RecordingFormatType? format = null, CancellationToken cancellationToken = default)
+        public virtual async Task<Response<RecordingStatusResult>> StartRecordingAsync(CallLocator callLocator, Uri recordingStateCallbackUri, RecordingContent? content = null, RecordingChannel? channel = null, RecordingFormat? format = null, CancellationToken cancellationToken = default)
         {
-            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecordingClient)}.{nameof(StartRecording)}");
+            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecording)}.{nameof(StartRecording)}");
             scope.Start();
             try
             {
@@ -115,9 +114,9 @@ public virtual async Task<Response<StartCallRecordingResponse>> StartRecordingAs
         /// </summary>
         /// <param name="recordingId">The recording id to get the state of.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
-        public virtual Response<GetCallRecordingStateResponse> GetRecordingState(string recordingId, CancellationToken cancellationToken = default)
+        public virtual Response<RecordingStatusResult> GetRecordingState(string recordingId, CancellationToken cancellationToken = default)
         {
-            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecordingClient)}.{nameof(GetRecordingState)}");
+            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecording)}.{nameof(GetRecordingState)}");
             scope.Start();
             try
             {
@@ -138,9 +137,9 @@ public virtual Response<GetCallRecordingStateResponse> GetRecordingState(string
         /// </summary>
         /// <param name="recordingId">The recording id to get the state of.</param>
         /// <param name="cancellationToken">The cancellation token.</param>
-        public virtual async Task<Response<GetCallRecordingStateResponse>> GetRecordingStateAsync(string recordingId, CancellationToken cancellationToken = default)
+        public virtual async Task<Response<RecordingStatusResult>> GetRecordingStateAsync(string recordingId, CancellationToken cancellationToken = default)
         {
-            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecordingClient)}.{nameof(GetRecordingState)}");
+            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecording)}.{nameof(GetRecordingState)}");
             scope.Start();
             try
             {
@@ -163,7 +162,7 @@ public virtual async Task<Response<GetCallRecordingStateResponse>> GetRecordingS
         /// <param name="cancellationToken">The cancellation token.</param>
         public virtual Response StopRecording(string recordingId, CancellationToken cancellationToken = default)
         {
-            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecordingClient)}.{nameof(StopRecording)}");
+            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecording)}.{nameof(StopRecording)}");
             scope.Start();
             try
             {
@@ -186,7 +185,7 @@ public virtual Response StopRecording(string recordingId, CancellationToken canc
         /// <param name="cancellationToken">The cancellation token.</param>
         public virtual async Task<Response> StopRecordingAsync(string recordingId, CancellationToken cancellationToken = default)
         {
-            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecordingClient)}.{nameof(StopRecording)}");
+            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecording)}.{nameof(StopRecording)}");
             scope.Start();
             try
             {
@@ -209,7 +208,7 @@ public virtual async Task<Response> StopRecordingAsync(string recordingId, Cance
         /// <param name="cancellationToken">The cancellation token.</param>
         public virtual async Task<Response> PauseRecordingAsync(string recordingId, CancellationToken cancellationToken = default)
         {
-            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecordingClient)}.{nameof(PauseRecording)}");
+            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecording)}.{nameof(PauseRecording)}");
             scope.Start();
             try
             {
@@ -232,7 +231,7 @@ public virtual async Task<Response> PauseRecordingAsync(string recordingId, Canc
         /// <param name="cancellationToken">The cancellation token.</param>
         public virtual Response PauseRecording(string recordingId, CancellationToken cancellationToken = default)
         {
-            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecordingClient)}.{nameof(PauseRecording)}");
+            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecording)}.{nameof(PauseRecording)}");
             scope.Start();
             try
             {
@@ -255,7 +254,7 @@ public virtual Response PauseRecording(string recordingId, CancellationToken can
         /// <param name="cancellationToken">The cancellation token.</param>
         public virtual async Task<Response> ResumeRecordingAsync(string recordingId, CancellationToken cancellationToken = default)
         {
-            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecordingClient)}.{nameof(ResumeRecording)}");
+            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecording)}.{nameof(ResumeRecording)}");
             scope.Start();
             try
             {
@@ -278,7 +277,7 @@ public virtual async Task<Response> ResumeRecordingAsync(string recordingId, Can
         /// <param name="cancellationToken">The cancellation token.</param>
         public virtual Response ResumeRecording(string recordingId, CancellationToken cancellationToken = default)
         {
-            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecordingClient)}.{nameof(ResumeRecording)}");
+            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecording)}.{nameof(ResumeRecording)}");
             scope.Start();
             try
             {
@@ -511,7 +510,7 @@ public virtual async Task<Response> DownloadToAsync(Uri sourceEndpoint, string d
         /// </remarks>
         public virtual Response DeleteRecording(Uri deleteEndpoint, CancellationToken cancellationToken = default)
         {
-            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecordingClient)}.{nameof(DeleteRecording)}");
+            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecording)}.{nameof(DeleteRecording)}");
             scope.Start();
             try
             {
@@ -554,7 +553,7 @@ public virtual Response DeleteRecording(Uri deleteEndpoint, CancellationToken ca
         /// </remarks>
         public virtual async Task<Response> DeleteRecordingAsync(Uri deleteEndpoint, CancellationToken cancellationToken = default)
         {
-            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecordingClient)}.{nameof(DeleteRecording)}");
+            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CallRecording)}.{nameof(DeleteRecording)}");
             scope.Start();
             try
             {