Partition Key Feed Range Bug (Azure#40677)

* Feed range bug fix

* add test and move logic to overlaps

* fix cspell

* reacting to comments

* reacting to comments

* reacting to comments

* fix tests

* fix tests

Author: tvaron3

sdk/cosmos/azure-cosmos/CHANGELOG.md

@@ -9,6 +9,7 @@
 #### Breaking Changes
 
 #### Bugs Fixed
+* Fixed bug where change feed requests would not respect the partition key filter. See [PR 40677](https://github.com/Azure/azure-sdk-for-python/pull/40677).
 * Fixed how the environment variables in the sdk are parsed. See [PR 40303](https://github.com/Azure/azure-sdk-for-python/pull/40303).
 * Fixed health check to check the first write region when it is not specified in the preferred regions. See [PR 40588](https://github.com/Azure/azure-sdk-for-python/pull/40588).
 * Fixed bug where writes were being retried for 5xx status codes for patch and replace. See [PR 40672](https://github.com/Azure/azure-sdk-for-python/pull/40672).

sdk/cosmos/azure-cosmos/azure/cosmos/_routing/routing_range.py

@@ -50,8 +50,8 @@ def __init__(self, range_min, range_max, isMinInclusive, isMaxInclusive):
         if range_max is None:
             raise ValueError("max is missing")
 
-        self.min = range_min
-        self.max = range_max
+        self.min = range_min.upper()
+        self.max = range_max.upper()
         self.isMinInclusive = isMinInclusive
         self.isMaxInclusive = isMaxInclusive
 
@@ -67,8 +67,8 @@ def contains(self, value):
     @classmethod
     def PartitionKeyRangeToRange(cls, partition_key_range):
         self = cls(
-            partition_key_range[PartitionKeyRange.MinInclusive],
-            partition_key_range[PartitionKeyRange.MaxExclusive],
+            partition_key_range[PartitionKeyRange.MinInclusive].upper(),
+            partition_key_range[PartitionKeyRange.MaxExclusive].upper(),
             True,
             False,
         )
@@ -77,8 +77,8 @@ def PartitionKeyRangeToRange(cls, partition_key_range):
     @classmethod
     def ParseFromDict(cls, range_as_dict):
         self = cls(
-            range_as_dict[Range.MinPath],
-            range_as_dict[Range.MaxPath],
+            range_as_dict[Range.MinPath].upper(),
+            range_as_dict[Range.MaxPath].upper(),
             range_as_dict[Range.IsMinInclusivePath],
             range_as_dict[Range.IsMaxInclusivePath],
         )
@@ -125,7 +125,7 @@ def add_to_effective_partition_key(self, effective_partition_key: str, value: in
                     break
                 byte_array[i] = 255
 
-        return binascii.hexlify(byte_array).decode()
+        return binascii.hexlify(byte_array).decode().upper()
 
     def hex_binary_to_byte_array(self, hex_binary_string: str):
         if hex_binary_string is None:
@@ -180,7 +180,7 @@ def __eq__(self, other):
         )
 
     @staticmethod
-    def _compare_helper(a, b):
+    def _compare_helper(a: str, b: str):
         # python 3 compatible
         return (a > b) - (a < b)
 

sdk/cosmos/azure-cosmos/tests/routing/test_collection_routing_map.py

@@ -84,6 +84,21 @@ def get_range_id(r):
         expectedRanges = ['2', '1', '3', '6', '7', '5']
         self.assertEqual(expectedRanges, list(map(get_range_id, filteredRanges)))
 
+    def test_point_range_mapping(self):
+        partition_key_ranges = [{u'id': u'0', u'minInclusive': u'', u'maxExclusive': u'1FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF'},
+                                {u'id': u'1', u'minInclusive': u'1FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF', u'maxExclusive': u'FF'}]
+        partitionRangeWithInfo = [(r, True) for r in partition_key_ranges]
+        expected_partition_key_range = routing_range.Range("", "1FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF", True, False)
+        pk_range = routing_range.Range("1EC0C2CBE45DBC919CF2B65D399C2673", "1EC0C2CBE45DBC919CF2B65D399C2673", True, True)
+        normalized_pk_range = pk_range.to_normalized_range()
+
+        collection_routing_map = CollectionRoutingMap.CompleteRoutingMap(partitionRangeWithInfo, 'sample collection id')
+        overlapping_partition_key_ranges = collection_routing_map.get_overlapping_ranges(normalized_pk_range)
+
+        # a partition key feed range should only map to one physical partition
+        self.assertEqual(1, len(overlapping_partition_key_ranges))
+        self.assertEqual(expected_partition_key_range, routing_range.Range.PartitionKeyRangeToRange(overlapping_partition_key_ranges[0]))
+
     def test_collection_routing_map(self):
         Id = 'id'
         MinInclusive = 'minInclusive'

sdk/cosmos/azure-cosmos/tests/test_feed_range.py

@@ -41,7 +41,7 @@ def setup():
                        True),
                       (Range("3F", "7F", False, True),
                        Range("3F", "7F", True, True),
-                       False),
+                       True),
                       (Range("3F", "7F", True, False),
                        Range("3F", "7F", True, True),
                        False),