[Storage] [STG 97] GA API Views Feedback (Azure#39891)

Author: weirongw23-msft

sdk/storage/azure-storage-file-share/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "python",
   "TagPrefix": "python/storage/azure-storage-file-share",
-  "Tag": "python/storage/azure-storage-file-share_28d3d8db00"
+  "Tag": "python/storage/azure-storage-file-share_adb38dd356"
 }

sdk/storage/azure-storage-file-share/azure/storage/fileshare/_file_client.py

@@ -725,13 +725,13 @@ def start_copy_from_url(self, source_url: str, **kwargs: Any) -> Dict[str, Any]:
             NFS only. The owning group of the file.
         :keyword str file_mode:
             NFS only. The file mode of the file.
-        :keyword mode_copy_mode:
+        :keyword file_mode_copy_mode:
             NFS only. Applicable only when the copy source is a File. Determines the copy behavior
             of the mode bits of the file. Possible values are:
 
             source - The mode on the destination file is copied from the source file.
             override - The mode on the destination file is determined via the file_mode keyword.
-        :paramtype mode_copy_mode: Literal['source', 'override']
+        :paramtype file_mode_copy_mode: Literal['source', 'override']
         :keyword owner_copy_mode:
             NFS only. Applicable only when the copy source is a File. Determines the copy behavior
             of the owner and group of the file. Possible values are:
@@ -763,7 +763,7 @@ def start_copy_from_url(self, source_url: str, **kwargs: Any) -> Dict[str, Any]:
         owner = kwargs.pop('owner', None)
         group = kwargs.pop('group', None)
         file_mode = kwargs.pop('file_mode', None)
-        file_mode_copy_mode = kwargs.pop('mode_copy_mode', None)
+        file_mode_copy_mode = kwargs.pop('file_mode_copy_mode', None)
         file_owner_copy_mode = kwargs.pop('owner_copy_mode', None)
         headers = kwargs.pop('headers', {})
         headers.update(add_metadata_headers(metadata))
@@ -1701,14 +1701,14 @@ def close_all_handles(self, **kwargs: Any) -> Dict[str, int]:
         }
 
     @distributed_trace
-    def create_hard_link(
+    def create_hardlink(
         self, target: str,
         *,
         lease: Optional[Union[ShareLeaseClient, str]] = None,
         timeout: Optional[int] = None,
         **kwargs: Any
     ) -> Dict[str, Any]:
-        """NFS only. Create a hard link to the file specified by path.
+        """NFS only. Creates a hard link to the file specified by path.
 
         :param str target:
             Specifies the path of the target file to which the link will be created, up to 2 KiB in length.

sdk/storage/azure-storage-file-share/azure/storage/fileshare/aio/_file_client_async.py

@@ -720,13 +720,13 @@ async def start_copy_from_url(self, source_url: str, **kwargs: Any) -> Dict[str,
             NFS only. The owning group of the file.
         :keyword str file_mode:
             NFS only. The file mode of the file.
-        :keyword mode_copy_mode:
+        :keyword file_mode_copy_mode:
             NFS only. Applicable only when the copy source is a File. Determines the copy behavior
             of the mode bits of the file. Possible values are:
 
             source - The mode on the destination file is copied from the source file.
             override - The mode on the destination file is determined via the file_mode keyword.
-        :paramtype mode_copy_mode: Literal['source', 'override']
+        :paramtype file_mode_copy_mode: Literal['source', 'override']
         :keyword owner_copy_mode:
             NFS only. Applicable only when the copy source is a File. Determines the copy behavior
             of the owner and group of the file. Possible values are:
@@ -758,7 +758,7 @@ async def start_copy_from_url(self, source_url: str, **kwargs: Any) -> Dict[str,
         owner = kwargs.pop('owner', None)
         group = kwargs.pop('group', None)
         file_mode = kwargs.pop('file_mode', None)
-        file_mode_copy_mode = kwargs.pop('mode_copy_mode', None)
+        file_mode_copy_mode = kwargs.pop('file_mode_copy_mode', None)
         file_owner_copy_mode = kwargs.pop('owner_copy_mode', None)
         headers = kwargs.pop("headers", {})
         headers.update(add_metadata_headers(metadata))
@@ -1702,14 +1702,14 @@ async def close_all_handles(self, **kwargs: Any) -> Dict[str, int]:
         }
 
     @distributed_trace_async
-    async def create_hard_link(
+    async def create_hardlink(
         self, target: str,
         *,
         lease: Optional[Union[ShareLeaseClient, str]] = None,
         timeout: Optional[int] = None,
         **kwargs: Any
     ) -> Dict[str, Any]:
-        """NFS only. Create a hard link to the file specified by path.
+        """NFS only. Creates a hard link to the file specified by path.
 
         :param str target:
             Specifies the path of the target file to which the link will be created, up to 2 KiB in length.

sdk/storage/azure-storage-file-share/tests/test_nfs.py

@@ -181,7 +181,7 @@ def test_download_and_copy_file(self, **kwargs: Any):
         )
         copy = new_client_source_copy.start_copy_from_url(
             file_client.url,
-            mode_copy_mode='source',
+            file_mode_copy_mode='source',
             owner_copy_mode='source'
         )
         self._assert_copy(copy)
@@ -212,7 +212,7 @@ def test_download_and_copy_file(self, **kwargs: Any):
             owner=override_owner,
             group=override_group,
             file_mode=override_file_mode,
-            mode_copy_mode='override',
+            file_mode_copy_mode='override',
             owner_copy_mode='override'
         )
         self._assert_copy(copy)
@@ -221,7 +221,7 @@ def test_download_and_copy_file(self, **kwargs: Any):
 
     @FileSharePreparer()
     @recorded_by_proxy
-    def test_create_hard_link(self, **kwargs: Any):
+    def test_create_hardlink(self, **kwargs: Any):
         premium_storage_file_account_name = kwargs.pop("premium_storage_file_account_name")
 
         self._setup(premium_storage_file_account_name)
@@ -235,7 +235,7 @@ def test_create_hard_link(self, **kwargs: Any):
         hard_link_file_name = self._get_file_name('file2')
         hard_link_file_client = directory_client.get_file_client(hard_link_file_name)
 
-        resp = hard_link_file_client.create_hard_link(target=f"{directory_name}/{source_file_name}")
+        resp = hard_link_file_client.create_hardlink(target=f"{directory_name}/{source_file_name}")
 
         assert resp is not None
         assert resp['file_file_type'] == 'Regular'
@@ -255,7 +255,7 @@ def test_create_hard_link(self, **kwargs: Any):
 
     @FileSharePreparer()
     @recorded_by_proxy
-    def test_create_hard_link_error(self, **kwargs: Any):
+    def test_create_hardlink_error(self, **kwargs: Any):
         premium_storage_file_account_name = kwargs.pop("premium_storage_file_account_name")
 
         self._setup(premium_storage_file_account_name)
@@ -269,6 +269,6 @@ def test_create_hard_link_error(self, **kwargs: Any):
         hard_link_file_client = directory_client.get_file_client(hard_link_file_name)
 
         with pytest.raises(ResourceNotFoundError) as e:
-            hard_link_file_client.create_hard_link(target=f"{directory_name}/{source_file_name}")
+            hard_link_file_client.create_hardlink(target=f"{directory_name}/{source_file_name}")
 
         assert 'ParentNotFound' in e.value.args[0]

sdk/storage/azure-storage-file-share/tests/test_nfs_async.py

@@ -193,7 +193,7 @@ async def test_download_and_copy_file(self, **kwargs: Any):
         )
         copy = await new_client_source_copy.start_copy_from_url(
             file_client.url,
-            mode_copy_mode='source',
+            file_mode_copy_mode='source',
             owner_copy_mode='source'
         )
         self._assert_copy(copy)
@@ -224,7 +224,7 @@ async def test_download_and_copy_file(self, **kwargs: Any):
             owner=override_owner,
             group=override_group,
             file_mode=override_file_mode,
-            mode_copy_mode='override',
+            file_mode_copy_mode='override',
             owner_copy_mode='override'
         )
         self._assert_copy(copy)
@@ -233,7 +233,7 @@ async def test_download_and_copy_file(self, **kwargs: Any):
 
     @FileSharePreparer()
     @recorded_by_proxy_async
-    async def test_create_hard_link(self, **kwargs: Any):
+    async def test_create_hardlink(self, **kwargs: Any):
         premium_storage_file_account_name = kwargs.pop("premium_storage_file_account_name")
 
         await self._setup(premium_storage_file_account_name)
@@ -247,7 +247,7 @@ async def test_create_hard_link(self, **kwargs: Any):
         hard_link_file_name = self._get_file_name('file2')
         hard_link_file_client = directory_client.get_file_client(hard_link_file_name)
 
-        resp = await hard_link_file_client.create_hard_link(target=f"{directory_name}/{source_file_name}")
+        resp = await hard_link_file_client.create_hardlink(target=f"{directory_name}/{source_file_name}")
 
         assert resp is not None
         assert resp['file_file_type'] == 'Regular'
@@ -267,7 +267,7 @@ async def test_create_hard_link(self, **kwargs: Any):
 
     @FileSharePreparer()
     @recorded_by_proxy_async
-    async def test_create_hard_link_error(self, **kwargs: Any):
+    async def test_create_hardlink_error(self, **kwargs: Any):
         premium_storage_file_account_name = kwargs.pop("premium_storage_file_account_name")
 
         await self._setup(premium_storage_file_account_name)
@@ -281,6 +281,6 @@ async def test_create_hard_link_error(self, **kwargs: Any):
         hard_link_file_client = directory_client.get_file_client(hard_link_file_name)
 
         with pytest.raises(ResourceNotFoundError) as e:
-            await hard_link_file_client.create_hard_link(target=f"{directory_name}/{source_file_name}")
+            await hard_link_file_client.create_hardlink(target=f"{directory_name}/{source_file_name}")
 
         assert 'ParentNotFound' in e.value.args[0]