Skip to content

Commit 27d295a

Browse files
authored
Users/singankit/rogue evaluator fix (Azure#41317)
* RogueType to be compatible with str * Adding tests * Revert test changes
1 parent e479c2d commit 27d295a

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_rouge/_rouge.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# ---------------------------------------------------------
44
from enum import Enum
55

6-
from typing import Dict
6+
from typing import Dict, Union
77
from typing_extensions import overload, override
88

99
from azure.ai.evaluation._vendor.rouge_score import rouge_scorer
@@ -12,7 +12,7 @@
1212
import math
1313

1414

15-
class RougeType(Enum):
15+
class RougeType(str, Enum):
1616
"""
1717
Enumeration of ROUGE (Recall-Oriented Understudy for Gisting Evaluation) types.
1818
"""
@@ -179,8 +179,8 @@ async def _do_eval(self, eval_input: Dict) -> Dict[str, float]:
179179
"""
180180
ground_truth = eval_input["ground_truth"]
181181
response = eval_input["response"]
182-
scorer = rouge_scorer.RougeScorer(rouge_types=[self._rouge_type.value])
183-
metrics = scorer.score(ground_truth, response)[self._rouge_type.value]
182+
scorer = rouge_scorer.RougeScorer(rouge_types=[self._rouge_type])
183+
metrics = scorer.score(ground_truth, response)[self._rouge_type]
184184
binary_results = {
185185
"rouge_precision_result": False,
186186
"rouge_recall_result": False,

sdk/evaluation/azure-ai-evaluation/tests/e2etests/test_builtin_evaluators.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,13 @@ def test_math_evaluator_meteor_score(self):
8383
(RougeType.ROUGE_4),
8484
(RougeType.ROUGE_5),
8585
(RougeType.ROUGE_L),
86+
# TODO: Enable them in a future PR
87+
# (RougeType.ROUGE_1.value),
88+
# (RougeType.ROUGE_2.value),
89+
# (RougeType.ROUGE_3.value),
90+
# (RougeType.ROUGE_4.value),
91+
# (RougeType.ROUGE_5.value),
92+
# (RougeType.ROUGE_L.value),
8693
],
8794
)
8895
def test_math_evaluator_rouge_score(self, rouge_type):

0 commit comments

Comments
 (0)