Skip to content

Commit 2e55907

Browse files
[Storage] Fix Queue account SAS generation with latest service version (Azure#23982)
1 parent 1032245 commit 2e55907

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

sdk/storage/azure-storage-queue/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
- Added support for `max_messages` in `receive_messages()` to specify the maximum number of messages to receive from the queue.
77

88
### Other Changes
9+
- Updated SAS token generation to use the latest supported service version by default. Moving to the latest version
10+
also included a change to how account SAS is generated to reflect a change made to the service in SAS generation for
11+
service version 2020-12-06.
912
- Updated documentation for `receive_messages()` to explain iterator behavior and life-cycle.
1013
- Added a sample to `queue_samples_message.py` (and async-equivalent) showcasing the use of `max_messages` in `receive_messages()`.
1114

sdk/storage/azure-storage-queue/azure/storage/queue/_shared/shared_access_signature.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,9 @@ def get_value_to_append(query):
211211
get_value_to_append(QueryStringConstants.SIGNED_EXPIRY) +
212212
get_value_to_append(QueryStringConstants.SIGNED_IP) +
213213
get_value_to_append(QueryStringConstants.SIGNED_PROTOCOL) +
214-
get_value_to_append(QueryStringConstants.SIGNED_VERSION))
214+
get_value_to_append(QueryStringConstants.SIGNED_VERSION) +
215+
'\n' # Signed Encryption Scope - always empty for queue
216+
)
215217

216218
self._add_query(QueryStringConstants.SIGNED_SIGNATURE,
217219
sign_string(account_key, string_to_sign))

sdk/storage/azure-storage-queue/tests/test_queue_api_version.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
QueueServiceClient,
1111
QueueClient
1212
)
13-
from azure.storage.queue._serialize import _SUPPORTED_API_VERSIONS
13+
from azure.storage.queue._shared.constants import X_MS_VERSION
1414
from devtools_testutils.storage import StorageTestCase
1515

1616
# ------------------------------------------------------------------------------
@@ -19,7 +19,7 @@ class StorageClientTest(StorageTestCase):
1919
def setUp(self):
2020
super(StorageClientTest, self).setUp()
2121
self.api_version_1 = "2019-02-02"
22-
self.api_version_2 = _SUPPORTED_API_VERSIONS[-1]
22+
self.api_version_2 = X_MS_VERSION
2323

2424
# --Test Cases--------------------------------------------------------------
2525

sdk/storage/azure-storage-queue/tests/test_queue_api_version_async.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
QueueServiceClient,
1414
QueueClient
1515
)
16-
from azure.storage.queue._serialize import _SUPPORTED_API_VERSIONS
16+
from azure.storage.queue._shared.constants import X_MS_VERSION
1717
from devtools_testutils.storage.aio import AsyncStorageTestCase
1818

1919
# ------------------------------------------------------------------------------
@@ -22,7 +22,7 @@ class StorageClientTest(AsyncStorageTestCase):
2222
def setUp(self):
2323
super(StorageClientTest, self).setUp()
2424
self.api_version_1 = "2019-02-02"
25-
self.api_version_2 = _SUPPORTED_API_VERSIONS[-1]
25+
self.api_version_2 = X_MS_VERSION
2626

2727
# --Test Cases--------------------------------------------------------------
2828

0 commit comments

Comments
 (0)