Skip to content

Commit 2f06050

Browse files
authored
Update autorest.python to 6.2.1 for new feature --generate-sample (Azure#26940)
* Update swagger_to_sdk_config_autorest.json * Update swagger_to_sdk_config_autorest.json * Update swagger_to_sdk_config_autorest.json * Update setup.py * optimize dependency * optimize dependency * optimize dependency * optimize dependency
1 parent ccaaea6 commit 2f06050

File tree

3 files changed

+27
-22
lines changed

3 files changed

+27
-22
lines changed

scripts/auto_release/main.py

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -379,17 +379,21 @@ def check_changelog_file(self):
379379
self.edit_changelog()
380380

381381
@staticmethod
382-
def get_need_dependency():
382+
def get_need_dependency() -> List[str]:
383383
template_path = Path('tools/azure-sdk-tools/packaging_tools/templates/setup.py')
384+
items = ["msrest>", "azure-mgmt-core", "typing_extensions"]
384385
with open(template_path, 'r') as fr:
385386
content = fr.readlines()
386-
for line in content:
387-
if 'msrest>' in line:
388-
target_msrest = line.strip().strip(',').strip('\'')
389-
yield target_msrest
390-
if 'azure-mgmt-core' in line:
391-
target_mgmt_core = line.strip().strip(',').strip('\'')
392-
yield target_mgmt_core
387+
dependencies = []
388+
for i in range(len(content)):
389+
if "install_requires" not in content[i]:
390+
continue
391+
for j in range(i, len(content)):
392+
for item in items:
393+
if item in content[j]:
394+
dependencies.append(content[j].strip().strip(',').strip('\"'))
395+
break
396+
return dependencies
393397

394398
@staticmethod
395399
def insert_line_num(content: List[str]) -> int:
@@ -404,24 +408,22 @@ def insert_line_num(content: List[str]) -> int:
404408
def check_ci_file_proc(self, dependency: str):
405409
def edit_ci_file(content: List[str]):
406410
new_line = f'#override azure-mgmt-{self.package_name} {dependency}'
407-
dependency_name = dependency.split('>')[0]
411+
dependency_name = re.compile("[a-zA-Z-_]*").findall(dependency)[0]
408412
for i in range(len(content)):
409413
if new_line in content[i]:
410414
return
411415
if f'azure-mgmt-{self.package_name} {dependency_name}' in content[i]:
412416
content[i] = new_line + '\n'
413417
return
414-
prefix = '' if '\n' in content[-1] else '\n'
415-
content.insert(self.insert_line_num(content), prefix + new_line + '\n')
418+
content.insert(self.insert_line_num(content), new_line + '\n')
416419

417420
modify_file(str(Path('shared_requirements.txt')), edit_ci_file)
418421
print_exec('git add shared_requirements.txt')
419422

420423
def check_ci_file(self):
421-
# eg: target_msrest = 'msrest>=0.6.21', target_mgmt_core = 'azure-mgmt-core>=1.3.0,<2.0.0'
422-
target_msrest, target_mgmt_core = list(self.get_need_dependency())
423-
self.check_ci_file_proc(target_msrest)
424-
self.check_ci_file_proc(target_mgmt_core)
424+
# eg: 'msrest>=0.6.21', 'azure-mgmt-core>=1.3.0,<2.0.0'
425+
for item in self.get_need_dependency():
426+
self.check_ci_file_proc(item)
425427

426428
def check_dev_requirement(self):
427429
file = Path(f'sdk/{self.sdk_folder}/azure-mgmt-{self.package_name}/dev_requirements.txt')

swagger_to_sdk_config_autorest.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,12 @@
22
"meta": {
33
"autorest_options": {
44
"version": "3.9.2",
5-
"use": ["@autorest/python@6.1.11", "@autorest/[email protected]"],
5+
"use": ["@autorest/python@6.2.1", "@autorest/[email protected]"],
66
"python": "",
77
"sdkrel:python-sdks-folder": "./sdk/.",
8-
"version-tolerant": false
8+
"version-tolerant": false,
9+
"include-x-ms-examples-original-file": true,
10+
"generate-sample": true
911
},
1012
"advanced_options": {
1113
"create_sdk_pull_requests": true,

tools/azure-sdk-tools/packaging_tools/templates/setup.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,16 +70,17 @@
7070
'pytyped': ['py.typed'],
7171
},
7272
install_requires=[
73-
'msrest>=0.7.1',
73+
"msrest>=0.7.1",
7474
{%- if need_msrestazure %}
75-
'msrestazure>=0.4.32,<2.0.0',
75+
"msrestazure>=0.4.32,<2.0.0",
7676
{%- endif %}
77-
'azure-common~=1.1',
77+
"azure-common~=1.1",
7878
{%- if need_azurecore %}
79-
'azure-core>=1.24.0,<2.0.0',
79+
"azure-core>=1.24.0,<2.0.0",
8080
{%- endif %}
8181
{%- if need_azuremgmtcore %}
82-
'azure-mgmt-core>=1.3.2,<2.0.0',
82+
"azure-mgmt-core>=1.3.2,<2.0.0",
83+
"typing_extensions>=4.3.0; python_version<'3.8.0'",
8384
{%- endif %}
8485
],
8586
python_requires=">=3.7"

0 commit comments

Comments
 (0)