Skip to content

Commit 33efbeb

Browse files
authored
Share APIView Pins of pylint-guidelines-checker (Azure#24258)
* linting does NOT require the apistubgenpackage. given that it has a conflict with our pinned pylint (2.9.3) we will simply not introduce it to the linting dependency graph. instead we will simply pin * pin apistubgen requirements in a separate file
1 parent 79ffc05 commit 33efbeb

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

eng/apiview_reqs.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
api-stub-generator==0.3.1
2+
pylint-guidelines-checker==0.0.3

eng/tox/tox.ini

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ setenv =
8585
deps =
8686
{[base]deps}
8787
commands =
88-
{envbindir}/python -m pip install --index-url="https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/" pylint-guidelines-checker==0.0.2
88+
{envbindir}/python -m pip install pylint-guidelines-checker==0.0.3 --index-url="https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/"
8989
{envbindir}/python {toxinidir}/../../../eng/tox/create_package_and_install.py \
9090
-d {distdir} \
9191
-p {toxinidir} \
@@ -330,7 +330,7 @@ deps =
330330
{[base]deps}
331331
commands =
332332
# install API stub generator
333-
{envbindir}/python -m pip install api-stub-generator==0.3.1 --index-url="https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/"
333+
{envbindir}/python -m pip install -r {toxinidir}/../../../eng/apiview_reqs.txt --index-url="https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-python/pypi/simple/"
334334
{envbindir}/python -m pip freeze
335335
{envbindir}/python {toxinidir}/../../../eng/tox/run_apistubgen.py -t {toxinidir} -w {envtmpdir} {posargs}
336336

0 commit comments

Comments
 (0)