[Key Vault] Update default value of lifetime_actions (Azure#24070)

Author: mccoyp

sdk/keyvault/azure-keyvault-keys/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Release History
 
-## 4.5.1 (2022-04-19)
+## 4.5.1 (2022-04-18)
 
 ### Bugs Fixed
 - Fixed error that could occur when fetching a key rotation policy that has no defined

sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/_models.py

@@ -291,12 +291,14 @@ class KeyRotationLifetimeAction(object):
     :param action: The action that will be executed.
     :type action: ~azure.keyvault.keys.KeyRotationPolicyAction or str
 
-    :keyword str time_after_create: Time after creation to attempt the specified action, as an ISO 8601 duration.
+    :keyword time_after_create: Time after creation to attempt the specified action, as an ISO 8601 duration.
         For example, 90 days is "P90D". See `Wikipedia <https://wikipedia.org/wiki/ISO_8601#Durations>`_ for more
         information on ISO 8601 durations.
-    :keyword str time_before_expiry: Time before expiry to attempt the specified action, as an ISO 8601 duration.
+    :paramtype time_after_create: Optional[str]
+    :keyword time_before_expiry: Time before expiry to attempt the specified action, as an ISO 8601 duration.
         For example, 90 days is "P90D". See `Wikipedia <https://wikipedia.org/wiki/ISO_8601#Durations>`_ for more
         information on ISO 8601 durations.
+    :paramtype time_before_expiry: Optional[str]
     """
 
     def __init__(self, action, **kwargs):
@@ -319,30 +321,32 @@ def _from_generated(cls, lifetime_action):
 class KeyRotationPolicy(object):
     """The key rotation policy that belongs to a key.
 
-    :ivar str id: The identifier of the key rotation policy.
+    :ivar id: The identifier of the key rotation policy.
+    :vartype id: Optional[str]
     :ivar lifetime_actions: Actions that will be performed by Key Vault over the lifetime of a key.
     :vartype lifetime_actions: List[~azure.keyvault.keys.KeyRotationLifetimeAction]
-    :ivar str expires_in: The expiry time of the policy that will be applied on new key versions, defined as an ISO 8601
+    :ivar expires_in: The expiry time of the policy that will be applied on new key versions, defined as an ISO 8601
         duration. For example, 90 days is "P90D".  See `Wikipedia <https://wikipedia.org/wiki/ISO_8601#Durations>`_ for
         more information on ISO 8601 durations.
+    :vartype expires_in: Optional[str]
     :ivar created_on: When the policy was created, in UTC
-    :vartype created_on: ~datetime.datetime
+    :vartype created_on: Optional[~datetime.datetime]
     :ivar updated_on: When the policy was last updated, in UTC
-    :vartype updated_on: ~datetime.datetime
+    :vartype updated_on: Optional[~datetime.datetime]
     """
 
     def __init__(self, **kwargs):
         # type: (**Any) -> None
         self.id = kwargs.get("policy_id", None)
-        self.lifetime_actions = kwargs.get("lifetime_actions", None)
+        self.lifetime_actions = kwargs.get("lifetime_actions", [])
         self.expires_in = kwargs.get("expires_in", None)
         self.created_on = kwargs.get("created_on", None)
         self.updated_on = kwargs.get("updated_on", None)
 
     @classmethod
     def _from_generated(cls, policy):
         lifetime_actions = (
-            None
+            []
             if policy.lifetime_actions is None
             else [KeyRotationLifetimeAction._from_generated(action) for action in policy.lifetime_actions]  # pylint:disable=protected-access
         )

sdk/keyvault/azure-keyvault-keys/tests/test_key_client.py

@@ -21,6 +21,7 @@
     KeyRotationPolicyAction,
     KeyType,
 )
+from azure.keyvault.keys._generated.v7_3.models import KeyRotationPolicy as _KeyRotationPolicy
 import pytest
 from six import byte2int
 
@@ -754,3 +755,11 @@ def test_case_insensitive_key_type():
     assert KeyType("OCT") == KeyType.oct
     # KeyType with mixed-case value
     assert KeyType("oct-hsm") == KeyType.oct_hsm
+
+
+def test_empty_rotation_policy_actions():
+    """Regression test: make sure a KeyRotationPolicy can be created with a response that has None properties"""
+    generated_policy = _KeyRotationPolicy()
+    assert generated_policy.lifetime_actions is None
+    policy = KeyRotationPolicy._from_generated(generated_policy)
+    assert policy.lifetime_actions == []