Skip to content

Commit 486b171

Browse files
authored
[Cosmos] api review changes (Azure#31532)
* pythonify kwarg name * Update CHANGELOG.md
1 parent 8522b35 commit 486b171

File tree

7 files changed

+15
-14
lines changed

7 files changed

+15
-14
lines changed

sdk/cosmos/azure-cosmos/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#### Bugs Fixed
1111

1212
#### Other Changes
13+
* Renamed `response_continuation_token_limit_in_kb` to `continuation_token_limit` for GA. See [PR 31532](https://github.com/Azure/azure-sdk-for-python/pull/31532).
1314

1415
### 4.4.1b1 (2023-07-25)
1516

sdk/cosmos/azure-cosmos/azure/cosmos/aio/_container.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ def query_items(
320320
:keyword dict[str, str] initial_headers: Initial headers to be sent as part of the request.
321321
:keyword response_hook: A callable invoked with the response metadata.
322322
:paramtype response_hook: Callable[[Dict[str, str], AsyncItemPaged[Dict[str, Any]]], None]
323-
:keyword int response_continuation_token_limit_in_kb: **provisional keyword** The size limit in kb of the
323+
:keyword int continuation_token_limit: **provisional keyword** The size limit in kb of the
324324
response continuation token in the query response. Valid values are positive integers.
325325
A value of 0 is the same as not passing a value (default no limit).
326326
:keyword int max_integrated_cache_staleness_in_ms: The max cache staleness for the integrated cache in
@@ -369,9 +369,9 @@ def query_items(
369369
feed_options["maxIntegratedCacheStaleness"] = max_integrated_cache_staleness_in_ms
370370
correlated_activity_id = GenerateGuidId()
371371
feed_options["correlatedActivityId"] = correlated_activity_id
372-
response_continuation_token_limit_in_kb = kwargs.pop("response_continuation_token_limit_in_kb", None)
373-
if response_continuation_token_limit_in_kb is not None:
374-
feed_options["responseContinuationTokenLimitInKb"] = response_continuation_token_limit_in_kb
372+
continuation_token_limit = kwargs.pop("continuation_token_limit", None)
373+
if continuation_token_limit is not None:
374+
feed_options["responseContinuationTokenLimitInKb"] = continuation_token_limit
375375
if hasattr(response_hook, "clear"):
376376
response_hook.clear()
377377

sdk/cosmos/azure-cosmos/azure/cosmos/container.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ def query_items(
354354
:keyword str session_token: Token for use with Session consistency.
355355
:keyword dict[str,str] initial_headers: Initial headers to be sent as part of the request.
356356
:keyword Callable response_hook: A callable invoked with the response metadata.
357-
:keyword int response_continuation_token_limit_in_kb: **provisional keyword** The size limit in kb of the
357+
:keyword int continuation_token_limit: **provisional keyword** The size limit in kb of the
358358
response continuation token in the query response. Valid values are positive integers.
359359
A value of 0 is the same as not passing a value (default no limit).
360360
:keyword int max_integrated_cache_staleness_in_ms: The max cache staleness for the integrated cache in
@@ -399,9 +399,9 @@ def query_items(
399399
feed_options["maxIntegratedCacheStaleness"] = max_integrated_cache_staleness_in_ms
400400
correlated_activity_id = GenerateGuidId()
401401
feed_options["correlatedActivityId"] = correlated_activity_id
402-
response_continuation_token_limit_in_kb = kwargs.pop("response_continuation_token_limit_in_kb", None)
403-
if response_continuation_token_limit_in_kb is not None:
404-
feed_options["responseContinuationTokenLimitInKb"] = response_continuation_token_limit_in_kb
402+
continuation_token_limit = kwargs.pop("continuation_token_limit", None)
403+
if continuation_token_limit is not None:
404+
feed_options["responseContinuationTokenLimitInKb"] = continuation_token_limit
405405
if hasattr(response_hook, "clear"):
406406
response_hook.clear()
407407

sdk/cosmos/azure-cosmos/samples/document_management.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,11 +227,11 @@ def query_items_with_continuation_token_size_limit(container, doc_id):
227227
sales_order = get_sales_order(doc_id)
228228
container.create_item(body=sales_order)
229229

230-
# set response_continuation_token_limit_in_kb to 8 to limit size to 8KB
230+
# set continuation_token_limit to 8 to limit size to 8KB
231231
items = list(container.query_items(
232232
query="SELECT * FROM r",
233233
partition_key=doc_id,
234-
response_continuation_token_limit_in_kb=size_limit_in_kb
234+
continuation_token_limit=size_limit_in_kb
235235
))
236236

237237
print('Continuation Token size has been limited to {}KB.'.format(size_limit_in_kb))

sdk/cosmos/azure-cosmos/samples/document_management_async.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,11 +246,11 @@ async def query_items_with_continuation_token_size_limit(container, doc_id):
246246
sales_order = get_sales_order(doc_id)
247247
await container.create_item(body=sales_order)
248248

249-
# set response_continuation_token_limit_in_kb to 8 to limit size to 8KB
249+
# set continuation_token_limit to 8 to limit size to 8KB
250250
items = container.query_items(
251251
query="SELECT * FROM r",
252252
partition_key=doc_id,
253-
response_continuation_token_limit_in_kb=size_limit_in_kb
253+
continuation_token_limit=size_limit_in_kb
254254
)
255255

256256
print('Continuation Token size has been limited to {}KB.'.format(size_limit_in_kb))

sdk/cosmos/azure-cosmos/test/test_query.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -736,7 +736,7 @@ def test_continuation_token_size_limit_query(self):
736736
container.create_item(body=dict(pk='123', id=str(i), some_value=str(i % 3)))
737737
query = "Select * from c where c.some_value='2'"
738738
response_query = container.query_items(query, partition_key='123', max_item_count=100,
739-
response_continuation_token_limit_in_kb=1)
739+
continuation_token_limit=1)
740740
pager = response_query.by_page()
741741
pager.next()
742742
token = pager.continuation_token

sdk/cosmos/azure-cosmos/test/test_query_async.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -733,7 +733,7 @@ async def test_continuation_token_size_limit_query(self):
733733
await container.create_item(body=dict(pk='123', id=str(i), some_value=str(i % 3)))
734734
query = "Select * from c where c.some_value='2'"
735735
response_query = container.query_items(query, partition_key='123', max_item_count=100,
736-
response_continuation_token_limit_in_kb=1)
736+
continuation_token_limit=1)
737737
pager = response_query.by_page()
738738
await pager.__anext__()
739739
token = pager.continuation_token

0 commit comments

Comments
 (0)