Skip to content

Commit 4a318f7

Browse files
authored
[Key Vault] Update unnecessary version-specific testing decorators (Azure#30019)
1 parent 37a14a4 commit 4a318f7

File tree

9 files changed

+33
-51
lines changed

9 files changed

+33
-51
lines changed

sdk/keyvault/azure-keyvault-administration/tests/test_settings_client.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,19 @@
44
# ------------------------------------
55
import pytest
66

7-
from azure.keyvault.administration import ApiVersion, KeyVaultSetting, KeyVaultSettingsClient, KeyVaultSettingType
7+
from azure.keyvault.administration import KeyVaultSetting, KeyVaultSettingsClient, KeyVaultSettingType
8+
from azure.keyvault.administration._internal.client_base import DEFAULT_VERSION
89

910
from devtools_testutils import recorded_by_proxy
1011

1112
from _shared.test_case import KeyVaultTestCase
1213
from _test_case import KeyVaultSettingsClientPreparer, get_decorator
1314

14-
only_7_4 = get_decorator(api_versions=[ApiVersion.V7_4])
15+
only_latest = get_decorator(api_versions=[DEFAULT_VERSION])
1516

1617

1718
class TestSettings(KeyVaultTestCase):
18-
@pytest.mark.parametrize("api_version", only_7_4)
19+
@pytest.mark.parametrize("api_version", only_latest)
1920
@KeyVaultSettingsClientPreparer()
2021
@recorded_by_proxy
2122
def test_list_settings(self, client: KeyVaultSettingsClient, **kwargs):
@@ -24,7 +25,7 @@ def test_list_settings(self, client: KeyVaultSettingsClient, **kwargs):
2425
for setting in default_settings:
2526
assert setting.name and setting.setting_type and setting.value is not None
2627

27-
@pytest.mark.parametrize("api_version", only_7_4)
28+
@pytest.mark.parametrize("api_version", only_latest)
2829
@KeyVaultSettingsClientPreparer()
2930
@recorded_by_proxy
3031
def test_update_settings(self, client: KeyVaultSettingsClient, **kwargs):

sdk/keyvault/azure-keyvault-administration/tests/test_settings_client_async.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,20 @@
33
# Licensed under the MIT License.
44
# ------------------------------------
55
import pytest
6-
from azure.keyvault.administration import ApiVersion, KeyVaultSetting, KeyVaultSettingType
6+
from azure.keyvault.administration import KeyVaultSetting, KeyVaultSettingType
77
from azure.keyvault.administration.aio import KeyVaultSettingsClient
8+
from azure.keyvault.administration._internal.client_base import DEFAULT_VERSION
89
from devtools_testutils.aio import recorded_by_proxy_async
910

1011
from _async_test_case import KeyVaultSettingsClientPreparer, get_decorator
1112
from _shared.test_case_async import KeyVaultTestCase
1213

13-
only_7_4 = get_decorator(api_versions=[ApiVersion.V7_4])
14+
only_latest = get_decorator(api_versions=[DEFAULT_VERSION])
1415

1516

1617
class TestSettings(KeyVaultTestCase):
1718
@pytest.mark.asyncio
18-
@pytest.mark.parametrize("api_version", only_7_4)
19+
@pytest.mark.parametrize("api_version", only_latest)
1920
@KeyVaultSettingsClientPreparer()
2021
@recorded_by_proxy_async
2122
async def test_list_settings(self, client: KeyVaultSettingsClient, **kwargs):
@@ -28,7 +29,7 @@ async def test_list_settings(self, client: KeyVaultSettingsClient, **kwargs):
2829
assert setting.name and setting.setting_type and setting.value is not None
2930

3031
@pytest.mark.asyncio
31-
@pytest.mark.parametrize("api_version", only_7_4)
32+
@pytest.mark.parametrize("api_version", only_latest)
3233
@KeyVaultSettingsClientPreparer()
3334
@recorded_by_proxy_async
3435
async def test_update_settings(self, client: KeyVaultSettingsClient, **kwargs):

sdk/keyvault/azure-keyvault-keys/assets.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"AssetsRepo": "Azure/azure-sdk-assets",
33
"AssetsRepoPrefixPath": "python",
44
"TagPrefix": "python/keyvault/azure-keyvault-keys",
5-
"Tag": "python/keyvault/azure-keyvault-keys_c6e71da583"
5+
"Tag": "python/keyvault/azure-keyvault-keys_19356f3a5b"
66
}

sdk/keyvault/azure-keyvault-keys/tests/test_crypto_client.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,7 @@
1919
from azure.core.exceptions import AzureError, HttpResponseError
2020
from azure.core.pipeline.policies import SansIOHTTPPolicy
2121
from azure.core.rest import HttpRequest
22-
from azure.keyvault.keys import (
23-
ApiVersion,
24-
JsonWebKey,
25-
KeyCurveName,
26-
KeyOperation,
27-
KeyVaultKey,
28-
)
22+
from azure.keyvault.keys import JsonWebKey, KeyCurveName, KeyOperation, KeyVaultKey
2923
from azure.keyvault.keys.crypto import (
3024
CryptographyClient,
3125
EncryptionAlgorithm,
@@ -46,7 +40,6 @@
4640
NO_GET = Permissions(keys=[p.value for p in KeyPermissions if p.value != "get"])
4741

4842
all_api_versions = get_decorator()
49-
only_7_4_hsm = get_decorator(only_hsm=True, api_versions=[ApiVersion.V7_4])
5043
only_hsm = get_decorator(only_hsm=True)
5144
only_vault_latest = get_decorator(only_vault=True, api_versions=[DEFAULT_VERSION])
5245
no_get = get_decorator(permissions=NO_GET)

sdk/keyvault/azure-keyvault-keys/tests/test_crypto_client_async.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,7 @@
1313
from azure.core.exceptions import AzureError, HttpResponseError
1414
from azure.core.pipeline.policies import SansIOHTTPPolicy
1515
from azure.core.rest import HttpRequest
16-
from azure.keyvault.keys import (
17-
ApiVersion,
18-
JsonWebKey,
19-
KeyCurveName,
20-
KeyOperation,
21-
KeyVaultKey,
22-
)
16+
from azure.keyvault.keys import JsonWebKey, KeyCurveName, KeyOperation, KeyVaultKey
2317
from azure.keyvault.keys.crypto._providers import NoLocalCryptography, get_local_cryptography_provider
2418
from azure.keyvault.keys.crypto.aio import (
2519
CryptographyClient,
@@ -43,7 +37,6 @@
4337
NO_GET = Permissions(keys=[p.value for p in KeyPermissions if p.value != "get"])
4438

4539
all_api_versions = get_decorator(is_async=True)
46-
only_7_4_hsm = get_decorator(only_hsm=True, api_versions=[ApiVersion.V7_4])
4740
only_hsm = get_decorator(only_hsm=True, is_async=True)
4841
only_vault_latest = get_decorator(only_vault=True, is_async=True, api_versions=[DEFAULT_VERSION])
4942
no_get = get_decorator(is_async=True, permissions=NO_GET)

sdk/keyvault/azure-keyvault-keys/tests/test_key_client.py

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
from azure.core.pipeline.policies import SansIOHTTPPolicy
1515
from azure.core.rest import HttpRequest
1616
from azure.keyvault.keys import (
17-
ApiVersion,
1817
JsonWebKey,
1918
KeyClient,
2019
KeyReleasePolicy,
@@ -35,10 +34,9 @@
3534

3635
all_api_versions = get_decorator()
3736
only_hsm = get_decorator(only_hsm=True)
38-
only_hsm_7_3 = get_decorator(only_hsm=True, api_versions=[ApiVersion.V7_3])
37+
only_hsm_latest = get_decorator(only_hsm=True, api_versions=[DEFAULT_VERSION])
3938
only_vault_latest = get_decorator(only_vault=True, api_versions=[DEFAULT_VERSION])
40-
only_vault_7_3 = get_decorator(only_vault=True, api_versions=[ApiVersion.V7_3])
41-
only_7_3 = get_decorator(api_versions=[ApiVersion.V7_3])
39+
only_latest = get_decorator(api_versions=[DEFAULT_VERSION])
4240
logging_enabled = get_decorator(logging_enable=True)
4341
logging_disabled = get_decorator(logging_enable=False)
4442

@@ -496,7 +494,7 @@ def test_logging_disabled(self, client, is_hsm, **kwargs):
496494

497495
mock_handler.close()
498496

499-
@pytest.mark.parametrize("api_version,is_hsm",only_hsm_7_3)
497+
@pytest.mark.parametrize("api_version,is_hsm",only_hsm_latest)
500498
@KeysClientPreparer()
501499
@recorded_by_proxy
502500
def test_get_random_bytes(self, client, **kwargs):
@@ -512,7 +510,7 @@ def test_get_random_bytes(self, client, **kwargs):
512510
assert all(random_bytes != rb for rb in generated_random_bytes)
513511
generated_random_bytes.append(random_bytes)
514512

515-
@pytest.mark.parametrize("api_version,is_hsm",only_7_3)
513+
@pytest.mark.parametrize("api_version,is_hsm",only_latest)
516514
@KeysClientPreparer()
517515
@recorded_by_proxy
518516
def test_key_release(self, client, **kwargs):
@@ -535,7 +533,7 @@ def test_key_release(self, client, **kwargs):
535533
release_result = client.release_key(rsa_key_name, attestation)
536534
assert release_result.value
537535

538-
@pytest.mark.parametrize("api_version,is_hsm",only_hsm_7_3)
536+
@pytest.mark.parametrize("api_version,is_hsm",only_hsm_latest)
539537
@KeysClientPreparer()
540538
@recorded_by_proxy
541539
def test_imported_key_release(self, client, **kwargs):
@@ -555,7 +553,7 @@ def test_imported_key_release(self, client, **kwargs):
555553
release_result = client.release_key(imported_key_name, attestation)
556554
assert release_result.value
557555

558-
@pytest.mark.parametrize("api_version,is_hsm",only_7_3)
556+
@pytest.mark.parametrize("api_version,is_hsm",only_latest)
559557
@KeysClientPreparer()
560558
@recorded_by_proxy
561559
def test_update_release_policy(self, client, **kwargs):
@@ -600,7 +598,7 @@ def test_update_release_policy(self, client, **kwargs):
600598
assert claim_condition is False
601599

602600
#Immutable policies aren't currently supported on Managed HSM
603-
@pytest.mark.parametrize("api_version,is_hsm",only_vault_7_3)
601+
@pytest.mark.parametrize("api_version,is_hsm",only_vault_latest)
604602
@KeysClientPreparer()
605603
@recorded_by_proxy
606604
def test_immutable_release_policy(self, client, **kwargs):
@@ -637,7 +635,7 @@ def test_immutable_release_policy(self, client, **kwargs):
637635
with pytest.raises(HttpResponseError):
638636
self._update_key_properties(client, key, new_release_policy)
639637

640-
@pytest.mark.parametrize("api_version,is_hsm",only_vault_7_3)
638+
@pytest.mark.parametrize("api_version,is_hsm",only_vault_latest)
641639
@KeysClientPreparer()
642640
@recorded_by_proxy
643641
def test_key_rotation(self, client, **kwargs):
@@ -655,7 +653,7 @@ def test_key_rotation(self, client, **kwargs):
655653
assert key.key.n != rotated_key.key.n
656654

657655
@pytest.mark.playback_test_only("Currently fails in live mode because of service regression; will be fixed soon.")
658-
@pytest.mark.parametrize("api_version,is_hsm",only_vault_7_3)
656+
@pytest.mark.parametrize("api_version,is_hsm",only_vault_latest)
659657
@KeysClientPreparer()
660658
@recorded_by_proxy
661659
def test_key_rotation_policy(self, client, **kwargs):

sdk/keyvault/azure-keyvault-keys/tests/test_keys_async.py

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
from azure.core.pipeline.policies import SansIOHTTPPolicy
1515
from azure.core.rest import HttpRequest
1616
from azure.keyvault.keys import (
17-
ApiVersion,
1817
JsonWebKey,
1918
KeyReleasePolicy,
2019
KeyRotationLifetimeAction,
@@ -35,10 +34,9 @@
3534

3635
all_api_versions = get_decorator(is_async=True)
3736
only_hsm = get_decorator(only_hsm=True, is_async=True)
38-
only_hsm_7_3 = get_decorator(only_hsm=True, is_async=True, api_versions=[ApiVersion.V7_3])
37+
only_hsm_latest = get_decorator(only_hsm=True, is_async=True, api_versions=[DEFAULT_VERSION])
3938
only_vault_latest = get_decorator(only_vault=True, is_async=True, api_versions=[DEFAULT_VERSION])
40-
only_vault_7_3 = get_decorator(only_vault=True, is_async=True, api_versions=[ApiVersion.V7_3])
41-
only_7_3 = get_decorator(is_async=True, api_versions=[ApiVersion.V7_3])
39+
only_latest = get_decorator(is_async=True, api_versions=[DEFAULT_VERSION])
4240
logging_enabled = get_decorator(is_async=True, logging_enable=True)
4341
logging_disabled = get_decorator(is_async=True, logging_enable=False)
4442

@@ -497,7 +495,7 @@ async def test_logging_disabled(self, client, is_hsm, **kwargs):
497495
mock_handler.close()
498496

499497
@pytest.mark.asyncio
500-
@pytest.mark.parametrize("api_version,is_hsm",only_hsm_7_3)
498+
@pytest.mark.parametrize("api_version,is_hsm",only_hsm_latest)
501499
@AsyncKeysClientPreparer()
502500
@recorded_by_proxy_async
503501
async def test_get_random_bytes(self, client, **kwargs):
@@ -514,7 +512,7 @@ async def test_get_random_bytes(self, client, **kwargs):
514512
generated_random_bytes.append(random_bytes)
515513

516514
@pytest.mark.asyncio
517-
@pytest.mark.parametrize("api_version,is_hsm",only_7_3)
515+
@pytest.mark.parametrize("api_version,is_hsm",only_latest)
518516
@AsyncKeysClientPreparer()
519517
@recorded_by_proxy_async
520518
async def test_key_release(self, client, **kwargs):
@@ -538,7 +536,7 @@ async def test_key_release(self, client, **kwargs):
538536
assert release_result.value
539537

540538
@pytest.mark.asyncio
541-
@pytest.mark.parametrize("api_version,is_hsm",only_hsm_7_3)
539+
@pytest.mark.parametrize("api_version,is_hsm",only_hsm_latest)
542540
@AsyncKeysClientPreparer()
543541
@recorded_by_proxy_async
544542
async def test_imported_key_release(self, client, **kwargs):
@@ -559,7 +557,7 @@ async def test_imported_key_release(self, client, **kwargs):
559557
assert release_result.value
560558

561559
@pytest.mark.asyncio
562-
@pytest.mark.parametrize("api_version,is_hsm",only_7_3)
560+
@pytest.mark.parametrize("api_version,is_hsm",only_latest)
563561
@AsyncKeysClientPreparer()
564562
@recorded_by_proxy_async
565563
async def test_update_release_policy(self, client, **kwargs):
@@ -605,7 +603,7 @@ async def test_update_release_policy(self, client, **kwargs):
605603

606604
# Immutable policies aren't currently supported on Managed HSM
607605
@pytest.mark.asyncio
608-
@pytest.mark.parametrize("api_version,is_hsm",only_vault_7_3)
606+
@pytest.mark.parametrize("api_version,is_hsm",only_vault_latest)
609607
@AsyncKeysClientPreparer()
610608
@recorded_by_proxy_async
611609
async def test_immutable_release_policy(self, client, **kwargs):
@@ -643,7 +641,7 @@ async def test_immutable_release_policy(self, client, **kwargs):
643641
await self._update_key_properties(client, key, new_release_policy)
644642

645643
@pytest.mark.asyncio
646-
@pytest.mark.parametrize("api_version,is_hsm",only_vault_7_3)
644+
@pytest.mark.parametrize("api_version,is_hsm",only_vault_latest)
647645
@AsyncKeysClientPreparer()
648646
@recorded_by_proxy_async
649647
async def test_key_rotation(self, client, **kwargs):
@@ -662,7 +660,7 @@ async def test_key_rotation(self, client, **kwargs):
662660

663661
@pytest.mark.playback_test_only("Currently fails in live mode because of service regression; will be fixed soon.")
664662
@pytest.mark.asyncio
665-
@pytest.mark.parametrize("api_version,is_hsm",only_vault_7_3)
663+
@pytest.mark.parametrize("api_version,is_hsm",only_vault_latest)
666664
@AsyncKeysClientPreparer()
667665
@recorded_by_proxy_async
668666
async def test_key_rotation_policy(self, client, **kwargs):

sdk/keyvault/azure-keyvault-keys/tests/test_samples_keys.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,14 @@
88
import time
99

1010
import pytest
11-
from azure.keyvault.keys import ApiVersion, KeyCurveName, KeyType
11+
from azure.keyvault.keys import KeyType
1212
from devtools_testutils import recorded_by_proxy
1313

1414
from _shared.test_case import KeyVaultTestCase
1515
from _test_case import KeysClientPreparer, get_decorator
1616
from _keys_test_case import KeysTestCase
1717

1818
all_api_versions = get_decorator(only_vault=True)
19-
only_7_4_hsm = get_decorator(only_hsm=True, api_versions=[ApiVersion.V7_4])
2019
only_hsm = get_decorator(only_hsm=True)
2120

2221

sdk/keyvault/azure-keyvault-keys/tests/test_samples_keys_async.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,13 @@
66
import os
77

88
import pytest
9-
from azure.keyvault.keys import ApiVersion, KeyCurveName, KeyType
9+
from azure.keyvault.keys import KeyType
1010
from devtools_testutils.aio import recorded_by_proxy_async
1111

1212
from _async_test_case import AsyncKeysClientPreparer, get_decorator
1313
from _shared.test_case_async import KeyVaultTestCase
1414

1515
all_api_versions = get_decorator(is_async=True, only_vault=True)
16-
only_7_4_hsm = get_decorator(only_hsm=True, api_versions=[ApiVersion.V7_4])
1716
only_hsm = get_decorator(only_hsm=True, is_async=True)
1817

1918

0 commit comments

Comments
 (0)