Skip to content

Commit 6360803

Browse files
u9009Jing Li
andauthored
Updated a test in ML SDK to adapt to the changed validation on FQDNs. (Azure#37700)
- Given test case passed Co-authored-by: Jing Li <[email protected]>
1 parent d565c1a commit 6360803

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

sdk/ml/azure-ai-ml/tests/test_configs/workspace/workspace_mvnet.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,6 @@ managed_network:
3030
service_resource_id: /subscriptions/0caf7ec9-615a-4491-bad8-64ce023324e1/resourceGroups/joharrin-sdk-tests/providers/Microsoft.Network/applicationGateways/mvnettestappgw
3131
spark_enabled: false
3232
subresource_target: appGwPrivateFrontendIpIPv4
33-
fqdns: ["contoso.com", "contoso2.com"]
33+
fqdns: ["test.1.fake.com", "test.2.fake.com"]
3434
type: private_endpoint
3535
tags: {}

sdk/ml/azure-ai-ml/tests/workspace/e2etests/test_workspace_outbound_rule_operations.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
from devtools_testutils import AzureRecordedTestCase, is_live
88

99
from azure.ai.ml import MLClient, load_workspace
10-
from azure.ai.ml.entities._workspace.workspace import Workspace
10+
from azure.ai.ml.constants._workspace import IsolationMode, OutboundRuleCategory
1111
from azure.ai.ml.entities._workspace.networking import (
1212
FqdnDestination,
1313
ManagedNetwork,
1414
PrivateEndpointDestination,
1515
ServiceTagDestination,
1616
)
17-
from azure.ai.ml.constants._workspace import IsolationMode, OutboundRuleCategory
17+
from azure.ai.ml.entities._workspace.workspace import Workspace
1818
from azure.core.polling import LROPoller
1919

2020

@@ -100,8 +100,8 @@ def test_workspace_create_with_managed_network_list_show_remove_rules(
100100
assert "applicationGateways/mvnettestappgw" in app_gw_pe_rule.service_resource_id
101101
assert app_gw_pe_rule.spark_enabled == False
102102
assert app_gw_pe_rule.subresource_target == "appGwPrivateFrontendIpIPv4"
103-
assert "contoso.com" in app_gw_pe_rule.fqdns
104-
assert "contoso2.com" in app_gw_pe_rule.fqdns
103+
assert "test.1.fake.com" in app_gw_pe_rule.fqdns
104+
assert "test.2.fake.com" in app_gw_pe_rule.fqdns
105105

106106
# test adding outbound rules with workspace update from yaml
107107
params_override = [

0 commit comments

Comments
 (0)