Re-enable BuildTargetingString for mgmt release unblockers (Azure#38617)

* filter saved package properties by an optional runtime variable BuildTargetingString
  * if this is set, the package set for the service will be further filtered to matching the targetingstring. globbing is supported EG azure-storage*

---------

Co-authored-by: Wes Haggard <[email protected]>

Author: scbedd

eng/pipelines/templates/steps/resolve-package-targeting.yml

@@ -1,7 +1,7 @@
 parameters:
   - name: BuildTargetingString
     type: string
-    default: 'azure-*'
+    default: '*'
   - name: PackagePropertiesFolder
     type: string
     default: ''
@@ -13,36 +13,12 @@ steps:
   # whether we are running within a PR build or not, we need to walk the package properties and save them to
   # variable $(TargetingString) so that every other check and accept it as an argument.
   - pwsh: |
-      $setting = "${{ parameters.BuildTargetingString }}"
+      $IncludeIndirect = [bool]::Parse("${{ parameters.IncludeIndirect }}")
 
-      # if the variable is not set, it'll just come back as the variable name. otherwise it's set.
-      if ('$(BuildTargetingString)' -ne ('$' + '(BuildTargetingString)')) {
-          Write-Host "The variable named BuildTargetingString is set to $(BuildTargetingString)"
-          $setting = "$(BuildTargetingString)"
-      }
-      else {
-        if (Test-Path "${{ parameters.PackagePropertiesFolder }}") {
-          if ("${{ parameters.IncludeIndirect }}" -eq "true") {
-            $packageProperties = Get-ChildItem -Recurse -Force "${{ parameters.PackagePropertiesFolder }}/*.json" `
-                | ForEach-Object { $_.Name.Replace(".json", "") }
-          }
-          else {
-            $packageProperties = Get-ChildItem -Recurse -Force "${{ parameters.PackagePropertiesFolder }}/*.json" `
-              | Where-Object { (Get-Content -Raw $_ | ConvertFrom-Json).IncludedForValidation -eq $false } `
-              | ForEach-Object { $_.Name.Replace(".json", "") }
-          }
-
-          $setting = $packageProperties -join ","
-
-          # in case we don't expect any packages, we should set the variable to null, which will match NO packages and cause whatever the check
-          # is to skip with exit 0 (which is what we want!)
-          if (-not $setting) {
-            $setting = "null"
-          }
-        }
-      }
-
-      Write-Host "##vso[task.setvariable variable=TargetingString;]$setting"
+      ./eng/scripts/resolve-package-info.ps1 `
+          -ParameterTargetingStringSetting "${{ parameters.BuildTargetingString }}" `
+          -PackagePropertiesFolder "${{ parameters.PackagePropertiesFolder }}" `
+          -IncludeIndirect $IncludeIndirect
     displayName: Resolve Targeted Packages
     # if targeting has been set by matrix, this value will already be populated
     condition: eq(variables['TargetingString'], '')

eng/scripts/resolve-package-info.ps1

@@ -0,0 +1,45 @@
+param (
+    [string] $ParameterTargetingStringSetting,
+    [string] $PackagePropertiesFolder,
+    [bool] $IncludeIndirect = $true
+)
+
+$setting = $ParameterTargetingStringSetting
+$targetingString = $ParameterTargetingStringSetting
+
+# users of internal service builds will set variable "BuildTargetingString" at runtime
+# if they want to artificially filter the discovered packages for the build.
+# when azure devops sets the variable, it will make it all capital letters, so we should check that
+if ($env:BUILDTARGETINGSTRING) {
+    $targetingString = $env:BUILDTARGETINGSTRING
+}
+
+Write-Host "The resolved targeting string within the script is `"$targetingString`""
+
+if (Test-Path "$PackagePropertiesFolder") {
+    $packageProperties = Get-ChildItem -Recurse -Force "$PackagePropertiesFolder/*.json" `
+
+    if (-not $IncludeIndirect) {
+        $packageProperties = Get-ChildItem -Recurse -Force "$PackagePropertiesFolder/*.json" `
+            | Where-Object {
+                $includedForValidation = (Get-Content -Raw $_ | ConvertFrom-Json).IncludedForValidation
+                if ($includedForValidation -eq $true) {
+                    Remove-Item $_.FullName; $false
+                } else { $true }
+            }
+    }
+
+    $packageProperties = $packageProperties
+        | Where-Object { if ($_.Name.Replace(".json", "") -like "$targetingString") { return $true } else { Remove-Item $_.FullName; return $false; } }
+        | ForEach-Object { $_.Name.Replace(".json", "") }
+
+    $setting = $packageProperties -join ","
+
+    # in case we don't expect any packages, we should set the variable to null, which will match NO packages and cause whatever the check
+    # is to skip with exit 0 (which is what we want!)
+    if (-not $setting) {
+        $setting = "null"
+    }
+}
+
+Write-Host "##vso[task.setvariable variable=TargetingString;]$setting"