Skip to content

Commit 7099e79

Browse files
catalinaperaltacperaltahmsyyc
authored
[bct] Fix module key error (Azure#37363)
* fix module key error * Update breaking_changes_allowlist.py --------- Co-authored-by: Catalina Peralta <[email protected]> Co-authored-by: Yuchao Yan <[email protected]>
1 parent 313b67d commit 7099e79

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

scripts/breaking_changes_checker/breaking_changes_allowlist.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
# --------------------------------------------------------------------------------------------
77

88

9-
RUN_BREAKING_CHANGES_PACKAGES = ["azure-mgmt-*", "azure-ai-contentsafety"]
9+
RUN_BREAKING_CHANGES_PACKAGES = ["azure-mgmt-*", "azure-ai-contentsafety", "azure-ai-vision-face"]
1010

1111

1212
# See Readme for ignore format

scripts/breaking_changes_checker/checkers/method_overloads_checker.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ class MethodOverloadsChecker:
1717
def run_check(self, diff, stable_nodes, current_nodes):
1818
bc_list = []
1919
for module_name, module in diff.items():
20+
# This is a new module, so we won't check for removed overloads
21+
if module_name not in stable_nodes:
22+
continue
2023
for class_name, class_components in module.get("class_nodes", {}).items():
2124
# We aren't checking for deleted classes in this checker
2225
if isinstance(class_name, jsondiff.Symbol):

0 commit comments

Comments
 (0)