Skip to content

Commit 7577685

Browse files
authored
[-next] october tools bump (Azure#37878)
* bump next * update * update * space * pylint changes * black * pylint eh * pylint * fix pylint * black
1 parent ae7bdfb commit 7577685

File tree

10 files changed

+14
-13
lines changed

10 files changed

+14
-13
lines changed

eng/tox/tox.ini

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ commands =
7777

7878
[testenv:pylint]
7979
description=Lints a package with pylint (version {[testenv:pylint]pylint_version})
80-
pylint_version=3.1.0
80+
pylint_version=3.2.5
8181
skipsdist = true
8282
skip_install = true
8383
usedevelop = false
@@ -101,7 +101,7 @@ commands =
101101

102102
[testenv:next-pylint]
103103
description=Lints a package with pylint (version {[testenv:next-pylint]pylint_version})
104-
pylint_version=3.2.5
104+
pylint_version=3.2.7
105105
skipsdist = true
106106
skip_install = true
107107
usedevelop = false
@@ -145,7 +145,7 @@ commands =
145145

146146
[testenv:mypy]
147147
description=Typechecks a package with mypy (version {[testenv:mypy]mypy_version})
148-
mypy_version=1.9.0
148+
mypy_version=1.10.1
149149
skipsdist = true
150150
skip_install = true
151151
usedevelop = true
@@ -197,7 +197,7 @@ commands =
197197

198198
[testenv:pyright]
199199
description=Typechecks a package with pyright (version {[testenv:pyright]pyright_version})
200-
pyright_version=1.1.359
200+
pyright_version=1.1.371
201201
skipsdist = true
202202
skip_install = true
203203
usedevelop = true

pylintrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ load-plugins=pylint_guidelines_checker
2020
# Let's black deal with bad-continuation
2121

2222
# Added disables from super-with-arguments
23-
disable=useless-object-inheritance,missing-docstring,locally-disabled,fixme,cyclic-import,too-many-arguments,invalid-name,duplicate-code,too-few-public-methods,consider-using-f-string,super-with-arguments,redefined-builtin,import-outside-toplevel,client-suffix-needed,unnecessary-dunder-call,unnecessary-ellipsis,client-paging-methods-use-list,docstring-keyword-should-match-keyword-only,docstring-type-do-not-use-class,consider-using-max-builtin,too-many-lines
23+
disable=useless-object-inheritance,missing-docstring,locally-disabled,fixme,cyclic-import,too-many-arguments,invalid-name,duplicate-code,too-few-public-methods,consider-using-f-string,super-with-arguments,redefined-builtin,import-outside-toplevel,client-suffix-needed,unnecessary-dunder-call,unnecessary-ellipsis,client-paging-methods-use-list,docstring-keyword-should-match-keyword-only,docstring-type-do-not-use-class,consider-using-max-builtin,too-many-lines,possibly-used-before-assignment
2424

2525
[FORMAT]
2626
max-line-length=120

sdk/core/azure-core-experimental/azure/core/experimental/transport/_httpx.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,4 +219,6 @@ def send(self, request: Union[HttpRequest, LegacyHttpRequest], **kwargs) -> Http
219219
except httpx.RequestError as err:
220220
raise ServiceRequestError(err, error=err) from err
221221

222-
return HttpXTransportResponse(request, response, stream_contextmanager=stream_ctx)
222+
return HttpXTransportResponse(
223+
request, response, stream_contextmanager=stream_ctx # pylint: disable=used-before-assignment
224+
)

sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_connection.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -585,7 +585,6 @@ def _incoming_end(self, channel: int, frame: Tuple[Any, ...]) -> None:
585585
"END frame received on invalid channel. Closing connection.",
586586
extra=self._network_trace_params
587587
)
588-
return
589588

590589
def _process_incoming_frame(self, channel: int, frame: Optional[Union[bytes, Tuple[Any,...]]]) -> bool: # pylint:disable=too-many-return-statements
591590
"""Process an incoming frame, either directly or by passing to the necessary Session.

sdk/ml/azure-ai-ml/azure/ai/ml/_internal/entities/component.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ def _try_build_local_code(self) -> Iterable[Code]:
328328

329329
tmp_code_dir: Path
330330
# origin code value of internal component will never be None. check _get_origin_code_value for details
331-
with self._generate_additional_includes_obj().merge_local_code_and_additional_includes() as tmp_code_dir:
331+
with self._generate_additional_includes_obj().merge_local_code_and_additional_includes() as tmp_code_dir: # pylint:disable=contextmanager-generator-missing-cleanup
332332
# use absolute path in case temp folder & work dir are in different drive
333333
tmp_code_dir = tmp_code_dir.absolute()
334334

sdk/ml/azure-ai-ml/azure/ai/ml/_telemetry/activity.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ def error_preprocess(activityLogger, exception):
154154

155155

156156
@contextlib.contextmanager
157-
def log_activity(
157+
def log_activity( # pylint:disable=useless-return
158158
logger,
159159
activity_name,
160160
activity_type=ActivityType.INTERNALCALL,

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_component/code.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ def _build_code(self) -> Generator:
259259
yield Code(path=origin_code_value)
260260
elif code_type in [CodeType.LOCAL, CodeType.NONE]:
261261
code: Any
262-
with self._try_build_local_code() as code:
262+
with self._try_build_local_code() as code: # pylint:disable=contextmanager-generator-missing-cleanup
263263
yield code
264264
else:
265265
# arm id, None and unknown need no extra resolution

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_component/flow.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -530,7 +530,7 @@ def _fill_back_code_value(self, value: str) -> None:
530530

531531
@contextlib.contextmanager
532532
def _try_build_local_code(self) -> Generator:
533-
with super()._try_build_local_code() as code:
533+
with super()._try_build_local_code() as code: # pylint:disable=contextmanager-generator-missing-cleanup
534534
if not code or not code.path:
535535
yield code
536536
return

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_job/sweep/parameterized_sweep.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
}
4444

4545

46-
class ParameterizedSweep:
46+
class ParameterizedSweep: # pylint:disable=too-many-instance-attributes
4747
"""Shared logic for standalone and pipeline sweep job."""
4848

4949
def __init__(
@@ -205,6 +205,7 @@ def set_limits(
205205
:keyword trial_timeout: timeout in seconds for each trial
206206
:paramtype trial_timeout: int
207207
"""
208+
# pylint:disable=attribute-defined-outside-init
208209
if self._limits is None:
209210
self._limits = SweepJobLimits(
210211
max_concurrent_trials=max_concurrent_trials,

sdk/servicebus/azure-servicebus/azure/servicebus/_pyamqp/_connection.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -585,7 +585,6 @@ def _incoming_end(self, channel: int, frame: Tuple[Any, ...]) -> None:
585585
"END frame received on invalid channel. Closing connection.",
586586
extra=self._network_trace_params
587587
)
588-
return
589588

590589
def _process_incoming_frame(self, channel: int, frame: Optional[Union[bytes, Tuple[Any,...]]]) -> bool: # pylint:disable=too-many-return-statements
591590
"""Process an incoming frame, either directly or by passing to the necessary Session.

0 commit comments

Comments
 (0)