Linting fix for pylint 3.2.7 (Azure#39109)

* pylint 3.2.7 fixes 1st iteration

* pylint 3.2.7 fixes 2nd iteration

* pylint 3.2.7 fixes 3rd iteration

* pylint / black fixes

* next-pylint - pylint / black fixes

* next-pylint - pylint / black fixes

* next-pylint- mypy fixes

Author: kshitij-microsoft

sdk/ml/azure-ai-ml/azure/ai/ml/_arm_deployments/arm_deployment_executor.py

@@ -85,7 +85,6 @@ def deploy_resource(
                 error_category=ErrorCategory.USER_ERROR,
             )
         error = None
-        # pylint: disable=too-many-nested-blocks
         try:
             poller = self._get_poller(template=template, parameters=parameters)
             module_logger.info(

sdk/ml/azure-ai-ml/azure/ai/ml/_artifacts/_artifact_utilities.py

@@ -188,7 +188,12 @@ def list_logs_in_datastore(
                 expiry=datetime.utcnow() + timedelta(minutes=30),
             )
 
-        log_dict[sub_name] = "{}/{}/{}?{}".format(ds_info["account_url"], ds_info["container_name"], item_name, token)
+        log_dict[sub_name] = "{}/{}/{}?{}".format(
+            ds_info["account_url"],
+            ds_info["container_name"],
+            item_name,
+            token,  # pylint: disable=possibly-used-before-assignment
+        )
     return log_dict
 
 

sdk/ml/azure-ai-ml/azure/ai/ml/_artifacts/_blob_storage_helper.py

@@ -175,9 +175,7 @@ def check_blob_exists(self) -> None:
                 properties = blob_client.get_blob_properties()
             except HttpResponseError as e:
                 if e.error_code == KEY_AUTHENTICATION_ERROR_CODE:  # pylint: disable=no-member
-                    formatted_msg = SAS_KEY_AUTHENTICATION_ERROR_MSG.format(
-                        e.error_code, e.exc_value
-                    )  # pylint: disable=no-member
+                    formatted_msg = SAS_KEY_AUTHENTICATION_ERROR_MSG.format(e.error_code, e.exc_value)
                     exception_with_documentation = Exception(formatted_msg)
                     exception_with_documentation.__traceback__ = e.exc_traceback
                     raise exception_with_documentation from e
@@ -209,7 +207,7 @@ def check_blob_exists(self) -> None:
             self.overwrite = True  # if upload never confirmed, approve overriding the partial upload
         except ResourceNotFoundError:
             pass
-        except Exception as e:  # pylint: disable=W0718
+        except Exception as e:
             # pylint: disable=no-member
             if hasattr(e, "error_code") and e.error_code == STORAGE_AUTH_MISMATCH_ERROR:
                 msg = (

sdk/ml/azure-ai-ml/azure/ai/ml/_artifacts/_fileshare_storage_helper.py

@@ -2,7 +2,7 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # ---------------------------------------------------------
 
-# pylint: disable=client-accepts-api-version-keyword,too-many-instance-attributes,client-method-missing-type-annotations,missing-client-constructor-parameter-kwargs
+# pylint: disable=client-accepts-api-version-keyword,client-method-missing-type-annotations,missing-client-constructor-parameter-kwargs
 
 import logging
 import os

sdk/ml/azure-ai-ml/azure/ai/ml/_artifacts/_gen2_storage_helper.py

@@ -174,7 +174,7 @@ def check_blob_exists(self) -> None:
                     self.name = metadata.get("name")
                     self.version = metadata.get("version")
                     raise AssetNotChangedError
-        except Exception as e:  # pylint: disable=W0718
+        except Exception as e:
             # pylint: disable=no-member
             if hasattr(e, "error_code") and e.error_code == STORAGE_AUTH_MISMATCH_ERROR:
                 msg = (

sdk/ml/azure-ai-ml/azure/ai/ml/_internal/_schema/component.py

@@ -119,7 +119,6 @@ def get_skip_fields(self):
         return ["properties"]
 
     def _serialize(self, obj, *, many: bool = False):
-        # pylint: disable=no-member
         if many and obj is not None:
             return super(InternalComponentSchema, self)._serialize(obj, many=many)
         ret = super(InternalComponentSchema, self)._serialize(obj)

sdk/ml/azure-ai-ml/azure/ai/ml/_internal/entities/component.py

@@ -366,5 +366,5 @@ def _try_build_local_code(self) -> Iterable[Code]:
                 ignore_file=rebased_ignore_file,
             )
 
-    def __call__(self, *args, **kwargs) -> InternalBaseNode:  # pylint: disable=useless-super-delegation
+    def __call__(self, *args, **kwargs) -> InternalBaseNode:
         return super(InternalComponent, self).__call__(*args, **kwargs)

sdk/ml/azure-ai-ml/azure/ai/ml/_internal/entities/parallel.py

@@ -2,8 +2,6 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # ---------------------------------------------------------
 
-# pylint: disable=protected-access
-
 from typing import List, Union
 
 from marshmallow import Schema

sdk/ml/azure-ai-ml/azure/ai/ml/_internal/entities/scope.py

@@ -2,8 +2,6 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # ---------------------------------------------------------
 
-# pylint: disable=protected-access
-
 from typing import List, Union
 
 from marshmallow import Schema

sdk/ml/azure-ai-ml/azure/ai/ml/_local_endpoints/azureml_image_context.py

@@ -66,7 +66,8 @@ def __init__(
             },
         }
         self._environment = {
-            LocalEndpointConstants.ENVVAR_KEY_AZUREML_MODEL_DIR: docker_azureml_model_dir,  # ie. /var/azureml-app/azureml-models/  # pylint: disable=line-too-long
+            LocalEndpointConstants.ENVVAR_KEY_AZUREML_MODEL_DIR: docker_azureml_model_dir,
+            # ie. /var/azureml-app/azureml-models/
             LocalEndpointConstants.ENVVAR_KEY_AZUREML_INFERENCE_PYTHON_PATH: LocalEndpointConstants.CONDA_ENV_BIN_PATH,
         }