Skip to content

Commit 844e0c5

Browse files
Scheme update for featureset spec (Azure#29371)
* Scheme update for feature set spec * Remove unused imports * remove not used properties * revert
1 parent 476a449 commit 844e0c5

File tree

5 files changed

+13
-8
lines changed

5 files changed

+13
-8
lines changed

sdk/ml/azure-ai-ml/azure/ai/ml/_schema/_feature_set/featureset_spec_properties_schema.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
from azure.ai.ml._schema.core.fields import NestedField
1111
from azure.ai.ml._schema.core.schema import YamlFileSchema, PatchedSchemaMeta
12-
from azure.ai.ml._schema._feature_store_entity.data_column_schema import DataColumnSchema
1312

1413
from .source_metadata_schema import SourceMetadataSchema
1514

@@ -38,6 +37,5 @@ class FeaturesetSpecPropertiesSchema(YamlFileSchema):
3837
FeatureTransformationCodePropertiesSchema, data_key="featureTransformationCode"
3938
)
4039
features = fields.List(NestedField(FeaturePropertiesSchema), data_key="features")
41-
index_columns = fields.List(NestedField(DataColumnSchema), data_key="indexColumns")
4240
source_lookback = fields.Nested(DelayMetadataPropertiesSchema, data_key="sourceLookback")
4341
temporal_join_lookback = fields.Nested(DelayMetadataPropertiesSchema, data_key="temporalJoinLookback")

sdk/ml/azure-ai-ml/azure/ai/ml/_schema/_feature_set/source_metadata_schema.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
from marshmallow import fields, post_load
1010

11-
from azure.ai.ml._schema.core.fields import NestedField
1211
from azure.ai.ml._schema.core.schema import PatchedSchemaMeta
1312

1413
from .delay_metadata_schema import DelayMetadataSchema
@@ -18,8 +17,8 @@
1817
class SourceMetadataSchema(metaclass=PatchedSchemaMeta):
1918
type = fields.Str(required=True)
2019
path = fields.Str(required=True)
21-
timestamp_column = NestedField(TimestampColumnMetadataSchema)
22-
source_delay = NestedField(DelayMetadataSchema)
20+
timestamp_column = fields.Nested(TimestampColumnMetadataSchema, required=True)
21+
source_delay = fields.Nested(DelayMetadataSchema, required=False)
2322

2423
@post_load
2524
def make(self, data: Dict, **kwargs):

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_feature_set/delay_metadata.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,11 @@
22
# Copyright (c) Microsoft Corporation. All rights reserved.
33
# ---------------------------------------------------------
44

5+
# pylint: disable=unused-argument
6+
57

68
class DelayMetadata(object):
7-
def __init__(self, *, days: int, hours: int, minutes: int, **kwargs): # pylint: disable=unused-argument
9+
def __init__(self, *, days: int = None, hours: int = None, minutes: int = None, **kwargs):
810
self.days = days
911
self.hours = hours
1012
self.minutes = minutes

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_feature_set/source_metadata.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,13 @@
1010

1111
class SourceMetadata(object):
1212
def __init__(
13-
self, *, type: str, path: str, timestamp_column: TimestampColumnMetadata, source_delay: DelayMetadata, **kwargs
13+
self,
14+
*,
15+
type: str,
16+
path: str,
17+
timestamp_column: TimestampColumnMetadata,
18+
source_delay: DelayMetadata = None,
19+
**kwargs
1420
):
1521
self.type = type
1622
self.path = path

sdk/ml/azure-ai-ml/azure/ai/ml/entities/_feature_set/timestamp_column_metadata.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66

77

88
class TimestampColumnMetadata(object):
9-
def __init__(self, *, name: str, format: str, **kwargs):
9+
def __init__(self, *, name: str, format: str = None, **kwargs):
1010
self.name = name
1111
self.format = format

0 commit comments

Comments
 (0)