Skip to content

Commit 8c18f91

Browse files
NethracsNethra Sashikar
andauthored
add experimental decorator for firewallsku (Azure#38657)
* add experimental decorator * mark firewallsku as experimental field * remove duplicate import * isort * format file --------- Co-authored-by: Nethra Sashikar <[email protected]>
1 parent 57de74a commit 8c18f91

File tree

2 files changed

+20
-10
lines changed

2 files changed

+20
-10
lines changed

sdk/ml/azure-ai-ml/azure/ai/ml/_schema/workspace/networking.py

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
from marshmallow import EXCLUDE, fields
88
from marshmallow.decorators import post_load, pre_dump
99

10+
from azure.ai.ml._schema import ExperimentalField
1011
from azure.ai.ml._schema.core.fields import NestedField, StringTransformedEnum, UnionField
1112
from azure.ai.ml._schema.core.schema_meta import PatchedSchemaMeta
1213
from azure.ai.ml._utils.utils import _snake_to_camel, camel_to_snake
@@ -47,7 +48,12 @@ def createdestobject(self, data, **kwargs):
4748
category = data.get("category", OutboundRuleCategory.USER_DEFINED)
4849
name = data.get("name")
4950
status = data.get("status", None)
50-
return FqdnDestination(name=name, destination=dest, category=_snake_to_camel(category), status=status)
51+
return FqdnDestination(
52+
name=name,
53+
destination=dest,
54+
category=_snake_to_camel(category),
55+
status=status,
56+
)
5157

5258

5359
class ServiceTagDestinationSchema(metaclass=PatchedSchemaMeta):
@@ -185,13 +191,15 @@ class ManagedNetworkSchema(metaclass=PatchedSchemaMeta):
185191
),
186192
allow_none=True,
187193
)
188-
firewall_sku = StringTransformedEnum(
189-
allowed_values=[
190-
FirewallSku.STANDARD,
191-
FirewallSku.BASIC,
192-
],
193-
casing_transform=camel_to_snake,
194-
metadata={"description": "Firewall sku for FQDN rules in AllowOnlyApprovedOutbound mode"},
194+
firewall_sku = ExperimentalField(
195+
StringTransformedEnum(
196+
allowed_values=[
197+
FirewallSku.STANDARD,
198+
FirewallSku.BASIC,
199+
],
200+
casing_transform=camel_to_snake,
201+
metadata={"description": "Firewall sku for FQDN rules in AllowOnlyApprovedOutbound mode"},
202+
)
195203
)
196204
network_id = fields.Str(required=False, dump_only=True)
197205
status = NestedField(ManagedNetworkStatusSchema, allow_none=False, unknown=EXCLUDE)
@@ -211,5 +219,6 @@ def make(self, data, **kwargs):
211219
)
212220
else:
213221
return ManagedNetwork(
214-
isolation_mode=_snake_to_camel(data["isolation_mode"]), firewall_sku=firewall_sku_value
222+
isolation_mode=_snake_to_camel(data["isolation_mode"]),
223+
firewall_sku=firewall_sku_value,
215224
)

sdk/ml/azure-ai-ml/azure/ai/ml/constants/_workspace.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
# ---------------------------------------------------------
44
from enum import Enum
55

6-
from azure.core import CaseInsensitiveEnumMeta
76
from azure.ai.ml._utils._experimental import experimental
7+
from azure.core import CaseInsensitiveEnumMeta
88

99

1010
class ManagedServiceIdentityType(str, Enum, metaclass=CaseInsensitiveEnumMeta):
@@ -24,6 +24,7 @@ class IsolationMode:
2424
ALLOW_ONLY_APPROVED_OUTBOUND = "AllowOnlyApprovedOutbound"
2525

2626

27+
@experimental
2728
class FirewallSku:
2829
"""Firewall Sku for FQDN rules in AllowOnlyApprovedOutbound."""
2930

0 commit comments

Comments
 (0)