App Config Provider - Fix Feature Flag Loading (Azure#39985)

* Stops loading feature flags as configurations

* cleaning up a bit

* bug fix and new recordings

* Update assets.json

* formatting

Author: mrm9084

sdk/appconfiguration/azure-appconfiguration-provider/CHANGELOG.md

@@ -1,11 +1,12 @@
 # Release History
 
-## 2.0.1 (2025-02-27)
+## 2.0.1 (2025-03-07)
 
 ### Bugs Fixed
 
 * Updates the failure to load from a config store from a debug level log to a warning level log.
 * Fixes an issue where the stack trace from the azure sdk wasn't being logged on startup.
+* Fixes a bug where feature flags could be loaded as configurations.
 
 ### Other Changes
 

sdk/appconfiguration/azure-appconfiguration-provider/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "python",
   "TagPrefix": "python/appconfiguration/azure-appconfiguration-provider",
-  "Tag": "python/appconfiguration/azure-appconfiguration-provider_41f1b04ee9"
+  "Tag": "python/appconfiguration/azure-appconfiguration-provider_81cf701465"
 }

sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_azureappconfigurationprovider.py

@@ -18,6 +18,7 @@
     TYPE_CHECKING,
 )
 from azure.appconfiguration import (  # type:ignore # pylint:disable=no-name-in-module
+    ConfigurationSetting,
     FeatureFlagConfigurationSetting,
     SecretReferenceConfigurationSetting,
 )
@@ -359,15 +360,7 @@ def refresh(self, **kwargs) -> None:  # pylint: disable=too-many-statements
                         need_refresh, self._refresh_on, configuration_settings = client.refresh_configuration_settings(
                             self._selects, self._refresh_on, headers=headers, **kwargs
                         )
-                        configuration_settings_processed = {}
-                        for config in configuration_settings:
-                            key = self._process_key_name(config)
-                            value = self._process_key_value(config)
-                            configuration_settings_processed[key] = value
-                        if self._feature_flag_enabled:
-                            configuration_settings_processed[FEATURE_MANAGEMENT_KEY] = self._dict[
-                                FEATURE_MANAGEMENT_KEY
-                            ]
+                        configuration_settings_processed = self._proccess_configurations(configuration_settings)
                         if need_refresh:
                             self._dict = configuration_settings_processed
                     if self._feature_flag_refresh_enabled:
@@ -429,12 +422,7 @@ def _load_all(self, **kwargs):
                 configuration_settings, sentinel_keys = client.load_configuration_settings(
                     self._selects, self._refresh_on, headers=headers, **kwargs
                 )
-                configuration_settings_processed = {}
-                for config in configuration_settings:
-                    key = self._process_key_name(config)
-                    value = self._process_key_value(config)
-                    configuration_settings_processed[key] = value
-
+                configuration_settings_processed = self._proccess_configurations(configuration_settings)
                 if self._feature_flag_enabled:
                     feature_flags, feature_flag_sentinel_keys, used_filters = client.load_feature_flags(
                         self._feature_flag_selectors, self._feature_flag_refresh_enabled, headers=headers, **kwargs
@@ -473,6 +461,19 @@ def _load_all(self, **kwargs):
                 is_failover_request = True
         raise exception
 
+    def _proccess_configurations(self, configuration_settings: List[ConfigurationSetting]) -> Dict[str, Any]:
+        configuration_settings_processed = {}
+        for config in configuration_settings:
+            if isinstance(config, FeatureFlagConfigurationSetting):
+                # Feature flags are not processed like other settings
+                continue
+            key = self._process_key_name(config)
+            value = self._process_key_value(config)
+            configuration_settings_processed[key] = value
+        if self._feature_flag_enabled and FEATURE_MANAGEMENT_KEY in self._dict:
+            configuration_settings_processed[FEATURE_MANAGEMENT_KEY] = self._dict[FEATURE_MANAGEMENT_KEY]
+        return configuration_settings_processed
+
     def _process_key_value(self, config):
         if isinstance(config, SecretReferenceConfigurationSetting):
             return _resolve_keyvault_reference(config, self)

sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/aio/_azureappconfigurationproviderasync.py

@@ -20,6 +20,7 @@
     Union,
 )
 from azure.appconfiguration import (  # type:ignore # pylint:disable=no-name-in-module
+    ConfigurationSetting,
     FeatureFlagConfigurationSetting,
     SecretReferenceConfigurationSetting,
 )
@@ -376,15 +377,7 @@ async def refresh(self, **kwargs) -> None:  # pylint: disable=too-many-statement
                                 self._selects, self._refresh_on, headers=headers, **kwargs
                             )
                         )
-                        configuration_settings_processed = {}
-                        for config in configuration_settings:
-                            key = self._process_key_name(config)
-                            value = await self._process_key_value(config)
-                            configuration_settings_processed[key] = value
-                        if self._feature_flag_enabled:
-                            configuration_settings_processed[FEATURE_MANAGEMENT_KEY] = self._dict[
-                                FEATURE_MANAGEMENT_KEY
-                            ]
+                        configuration_settings_processed = await self._proccess_configurations(configuration_settings)
                         if need_refresh:
                             self._dict = configuration_settings_processed
                     if self._feature_flag_refresh_enabled:
@@ -446,12 +439,7 @@ async def _load_all(self, **kwargs):
                 configuration_settings, sentinel_keys = await client.load_configuration_settings(
                     self._selects, self._refresh_on, headers=headers, **kwargs
                 )
-                configuration_settings_processed = {}
-                for config in configuration_settings:
-                    key = self._process_key_name(config)
-                    value = await self._process_key_value(config)
-                    configuration_settings_processed[key] = value
-
+                configuration_settings_processed = await self._proccess_configurations(configuration_settings)
                 if self._feature_flag_enabled:
                     feature_flags, feature_flag_sentinel_keys, used_filters = await client.load_feature_flags(
                         self._feature_flag_selectors, self._feature_flag_refresh_enabled, headers=headers, **kwargs
@@ -492,6 +480,19 @@ async def _load_all(self, **kwargs):
                 is_failover_request = True
         raise exception
 
+    async def _proccess_configurations(self, configuration_settings: List[ConfigurationSetting]) -> Dict[str, Any]:
+        configuration_settings_processed = {}
+        for config in configuration_settings:
+            if isinstance(config, FeatureFlagConfigurationSetting):
+                # Feature flags are not processed like other settings
+                continue
+            key = self._process_key_name(config)
+            value = await self._process_key_value(config)
+            configuration_settings_processed[key] = value
+        if self._feature_flag_enabled and FEATURE_MANAGEMENT_KEY in self._dict:
+            configuration_settings_processed[FEATURE_MANAGEMENT_KEY] = self._dict[FEATURE_MANAGEMENT_KEY]
+        return configuration_settings_processed
+
     async def _process_key_value(self, config):
         if isinstance(config, SecretReferenceConfigurationSetting):
             return await _resolve_keyvault_reference(config, self)