useless-disable (Azure#39064)

Author: l0lawrence

sdk/identity/azure-identity/azure/__init__.py

@@ -2,5 +2,4 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
 # ------------------------------------
-# pylint:disable=missing-docstring
 __path__ = __import__("pkgutil").extend_path(__path__, __name__)  # type: ignore

sdk/identity/azure-identity/azure/identity/_credentials/authorization_code.py

@@ -85,7 +85,7 @@ def get_token(
           attribute gives a reason. Any error response from Microsoft Entra ID is available as the error's
           ``response`` attribute.
         """
-        # pylint:disable=useless-super-delegation
+
         return super(AuthorizationCodeCredential, self).get_token(
             *scopes, claims=claims, tenant_id=tenant_id, client_secret=self._client_secret, **kwargs
         )

sdk/identity/azure-identity/azure/identity/_credentials/azd_cli.py

@@ -278,7 +278,7 @@ def _run_command(command: str, timeout: int) -> str:
         # failed to execute 'cmd' or '/bin/sh'
         error = CredentialUnavailableError(message="Failed to execute '{}'".format(args[0]))
         raise error from ex
-    except Exception as ex:  # pylint:disable=broad-except
+    except Exception as ex:
         # could be a timeout, for example
         error = CredentialUnavailableError(message="Failed to invoke the Azure Developer CLI")
         raise error from ex

sdk/identity/azure-identity/azure/identity/_credentials/azure_arc.py

@@ -54,7 +54,7 @@ def _get_secret_key(response: PipelineResponse) -> str:
     with open(key_file, "r", encoding="utf-8") as file:
         try:
             return file.read()
-        except Exception as error:  # pylint:disable=broad-except
+        except Exception as error:
             # user is expected to have obtained read permission prior to this being called
             raise ClientAuthenticationError(
                 message="Could not read file {} contents: {}".format(key_file, error)

sdk/identity/azure-identity/azure/identity/_credentials/azure_cli.py

@@ -269,7 +269,7 @@ def _run_command(command: str, timeout: int) -> str:
         # failed to execute 'cmd' or '/bin/sh'
         error = CredentialUnavailableError(message="Failed to execute '{}'".format(args[0]))
         raise error from ex
-    except Exception as ex:  # pylint:disable=broad-except
+    except Exception as ex:
         # could be a timeout, for example
         error = CredentialUnavailableError(message="Failed to invoke the Azure CLI")
         raise error from ex

sdk/identity/azure-identity/azure/identity/_credentials/azure_powershell.py

@@ -192,7 +192,7 @@ def run_command_line(command_line: List[str], timeout: int) -> str:
             proc = start_process(command_line)
             stdout, stderr = proc.communicate(**kwargs)
 
-    except Exception as ex:  # pylint:disable=broad-except
+    except Exception as ex:
         # failed to execute "cmd" or "/bin/sh", or timed out; PowerShell and Az.Account may or may not be installed
         # (handling Exception here because subprocess.SubprocessError and .TimeoutExpired were added in 3.3)
         if proc and not proc.returncode:

sdk/identity/azure-identity/azure/identity/_credentials/imds.py

@@ -89,7 +89,7 @@ def _request_token(self, *scopes: str, **kwargs: Any) -> AccessTokenInfo:
                 # IMDS responded
                 _check_forbidden_response(ex)
                 self._endpoint_available = True
-            except Exception as ex:  # pylint:disable=broad-except
+            except Exception as ex:
                 error_message = (
                     "ManagedIdentityCredential authentication unavailable, no response from the IMDS endpoint."
                 )
@@ -119,7 +119,7 @@ def _request_token(self, *scopes: str, **kwargs: Any) -> AccessTokenInfo:
             raise ClientAuthenticationError(message=ex.message, response=ex.response) from ex
         except json.decoder.JSONDecodeError as ex:
             raise CredentialUnavailableError(message="ManagedIdentityCredential authentication unavailable.") from ex
-        except Exception as ex:  # pylint:disable=broad-except
+        except Exception as ex:
             # if anything else was raised, assume the endpoint is unavailable
             error_message = "ManagedIdentityCredential authentication unavailable, no response from the IMDS endpoint."
             raise CredentialUnavailableError(error_message) from ex

sdk/identity/azure-identity/azure/identity/_internal/auth_code_redirect_handler.py

@@ -28,7 +28,7 @@ def do_GET(self):
 
         self.wfile.write(b"Authentication complete. You can close this window.")
 
-    def log_message(self, format, *args):  # pylint: disable=redefined-builtin,unused-argument
+    def log_message(self, format, *args):  # pylint: disable=redefined-builtin
         pass  # this prevents server dumping messages to stdout
 
 

sdk/identity/azure-identity/azure/identity/_internal/decorators.py

@@ -42,7 +42,7 @@ def wrapper(*args, **kwargs):
                 except Exception as ex:  # pylint: disable=broad-except
                     _LOGGER.debug("Failed to log the account information: %s", ex, exc_info=True)
             return token
-        except Exception as ex:  # pylint: disable=broad-except
+        except Exception as ex:
             _LOGGER.log(
                 logging.DEBUG if within_credential_chain.get() else logging.WARNING,
                 "%s failed: %s",
@@ -70,7 +70,7 @@ def wrapper(*args, **kwargs):
             return fn(*args, **kwargs)
         except ClientAuthenticationError:
             raise
-        except Exception as ex:  # pylint:disable=broad-except
+        except Exception as ex:
             auth_error = ClientAuthenticationError(message="Authentication failed: {}".format(ex))
             raise auth_error from ex
 

sdk/identity/azure-identity/azure/identity/_internal/interactive.py

@@ -224,7 +224,7 @@ def _get_token_base(
 
             # this may be the first authentication, or the user may have authenticated a different identity
             self._auth_record = _build_auth_record(result)
-        except Exception as ex:  # pylint:disable=broad-except
+        except Exception as ex:
             _LOGGER.warning(
                 "%s.%s failed: %s",
                 self.__class__.__name__,