Skip to content

Commit 9302423

Browse files
authored
Fix type mis-match between Evaluation and EvaluationRun (Azure#43693)
* Fix type mis-match between Evaluation and EvaluationRun * Update sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluate/_utils.py
1 parent 190d4f1 commit 9302423

File tree

1 file changed

+7
-1
lines changed
  • sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluate

1 file changed

+7
-1
lines changed

sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluate/_utils.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,14 @@ def _log_metrics_and_instance_results_onedp(
197197
)
198198
)
199199

200+
# TODO: type mis-match because Evaluation instance is assigned to EvaluationRun
201+
evaluation_id = (
202+
upload_run_response.name # type: ignore[attr-defined]
203+
if hasattr(upload_run_response, "name")
204+
else upload_run_response.id
205+
)
200206
update_run_response = client.update_evaluation_run(
201-
name=upload_run_response.id,
207+
name=evaluation_id,
202208
evaluation=EvaluationUpload(
203209
display_name=evaluation_name,
204210
status="Completed",

0 commit comments

Comments
 (0)