Fix minor tracing issues in agents (Azure#39752)

* Fix minor issues in agents telemetry

* validate message status

Author: Liudmila Molkova

sdk/ai/azure-ai-projects/azure/ai/projects/telemetry/agents/_ai_agents_instrumentor.py

@@ -268,7 +268,7 @@ def _create_event_attributes(
             attrs[GEN_AI_MESSAGE_ID] = message_id
 
         if message_status:
-            attrs[GEN_AI_MESSAGE_STATUS] = message_status
+            attrs[GEN_AI_MESSAGE_STATUS] = self._status_to_string(message_status)
 
         if usage:
             attrs[GEN_AI_USAGE_INPUT_TOKENS] = usage.prompt_tokens
@@ -287,7 +287,7 @@ def add_thread_message_event(
                     content_details = {"value": self._get_field(typed_content, "value")}
                     annotations = self._get_field(typed_content, "annotations")
                     if annotations:
-                        content_details["annotations"] = annotations
+                        content_details["annotations"] = [a.as_dict() for a in annotations]
                     content_body[content.type] = content_details
 
         self._add_message_event(
@@ -386,6 +386,9 @@ def _get_role(self, role: Optional[Union[str, MessageRole]]) -> str:
 
         return role
 
+    def _status_to_string(self, status: Any) -> str:
+        return status.value if hasattr(status, "value") else status
+
     def _add_tool_assistant_message_event(self, span, step: RunStep) -> None:
         # do we want a new event for it ?
         tool_calls = [
@@ -418,7 +421,7 @@ def _add_tool_assistant_message_event(self, span, step: RunStep) -> None:
 
     def set_end_run(self, span: "AbstractSpan", run: Optional[ThreadRun]) -> None:
         if run and span and span.span_instance.is_recording:
-            span.add_attribute(GEN_AI_THREAD_RUN_STATUS, run.status)
+            span.add_attribute(GEN_AI_THREAD_RUN_STATUS, self._status_to_string(run.status))
             span.add_attribute(GEN_AI_RESPONSE_MODEL, run.model)
             if run and run.usage:
                 span.add_attribute(GEN_AI_USAGE_INPUT_TOKENS, run.usage.prompt_tokens)
@@ -897,7 +900,7 @@ async def trace_create_run_async(self, operation_name, function, *args, **kwargs
             try:
                 result = await function(*args, **kwargs)
                 if span.span_instance.is_recording:
-                    span.add_attribute(GEN_AI_THREAD_RUN_STATUS, result.status)
+                    span.add_attribute(GEN_AI_THREAD_RUN_STATUS, self._status_to_string(result.status))
                     span.add_attribute(GEN_AI_RESPONSE_MODEL, result.model)
                     if result.usage:
                         span.add_attribute(GEN_AI_USAGE_INPUT_TOKENS, result.usage.prompt_tokens)
@@ -1700,7 +1703,7 @@ def __exit__(self, exc_type, exc_val, exc_tb):
             self.instrumentor.set_end_run(self.span, self.last_run)
 
             if self.last_run and self.last_run.last_error:
-                self.span.set_status(
+                self.span.span_instance.set_status(
                     StatusCode.ERROR,  # pyright: ignore [reportPossiblyUnboundVariable]
                     self.last_run.last_error.message,
                 )

sdk/ai/azure-ai-projects/tests/telemetry/test_ai_agents_instrumentor.py

@@ -391,6 +391,7 @@ def test_agent_chat_with_tracing_content_recording_enabled(self, **kwargs):
                     "gen_ai.agent.id": "*",
                     "gen_ai.thread.run.id": "*",
                     "gen_ai.message.id": "*",
+                    "gen_ai.message.status": "completed",
                     "gen_ai.event.content": '{"content": {"text": {"value": "*"}}, "role": "assistant"}',
                 },
             },
@@ -1000,6 +1001,7 @@ def fetch_weather(location: str) -> str:
                     "gen_ai.agent.id": "*",
                     "gen_ai.thread.run.id": "*",
                     "gen_ai.message.id": "*",
+                    "gen_ai.message.status": "completed",
                     "gen_ai.event.content": '{"role": "assistant"}',
                 },
             },