fix sdk generation (Azure#39569)

* fix sdk generation

* fix

Author: msyyc

tools/azure-sdk-tools/packaging_tools/package_utils.py

@@ -1,5 +1,5 @@
 import os
-from typing import Optional
+from typing import Optional, Tuple
 from pathlib import Path
 import logging
 from subprocess import check_call, CalledProcessError, getoutput
@@ -41,42 +41,47 @@ def change_log_new(package_folder: str, lastest_pypi_version: bool) -> str:
     return "\n".join(result[begin + 1 : end]).strip()
 
 
-def change_log_generate(
-    package_name,
-    last_version,
-    tag_is_stable: bool = False,
-    *,
-    prefolder: Optional[str] = None,
-    is_multiapi: bool = False,
-):
+def get_version_info(package_name: str, tag_is_stable: bool = False) -> Tuple[str, str]:
     from pypi_tools.pypi import PyPIClient
 
-    client = PyPIClient()
     try:
+        client = PyPIClient()
         ordered_versions = client.get_ordered_versions(package_name)
         last_release = ordered_versions[-1]
         stable_releases = [x for x in ordered_versions if not x.is_prerelease]
-        last_stable_release = stable_releases[-1] if stable_releases else None
+        last_stable_release = stable_releases[-1] if stable_releases else ""
         if tag_is_stable:
-            last_version[-1] = str(last_stable_release) if last_stable_release else str(last_release)
+            last_version = str(last_stable_release) if last_stable_release else str(last_release)
         else:
-            last_version[-1] = str(last_release)
+            last_version = str(last_release)
     except:
-        return ("### Other Changes\n\n  - Initial version", last_version)
+        last_version = ""
+        last_stable_release = ""
+    return last_version, str(last_stable_release)
+
+
+def change_log_generate(
+    package_name,
+    last_version,
+    tag_is_stable: bool = False,
+    *,
+    last_stable_release: Optional[str] = None,
+    prefolder: Optional[str] = None,
+    is_multiapi: bool = False,
+):
+    if not last_version:
+        return "### Other Changes\n\n  - Initial version"
 
     # try new changelog tool
     if prefolder and not is_multiapi:
         try:
-            return (
-                change_log_new(str(Path(prefolder) / package_name), not (last_stable_release and tag_is_stable)),
-                last_version,
-            )
+            return change_log_new(str(Path(prefolder) / package_name), not (last_stable_release and tag_is_stable))
         except Exception as e:
             _LOGGER.warning(f"Failed to generate changelog with breaking_change_detector: {e}")
 
     # fallback to old changelog tool
     _LOGGER.info("Fallback to old changelog tool")
-    return (change_log_main(f"{package_name}:pypi", f"{package_name}:latest", tag_is_stable), last_version)
+    return change_log_main(f"{package_name}:pypi", f"{package_name}:latest", tag_is_stable)
 
 
 def extract_breaking_change(changelog):

tools/azure-sdk-tools/packaging_tools/sdk_package.py

@@ -9,7 +9,7 @@
 import multiprocessing
 from functools import partial
 
-from .package_utils import create_package, change_log_generate, extract_breaking_change
+from .package_utils import create_package, change_log_generate, extract_breaking_change, get_version_info
 
 logging.basicConfig(
     stream=sys.stdout,
@@ -35,17 +35,18 @@ def main(generate_input, generate_output):
         package_name = package["packageName"]
         prefolder = package["path"][0]
         # Changelog
-        last_version = ["first release"]
+        last_version, last_stable_release = get_version_info(package_name, package["tagIsStable"])
         change_log_func = partial(
             change_log_generate,
             package_name,
             last_version,
             package["tagIsStable"],
+            last_stable_release=last_stable_release,
             prefolder=prefolder,
             is_multiapi=package["isMultiapi"],
         )
         try:
-            md_output, last_version = execute_func_with_timeout(change_log_func)
+            md_output = execute_func_with_timeout(change_log_func)
         except multiprocessing.TimeoutError:
             md_output = "change log generation was timeout!!!"
         except:
@@ -55,7 +56,7 @@ def main(generate_input, generate_output):
             "hasBreakingChange": "Breaking Changes" in md_output,
             "breakingChangeItems": extract_breaking_change(md_output),
         }
-        package["version"] = last_version[-1]
+        package["version"] = last_version
 
         _LOGGER.info(f"[PACKAGE]({package_name})[CHANGELOG]:{md_output}")
         # Built package