[Storage] [Next Pylint] Oct next-pylint Patches (Azure#37264)

Author: weirongw23-msft

sdk/storage/azure-storage-blob-changefeed/azure/storage/blob/changefeed/_change_feed_client.py

@@ -3,7 +3,7 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
-# pylint: disable=too-many-lines, docstring-keyword-should-match-keyword-only
+# pylint: disable=docstring-keyword-should-match-keyword-only
 
 from typing import (
     Any, Dict, Optional, Union,

sdk/storage/azure-storage-blob-changefeed/azure/storage/blob/changefeed/_models.py

@@ -3,8 +3,7 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
-# pylint: disable=too-few-public-methods, too-many-instance-attributes
-# pylint: disable=super-init-not-called, too-many-lines
+# pylint: disable=too-few-public-methods
 import collections
 import copy
 import json

sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client.py

@@ -187,7 +187,7 @@ def __init__(
         self._query_str, credential = self._format_query_string(sas_token, credential, snapshot=self.snapshot)
         super(BlobClient, self).__init__(parsed_url, service='blob', credential=credential, **kwargs)
         self._client = AzureBlobStorage(self.url, base_url=self.url, pipeline=self._pipeline)
-        self._client._config.version = get_api_version(kwargs)  # type: ignore [assignment] # pylint: disable=protected-access
+        self._client._config.version = get_api_version(kwargs)  # type: ignore [assignment]
         self._configure_encryption(kwargs)
 
     def _format_url(self, hostname: str) -> str:
@@ -3289,7 +3289,7 @@ def _get_container_client(self) -> "ContainerClient":
                 policies=self._pipeline._impl_policies # pylint: disable = protected-access
             )
         else:
-            _pipeline = self._pipeline  # pylint: disable = protected-access
+            _pipeline = self._pipeline
         return ContainerClient(
             f"{self.scheme}://{self.primary_hostname}", container_name=self.container_name,
             credential=self._raw_credential, api_version=self.api_version, _configuration=self._config,

sdk/storage/azure-storage-blob/azure/storage/blob/_blob_client_helpers.py

@@ -229,7 +229,7 @@ def _upload_blob_from_url_options(source_url: str, **kwargs: Any) -> Dict[str, A
         'headers': headers,
     }
     options.update(kwargs)
-    if not overwrite and not _any_conditions(**options): # pylint: disable=protected-access
+    if not overwrite and not _any_conditions(**options):
         options['modified_access_conditions'].if_none_match = '*'
     return options
 

sdk/storage/azure-storage-blob/azure/storage/blob/_blob_service_client.py

@@ -128,7 +128,7 @@ def __init__(
         self._query_str, credential = self._format_query_string(sas_token, credential)
         super(BlobServiceClient, self).__init__(parsed_url, service='blob', credential=credential, **kwargs)
         self._client = AzureBlobStorage(self.url, base_url=self.url, pipeline=self._pipeline)
-        self._client._config.version = get_api_version(kwargs)  # type: ignore [assignment] # pylint: disable=protected-access
+        self._client._config.version = get_api_version(kwargs)  # type: ignore [assignment]
         self._configure_encryption(kwargs)
 
     def _format_url(self, hostname):

sdk/storage/azure-storage-blob/azure/storage/blob/_container_client.py

@@ -624,7 +624,7 @@ def set_container_metadata(
             process_storage_error(error)
 
     @distributed_trace
-    def _get_blob_service_client(self) -> "BlobServiceClient":  # pylint: disable=client-method-missing-kwargs
+    def _get_blob_service_client(self) -> "BlobServiceClient":
         """Get a client to interact with the container's parent service account.
 
         Defaults to current container's credentials.
@@ -648,7 +648,7 @@ def _get_blob_service_client(self) -> "BlobServiceClient":  # pylint: disable=cl
                 policies=self._pipeline._impl_policies # pylint: disable = protected-access
             )
         else:
-            _pipeline = self._pipeline   # pylint: disable = protected-access
+            _pipeline = self._pipeline
         return BlobServiceClient(
             f"{self.scheme}://{self.primary_hostname}",
             credential=self._raw_credential, api_version=self.api_version, _configuration=self._config,

sdk/storage/azure-storage-blob/azure/storage/blob/_container_client_helpers.py

@@ -132,7 +132,7 @@ def _generate_delete_blobs_options(
     for blob in blobs:
         if not isinstance(blob, str):
             blob_name = blob.get('name')
-            options = _generic_delete_blob_options(  # pylint: disable=protected-access
+            options = _generic_delete_blob_options(
                 snapshot=blob.get('snapshot'),
                 version_id=blob.get('version_id'),
                 delete_snapshots=delete_snapshots or blob.get('delete_snapshots'),
@@ -147,7 +147,7 @@ def _generate_delete_blobs_options(
             )
         else:
             blob_name = blob
-            options = _generic_delete_blob_options(  # pylint: disable=protected-access
+            options = _generic_delete_blob_options(
                 delete_snapshots=delete_snapshots,
                 if_modified_since=if_modified_since,
                 if_unmodified_since=if_unmodified_since,
@@ -199,11 +199,11 @@ def _generate_set_tiers_subrequest_options(
         query_parameters['versionid'] = client._serialize.query("version_id", version_id, 'str')  # pylint: disable=protected-access
     if timeout is not None:
         query_parameters['timeout'] = client._serialize.query("timeout", timeout, 'int', minimum=0)  # pylint: disable=protected-access
-    query_parameters['comp'] = client._serialize.query("comp", comp, 'str')  # pylint: disable=protected-access, specify-parameter-names-in-call
+    query_parameters['comp'] = client._serialize.query("comp", comp, 'str')  # pylint: disable=protected-access
 
     # Construct headers
     header_parameters = {}
-    header_parameters['x-ms-access-tier'] = client._serialize.header("tier", tier, 'str')  # pylint: disable=protected-access, specify-parameter-names-in-call
+    header_parameters['x-ms-access-tier'] = client._serialize.header("tier", tier, 'str')  # pylint: disable=protected-access
     if rehydrate_priority is not None:
         header_parameters['x-ms-rehydrate-priority'] = client._serialize.header(  # pylint: disable=protected-access
             "rehydrate_priority", rehydrate_priority, 'str')

sdk/storage/azure-storage-blob/azure/storage/blob/_deserialize.py

@@ -142,7 +142,7 @@ def service_properties_deserialize(generated: "StorageServiceProperties") -> Dic
         'hour_metrics': Metrics._from_generated(generated.hour_metrics),  # pylint: disable=protected-access
         'minute_metrics': Metrics._from_generated(generated.minute_metrics),  # pylint: disable=protected-access
         'cors': cors_list,
-        'target_version': generated.default_service_version,  # pylint: disable=protected-access
+        'target_version': generated.default_service_version,
         'delete_retention_policy': RetentionPolicy._from_generated(generated.delete_retention_policy),  # pylint: disable=protected-access
         'static_website': StaticWebsite._from_generated(generated.static_website),  # pylint: disable=protected-access
     }
@@ -181,7 +181,7 @@ def get_blob_properties_from_generated_code(generated: "BlobItemInternal") -> Bl
     blob.version_id = generated.version_id
     blob.is_current_version = generated.is_current_version
     blob.tag_count = generated.properties.tag_count
-    blob.tags = parse_tags(generated.blob_tags)  # pylint: disable=protected-access
+    blob.tags = parse_tags(generated.blob_tags)
     blob.object_replication_source_properties = deserialize_ors_policies(generated.object_replication_metadata)
     blob.last_accessed_on = generated.properties.last_accessed_on
     blob.immutability_policy = ImmutabilityPolicy._from_generated(generated)  # pylint: disable=protected-access

sdk/storage/azure-storage-blob/azure/storage/blob/_encryption.py

@@ -508,6 +508,8 @@ def _generate_encryption_data_dict(
         # We must pad the version to 8 bytes for AES Keywrap algorithms
         to_wrap = _ENCRYPTION_PROTOCOL_V2.encode().ljust(8, b'\0') + cek
         wrapped_cek = kek.wrap_key(to_wrap)
+    else:
+        raise ValueError("Invalid encryption version specified.")
 
     # Build the encryption_data dict.
     # Use OrderedDict to comply with Java's ordering requirement.

sdk/storage/azure-storage-blob/azure/storage/blob/_list_blobs_helper.py

@@ -110,7 +110,7 @@ def _build_item(self, item: Union[BlobItemInternal, BlobProperties]) -> BlobProp
         if isinstance(item, BlobProperties):
             return item
         if isinstance(item, BlobItemInternal):
-            blob = get_blob_properties_from_generated_code(item)  # pylint: disable=protected-access
+            blob = get_blob_properties_from_generated_code(item)
             blob.container = self.container  # type: ignore [assignment]
             return blob
         return item