Skip to content

Commit 9e5dd05

Browse files
author
Liudmila Molkova
authored
suppress generic spans for manually instrumented operations (Azure#40010)
1 parent 7e70af1 commit 9e5dd05

File tree

1 file changed

+18
-2
lines changed

1 file changed

+18
-2
lines changed

sdk/ai/azure-ai-projects/azure/ai/projects/telemetry/agents/_ai_agents_instrumentor.py

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1100,8 +1100,6 @@ def trace_create_stream(self, function, *args, **kwargs):
11001100
if span is None:
11011101
return function(*args, **kwargs)
11021102

1103-
# TODO: how to keep span active in the current context without existing?
1104-
# TODO: dummy span for none
11051103
with span.change_context(span.span_instance):
11061104
try:
11071105
kwargs["event_handler"] = self.wrap_handler(event_handler, span)
@@ -1332,24 +1330,33 @@ def inner(*args, **kwargs): # pylint: disable=R0911
13321330
class_function_name = function.__qualname__
13331331

13341332
if class_function_name.startswith("AgentsOperations.create_agent"):
1333+
kwargs.setdefault('merge_span', True)
13351334
return self.trace_create_agent(function, *args, **kwargs)
13361335
if class_function_name.startswith("AgentsOperations.create_thread"):
1336+
kwargs.setdefault('merge_span', True)
13371337
return self.trace_create_thread(function, *args, **kwargs)
13381338
if class_function_name.startswith("AgentsOperations.create_message"):
1339+
kwargs.setdefault('merge_span', True)
13391340
return self.trace_create_message(function, *args, **kwargs)
13401341
if class_function_name.startswith("AgentsOperations.create_run"):
1342+
kwargs.setdefault('merge_span', True)
13411343
return self.trace_create_run(OperationName.START_THREAD_RUN, function, *args, **kwargs)
13421344
if class_function_name.startswith("AgentsOperations.create_and_process_run"):
1345+
kwargs.setdefault('merge_span', True)
13431346
return self.trace_create_run(OperationName.PROCESS_THREAD_RUN, function, *args, **kwargs)
13441347
if class_function_name.startswith("AgentsOperations.submit_tool_outputs_to_run"):
1348+
kwargs.setdefault('merge_span', True)
13451349
return self.trace_submit_tool_outputs(False, function, *args, **kwargs)
13461350
if class_function_name.startswith("AgentsOperations.submit_tool_outputs_to_stream"):
1351+
kwargs.setdefault('merge_span', True)
13471352
return self.trace_submit_tool_outputs(True, function, *args, **kwargs)
13481353
if class_function_name.startswith("AgentsOperations._handle_submit_tool_outputs"):
13491354
return self.trace_handle_submit_tool_outputs(function, *args, **kwargs)
13501355
if class_function_name.startswith("AgentsOperations.create_stream"):
1356+
kwargs.setdefault('merge_span', True)
13511357
return self.trace_create_stream(function, *args, **kwargs)
13521358
if class_function_name.startswith("AgentsOperations.list_messages"):
1359+
kwargs.setdefault('merge_span', True)
13531360
return self.trace_list_messages(function, *args, **kwargs)
13541361
if class_function_name.startswith("AgentRunStream.__exit__"):
13551362
return self.handle_run_stream_exit(function, *args, **kwargs)
@@ -1391,24 +1398,33 @@ async def inner(*args, **kwargs): # pylint: disable=R0911
13911398
class_function_name = function.__qualname__
13921399

13931400
if class_function_name.startswith("AgentsOperations.create_agent"):
1401+
kwargs.setdefault('merge_span', True)
13941402
return await self.trace_create_agent_async(function, *args, **kwargs)
13951403
if class_function_name.startswith("AgentsOperations.create_thread"):
1404+
kwargs.setdefault('merge_span', True)
13961405
return await self.trace_create_thread_async(function, *args, **kwargs)
13971406
if class_function_name.startswith("AgentsOperations.create_message"):
1407+
kwargs.setdefault('merge_span', True)
13981408
return await self.trace_create_message_async(function, *args, **kwargs)
13991409
if class_function_name.startswith("AgentsOperations.create_run"):
1410+
kwargs.setdefault('merge_span', True)
14001411
return await self.trace_create_run_async(OperationName.START_THREAD_RUN, function, *args, **kwargs)
14011412
if class_function_name.startswith("AgentsOperations.create_and_process_run"):
1413+
kwargs.setdefault('merge_span', True)
14021414
return await self.trace_create_run_async(OperationName.PROCESS_THREAD_RUN, function, *args, **kwargs)
14031415
if class_function_name.startswith("AgentsOperations.submit_tool_outputs_to_run"):
1416+
kwargs.setdefault('merge_span', True)
14041417
return await self.trace_submit_tool_outputs_async(False, function, *args, **kwargs)
14051418
if class_function_name.startswith("AgentsOperations.submit_tool_outputs_to_stream"):
1419+
kwargs.setdefault('merge_span', True)
14061420
return await self.trace_submit_tool_outputs_async(True, function, *args, **kwargs)
14071421
if class_function_name.startswith("AgentsOperations._handle_submit_tool_outputs"):
14081422
return await self.trace_handle_submit_tool_outputs_async(function, *args, **kwargs)
14091423
if class_function_name.startswith("AgentsOperations.create_stream"):
1424+
kwargs.setdefault('merge_span', True)
14101425
return await self.trace_create_stream_async(function, *args, **kwargs)
14111426
if class_function_name.startswith("AgentsOperations.list_messages"):
1427+
kwargs.setdefault('merge_span', True)
14121428
return await self.trace_list_messages_async(function, *args, **kwargs)
14131429
if class_function_name.startswith("AsyncAgentRunStream.__aexit__"):
14141430
return self.handle_run_stream_exit(function, *args, **kwargs)

0 commit comments

Comments
 (0)