Improve code coverage deployment and endpoint e2e tests (Azure#39842)

* unskip deployment and endpoint e2e tests

* update online deployment config setup

* fix online deployment e2e tests

* fix test mlclient issue

* fix failing tests

* fix failing tests

* unskip endpoint test

* update recordings

* add deployment update test

* update recordings

* recording updated

* update recordings

* update deployment

* update recordings

* update recordings

* reformat code

* update recordings

* remove unnecessary file

* update recordings

Author: pdhotems

sdk/ml/azure-ai-ml/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "python",
   "TagPrefix": "python/ml/azure-ai-ml",
-  "Tag": "python/ml/azure-ai-ml_8d69a348d2"
+  "Tag": "python/ml/azure-ai-ml_57e03d7d64"
 }

sdk/ml/azure-ai-ml/tests/environment/unittests/test_env_entity.py

@@ -127,8 +127,8 @@ def test_anonymous_environment_version_changes_with_inference_config(self):
 
         assert env_no_inference_config.name == env_no_inference_config.name == ANONYMOUS_ENV_NAME
         assert env_no_inference_config.version != env_with_inference_config.version
-        assert env_no_inference_config.version == "00b3749100a718714b17f57de1ae61fa"
-        assert env_with_inference_config.version == "935315c7d8de8e0972f0460960727a17"
+        assert env_no_inference_config.version == "25484232c6e5bfb2c6e1dc5d38fb9fa5"
+        assert env_with_inference_config.version == "b181e0fef2ad76757e2f78317c10cb2b"
 
     def test_ipp_environment(self) -> None:
         # test through deserializing REST instead of using real IP assets

sdk/ml/azure-ai-ml/tests/online_services/e2etests/test_online_deployment.py

@@ -4,22 +4,19 @@
 from devtools_testutils import AzureRecordedTestCase
 
 from azure.ai.ml import MLClient, load_online_deployment, load_online_endpoint
-from azure.ai.ml.constants import AssetTypes
-from azure.ai.ml.entities import ManagedOnlineDeployment, ManagedOnlineEndpoint, Model
+from azure.ai.ml.entities import ManagedOnlineDeployment, ManagedOnlineEndpoint, Model, CodeConfiguration, Environment
 
 
 @pytest.mark.e2etest
+@pytest.mark.usefixtures("recorded_test", "mock_asset_name", "mock_component_hash", "mock_code_hash")
 @pytest.mark.production_experiences_test
 class TestOnlineDeployment(AzureRecordedTestCase):
-    @pytest.mark.skip(
-        reason="Tests failing in internal automation due to lack of quota. Cannot record or run in live mode."
-    )
-    def test_online_deployment(
+    def test_online_deployment_create(
         self, client: MLClient, rand_online_name: Callable[[], str], rand_online_deployment_name: Callable[[], str]
     ) -> None:
         endpoint_yaml = "tests/test_configs/deployments/online/simple_online_endpoint_mir.yaml"
         deployment_yaml = "tests/test_configs/deployments/online/online_deployment_1.yaml"
-        name = rand_online_name("name")
+        name = rand_online_name("endpoint_name")
         endpoint = load_online_endpoint(endpoint_yaml)
         endpoint.name = name
 
@@ -53,7 +50,42 @@ def test_online_deployment(
         finally:
             client.online_endpoints.begin_delete(name=endpoint.name)
 
-    @pytest.mark.skip(reason="Known failure")
+    def test_online_deployment_update(
+        self, client: MLClient, rand_online_name: Callable[[], str], rand_online_deployment_name: Callable[[], str]
+    ) -> None:
+        endpoint_yaml = "tests/test_configs/deployments/online/simple_online_endpoint_mir.yaml"
+        deployment_yaml = "tests/test_configs/deployments/online/online_deployment_1.yaml"
+        endpoint = load_online_endpoint(endpoint_yaml)
+        endpoint_name = rand_online_name("endpoint-name")
+        endpoint.name = endpoint_name
+        deployment = load_online_deployment(deployment_yaml)
+        deployment_name = rand_online_deployment_name("deployment_name")
+        deployment.name = deployment_name
+        deployment.endpoint_name = endpoint_name
+
+        # create a endpoint
+        client.online_endpoints.begin_create_or_update(endpoint).result()
+
+        try:
+            # create a deployment
+            client.online_deployments.begin_create_or_update(deployment).result()
+            dep = client.online_deployments.get(name=deployment.name, endpoint_name=endpoint.name)
+            assert dep.name == deployment.name
+
+            deps = client.online_deployments.list(endpoint_name=endpoint.name)
+            deps = list(deps)
+            assert len(deps) == 1
+            assert deps[0].name == deployment.name
+
+            dep.instance_count = 3
+            updated_deploymwnt = client.online_deployments.begin_create_or_update(dep).result()
+            assert updated_deploymwnt.instance_count == 3
+
+        except Exception as ex:
+            raise ex
+        finally:
+            client.online_endpoints.begin_delete(name=endpoint.name)
+
     def test_online_deployment_skip_script_validation(
         self, client: MLClient, rand_online_name: Callable[[], str], rand_online_deployment_name: Callable[[], str]
     ) -> None:
@@ -74,21 +106,31 @@ def test_online_deployment_skip_script_validation(
             # create a blue deployment
             model = Model(
                 name="test-model",
-                version="4",
-                path="tests/test_configs/deployments/sklearn-diabetes/model",
-                type=AssetTypes.MLFLOW_MODEL,
+                path="tests/test_configs/deployments/model-1/model",
                 description="my sample mlflow model",
             )
 
+            code_config = CodeConfiguration(
+                code="tests/test_configs/deployments/model-1/onlinescoring/",
+                scoring_script="score.py",
+            )
+
+            environment = Environment(
+                conda_file="tests/test_configs/deployments/model-1/environment/conda.yml",
+                image="mcr.microsoft.com/azureml/openmpi4.1.0-ubuntu20.04:latest",
+            )
+
             blue_deployment = ManagedOnlineDeployment(
                 name=online_deployment_name,
                 endpoint_name=online_endpoint_name,
+                code_configuration=code_config,
+                environment=environment,
                 model=model,
-                instance_type="Standard_F4s_v2",
+                instance_type="Standard_DS3_v2",
                 instance_count=1,
             )
 
-            client.online_deployments.begin_create_or_update(blue_deployment).result()
+            client.online_deployments.begin_create_or_update(blue_deployment, skip_script_validation=True).result()
         except Exception as ex:
             raise ex
         finally: