resolve comments from API review (Azure#38352)

Co-authored-by: annie-mac <[email protected]>

Author: xinlian12

sdk/cosmos/azure-cosmos/azure/cosmos/_vector_session_token.py

@@ -23,7 +23,7 @@
 """
 
 from . import exceptions
-from .http_constants import StatusCodes
+from .http_constants import StatusCodes as _StatusCodes
 
 
 class VectorSessionToken(object):
@@ -119,7 +119,7 @@ def merge(self, other):
 
         if self.version == other.version and len(self.local_lsn_by_region) != len(other.local_lsn_by_region):
             raise exceptions.CosmosHttpResponseError(
-                status_code=StatusCodes.INTERNAL_SERVER_ERROR,
+                status_code=_StatusCodes.INTERNAL_SERVER_ERROR,
                 message=("Compared session tokens '%s' and '%s' have unexpected regions."
                          % (self.session_token, other.session_token))
             )
@@ -146,7 +146,7 @@ def merge(self, other):
                 highest_local_lsn_by_region[region_id] = max(local_lsn1, local_lsn2)
             elif self.version == other.version:
                 raise exceptions.CosmosHttpResponseError(
-                    status_code=StatusCodes.INTERNAL_SERVER_ERROR,
+                    status_code=_StatusCodes.INTERNAL_SERVER_ERROR,
                     message=("Compared session tokens '%s' and '%s' have unexpected regions."
                              % (self.session_token, other.session_token))
                 )

sdk/cosmos/azure-cosmos/azure/cosmos/database.py

@@ -34,7 +34,7 @@
 from ._base import build_options, _set_throughput_options, _deserialize_throughput, _replace_throughput
 from .container import ContainerProxy
 from .offer import Offer, ThroughputProperties
-from .http_constants import StatusCodes
+from .http_constants import StatusCodes as _StatusCodes
 from .exceptions import CosmosResourceNotFoundError
 from .user import UserProxy
 from .documents import IndexingMode
@@ -826,7 +826,7 @@ def get_throughput(self, **kwargs: Any) -> ThroughputProperties:
         throughput_properties = list(self.client_connection.QueryOffers(query_spec, **kwargs))
         if not throughput_properties:
             raise CosmosResourceNotFoundError(
-                status_code=StatusCodes.NOT_FOUND,
+                status_code=_StatusCodes.NOT_FOUND,
                 message="Could not find ThroughputProperties for database " + self.database_link)
 
         if response_hook:
@@ -859,7 +859,7 @@ def replace_throughput(
         throughput_properties = list(self.client_connection.QueryOffers(query_spec))
         if not throughput_properties:
             raise CosmosResourceNotFoundError(
-                status_code=StatusCodes.NOT_FOUND,
+                status_code=_StatusCodes.NOT_FOUND,
                 message="Could not find ThroughputProperties for database " + self.database_link)
         new_offer = throughput_properties[0].copy()
         _replace_throughput(throughput=throughput, new_throughput_properties=new_offer)

sdk/cosmos/azure-cosmos/azure/cosmos/exceptions.py

@@ -28,7 +28,7 @@
     ResourceNotFoundError
 )
 from . import http_constants
-from .http_constants import StatusCodes, SubStatusCodes
+from .http_constants import StatusCodes as _StatusCode, SubStatusCodes as _SubStatusCodes
 
 class CosmosHttpResponseError(HttpResponseError):
     """An HTTP request to the Azure Cosmos database service has failed."""
@@ -136,21 +136,21 @@ def __init__(self, **kwargs):
         super(CosmosClientTimeoutError, self).__init__(message, **kwargs)
 
 def _partition_range_is_gone(e):
-    if (e.status_code == http_constants.StatusCodes.GONE
-            and e.sub_status == http_constants.SubStatusCodes.PARTITION_KEY_RANGE_GONE):
+    if (e.status_code == _StatusCode.GONE
+            and e.sub_status == _SubStatusCodes.PARTITION_KEY_RANGE_GONE):
         return True
     return False
 
 
 def _container_recreate_exception(e) -> bool:
-    is_bad_request = e.status_code == http_constants.StatusCodes.BAD_REQUEST
-    is_collection_rid_mismatch = e.sub_status == http_constants.SubStatusCodes.COLLECTION_RID_MISMATCH
+    is_bad_request = e.status_code == _StatusCode.BAD_REQUEST
+    is_collection_rid_mismatch = e.sub_status == _SubStatusCodes.COLLECTION_RID_MISMATCH
 
-    is_not_found = e.status_code == http_constants.StatusCodes.NOT_FOUND
-    is_throughput_not_found = e.sub_status == http_constants.SubStatusCodes.THROUGHPUT_OFFER_NOT_FOUND
+    is_not_found = e.status_code == _StatusCode.NOT_FOUND
+    is_throughput_not_found = e.sub_status == _SubStatusCodes.THROUGHPUT_OFFER_NOT_FOUND
 
     return (is_bad_request and is_collection_rid_mismatch) or (is_not_found and is_throughput_not_found)
 
 
 def _is_partition_split_or_merge(e):
-    return e.status_code == StatusCodes.GONE and e.status_code == SubStatusCodes.COMPLETING_SPLIT
+    return e.status_code == _StatusCode.GONE and e.status_code == _SubStatusCodes.COMPLETING_SPLIT